Ed Hennis
ae27376863
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-17 10:49:29 -04:00
Ed Hennis
e237f968c7
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-17 10:49:20 -04:00
Ed Hennis
b02b58e3b5
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-17 10:49:15 -04:00
Ed Hennis
d10ac3b169
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-17 10:49:11 -04:00
Ed Hennis
c37f863201
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-17 10:49:07 -04:00
Jingchen
9494fc9668
chore: Use self hosted windows runners ( #5780 )
...
This changes switches from the GitHub-managed Windows runners to self-hosted runners to significantly reduce build time.
2025-09-17 09:29:15 -04:00
Ed Hennis
1fbd3fcfa4
Handle Flags not present in LoanManage
...
- Addresses RIPD-3418
2025-09-16 19:31:01 -04:00
Ed Hennis
70755ed1d3
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-16 19:04:59 -04:00
Ed Hennis
6926c511cb
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-16 19:04:53 -04:00
Ed Hennis
e01dd6d5b0
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-16 19:04:49 -04:00
Ed Hennis
0bfd404111
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-16 19:04:45 -04:00
Ed Hennis
5c072579d7
Review feedback from @yinyiqian1 and @Bronek
...
- Rewrite all of the templates in Units.h to use concepts.
- Restrict to_short_string to reasonably sized values.
- Rephrase some comments, and fix some typos.
2025-09-16 18:50:24 -04:00
Ed Hennis
c118121337
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-16 17:19:54 -04:00
Ed Hennis
8a4c607af9
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-16 17:19:47 -04:00
Ed Hennis
f85ce9c742
Remove or simplify Transactor::isEnabled overrides
...
- Remove the ones where the only condition was the required amendment
specified in transactor.macro.
- Simplify the one that had other conditions, removing the required
amendment from the conditions.
2025-09-16 17:15:57 -04:00
Ed Hennis
49e1f97476
Fix formatting
2025-09-16 17:10:28 -04:00
Ed Hennis
47aa95fcc4
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-16 15:07:11 -04:00
Ed Hennis
dc5b0918da
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-16 15:07:04 -04:00
Ed Hennis
cb991523f8
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-16 15:07:00 -04:00
Ed Hennis
9683344940
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-16 15:06:55 -04:00
Ed Hennis
5ac905be01
Fix issuer MPT balance sign on tests introduced by 5571
2025-09-16 14:51:18 -04:00
Ed Hennis
4d5afbea3a
Merge remote-tracking branch 'XRPLF/ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
...
* XRPLF/ximinez/lending-refactoring-4:
Bugfix: Adds graceful peer disconnection (5669)
Support DynamicMPT XLS-94d (5705)
Only notify clio for PRs targeting the release and master branches (5794)
refactor: Wrap GitHub CI conditionals in curly braces (5796)
2025-09-16 11:26:18 -04:00
Ed Hennis
9d08fe9a03
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-16 11:15:04 -04:00
Ed Hennis
84e97f0ef5
Merge remote-tracking branch 'XRPLF/ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
...
* XRPLF/ximinez/lending-refactoring-2:
Bugfix: Adds graceful peer disconnection (5669)
Support DynamicMPT XLS-94d (5705)
Only notify clio for PRs targeting the release and master branches (5794)
refactor: Wrap GitHub CI conditionals in curly braces (5796)
2025-09-16 11:14:06 -04:00
Ed Hennis
4d24b5eac2
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-16 10:46:45 -04:00
Ed Hennis
935749fe1f
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-16 10:46:41 -04:00
Vito Tumas
17a2606591
Bugfix: Adds graceful peer disconnection ( #5669 )
...
The XRPL establishes connections in three stages: first a TCP connection, then a TLS/SSL handshake to secure the connection, and finally an upgrade to the bespoke XRP Ledger peer-to-peer protocol. During connection termination, xrpld directly closes the TCP connection, bypassing the TLS/SSL shutdown handshake. This makes peer disconnection diagnostics more difficult - abrupt TCP termination appears as if the peer crashed rather than disconnected gracefully.
This change refactors the connection lifecycle with the following changes:
- Enhanced outgoing connection logic with granular timeouts for each connection stage (TCP, TLS, XRPL handshake) to improve diagnostic capabilities
- Updated both PeerImp and ConnectAttempt to use proper asynchronous TLS shutdown procedures for graceful connection termination
2025-09-16 10:51:55 +01:00
Ed Hennis
49eb1cc54e
Remove LoanDraw transaction ( #5792 )
2025-09-16 00:30:02 +00:00
yinyiqian1
ccb9f1e42d
Support DynamicMPT XLS-94d ( #5705 )
...
* extends the functionality of the MPTokenIssuanceSet transaction, allowing the issuer to update fields or flags that were explicitly marked as mutable during creation.
2025-09-15 19:42:36 +00:00
Bart
3e4e9a2ddc
Only notify clio for PRs targeting the release and master branches ( #5794 )
...
Clio should only be notified when releases are about to be made, instead of for all PR, so this change only notifies Clio when a PR targets the release or master branch.
2025-09-15 13:28:47 -04:00
Bart
4caebfbd0e
refactor: Wrap GitHub CI conditionals in curly braces ( #5796 )
...
This change wraps all GitHub conditionals in `${{ .. }}`, both for consistency and to reduce unexpected failures, because it was previously noticed that not all conditionals work without those curly braces.
2025-09-15 16:26:08 +00:00
Ed Hennis
dee972e9cd
Merge remote-tracking branch 'XRPLF/ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
...
* XRPLF/ximinez/lending-refactoring-4:
Fix: EscrowTokenV1 (5571)
fix: Skip processing transaction batch if the batch is empty (5670)
ci: Fix conan secrets in `upload-conan-deps` (5785)
Fix code coverage error (5765)
docs: Add remote to `conan lock create` command (5770)
refactor: clean up `CTID.h` (5681)
2025-09-15 11:25:13 -04:00
Ed Hennis
bdeed43304
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-15 11:13:45 -04:00
Ed Hennis
7eff303160
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-15 11:13:40 -04:00
Ed Hennis
aa1341f42e
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-15 11:13:36 -04:00
Ed Hennis
91031dbec4
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-15 11:13:32 -04:00
Denis Angell
37c377a1b6
Fix: EscrowTokenV1 ( #5571 )
...
* resolves an accounting inconsistency in MPT escrows where transfer fees were not properly handled when unlocking escrowed tokens.
2025-09-15 14:48:47 +00:00
Jingchen
bd182c0a3e
fix: Skip processing transaction batch if the batch is empty ( #5670 )
...
Avoids an assertion failure in NetworkOPsImp::apply in the unlikely event that all incoming transactions are invalid.
2025-09-15 13:51:19 +00:00
Ayaz Salikhov
406c26cc72
ci: Fix conan secrets in upload-conan-deps ( #5785 )
...
- Accounts for some variables that were changed and missed when the reusable workflow was removed.
2025-09-12 17:09:42 +00:00
Jingchen
9bd1ce436a
Fix code coverage error ( #5765 )
...
* Fix the issue where COVERAGE_CXX_COMPILER_FLAGS is never used
2025-09-12 15:13:27 +00:00
Ayaz Salikhov
f69ad4eff6
docs: Add remote to conan lock create command ( #5770 )
...
* docs: Add remote to `conan lock create` command
* Document error resolution for conan package issues
* Update BUILD.md
* Add more info about lockfiles
2025-09-11 15:42:27 +00:00
Mayukha Vadari
6fe0599cc2
refactor: clean up CTID.h ( #5681 )
2025-09-11 14:49:26 +00:00
Ed Hennis
03da5da815
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-11 10:33:38 -04:00
Ed Hennis
fc860c1a1d
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-11 10:33:30 -04:00
Ed Hennis
2545bc5936
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-11 10:33:26 -04:00
Ed Hennis
9a9588eaf6
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-11 10:33:22 -04:00
Ed Hennis
abee3dd55c
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-11 10:33:17 -04:00
tequ
e6f8bc720f
Add additional metadata to simulate response ( #5754 )
2025-09-11 15:17:06 +01:00
Ayaz Salikhov
fbd60fc000
ci: Use pre-commit reusable workflow ( #5772 )
2025-09-11 13:58:11 +01:00
Ed Hennis
22d9ade2b0
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-10 20:36:49 -04:00
