Vito
aa5b02cde3
test: Update Vault+AMM tests for develop renames
...
Rename references after merging develop:
- testable_amendments -> testableAmendments
- mptInitNoFund -> kMPT_INIT_NO_FUND
- MPTDEXFlags -> kMPT_DEX_FLAGS
- ter -> Ter
2026-05-04 17:57:46 +02:00
Vito
99747f6b04
Merge remote-tracking branch 'origin/develop' into tapanito/unit-tests
2026-05-04 17:38:41 +02:00
Alex Kremer
8995564ed6
refactor: Enable clang-tidy readability-identifier-naming check ( #6571 )
2026-05-03 10:31:53 +00:00
Bart
182d844996
refactor: Revert certain Throws by LogicErrors ( #7036 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-01 09:50:00 +00:00
Vito Tumas
31180f94c2
fix: Prevents overwriting a bool value in an invariant ( #6609 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-30 13:05:09 +00:00
Bart
4d0ea8ae36
refactor: Apply various minor improvements and corrections ( #7045 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-30 10:22:11 +00:00
Zhiyuan Wang
dbd646bd53
fix: Store Delegate object in delegating and authorized account directories for proper deletion ( #6681 )
2026-04-29 18:17:01 +00:00
Mayukha Vadari
7be98d95de
fix: Make assorted RPC fixes ( #6529 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-29 18:05:34 +00:00
Alex Kremer
f7275b7ad9
chore: Enable clang-tidy v21 new checks ( #7031 )
2026-04-29 15:17:35 +00:00
Vito
fc620bf29a
test: Fix clang-tidy issues in new Vault+AMM tests
...
- AMM_test: directly include <xrpl/protocol/MPTIssue.h>
(misc-include-cleaner).
- Vault_test::testMutateCanTransferAfterDeposit: declare local Vault
const (misc-const-correctness).
2026-04-29 12:03:50 +02:00
Vito
b01ba1fce2
test: Add Vault+AMM integration coverage
...
- AMM_test::testVaultSharesAMM: pair vault-share MPT with XRP, do a
single-asset deposit of additional shares.
- AMM_test::testLockedVaultMPTCashOut: lock the underlying MPT of a
vault that backs an AMM and confirm the freeze cascades through
isVaultPseudoAccountFrozen, blocking LP-token Payment (tecPATH_DRY)
and AMM withdrawal (tecFROZEN).
- Vault_test::testMutateCanTransferAfterDeposit: exercise issuer
mutating lsfMPTCanTransfer / lsfMPTCanTrade after holders have
deposited. Confirms CanTrade has no effect on vault I/O, the
issuer-as-depositor path is exempt from canTransfer, and a holder
can still exit via VaultWithdraw with Destination = issuer while
CanTransfer is cleared.
2026-04-29 11:45:43 +02:00
Jingchen
46b997b774
feat: Create new transaction testing framework TxTest ( #6537 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com >
2026-04-28 14:16:10 +00:00
Pratik Mankawde
3547112540
fix: Fix ubsan flagged issues ( #6151 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-27 20:34:16 +00:00
Alex Kremer
4dc923dcc5
chore: Enable clang-tidy modernize-use-nodiscard check ( #7015 )
2026-04-24 17:19:30 +00:00
Zhiyuan Wang
a6bd9251d2
docs: Update hybrid offer invariant comment ( #7007 )
2026-04-24 16:35:10 +00:00
Mayukha Vadari
9ae29612ea
fix: Fix flaky CI tests ( #7005 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-24 13:23:43 +00:00
Mayukha Vadari
7cfa5d4610
fix: Make assorted Payments fixes ( #6585 )
2026-04-24 12:56:50 +00:00
Mayukha Vadari
248cb29681
refactor: Move LendingHelpers into libxrpl/ledger/helpers ( #6638 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-24 12:06:26 +00:00
Jingchen
7a449edebb
refactor: Clean up NetworkOPs ( #6575 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
2026-04-23 17:59:49 +00:00
Alex Kremer
19da25812b
fix: Remaining clang-tidy unchecked optionals ( #6979 )
2026-04-23 16:21:01 +00:00
Jingchen
7cd503859e
refactor: Remove seq from TMGetObjectByHash ( #6976 )
2026-04-23 13:59:23 +00:00
pdp2121
bd1b126230
feat: Add --definitions flag and artifact ( #6858 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-22 20:10:52 +00:00
Mayukha Vadari
1c6cdc653c
fix: More clang-tidy issues ( #6992 )
2026-04-22 17:42:15 +00:00
Vito Tumas
2e307329f0
refactor: Add transaction-specific invariant checking ( #6551 )
2026-04-22 14:41:19 +00:00
Jingchen
45d4aacb53
chore: Remove empty Taker.h ( #6984 )
2026-04-21 18:15:58 +00:00
Alex Kremer
ce3951bbb3
chore: Enable clang-tidy modernize checks ( #6975 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-21 15:32:51 +00:00
Alex Kremer
ea023121f5
fix: Add rounding to Vault invariants ( #6217 ) ( #6955 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-21 12:14:07 +00:00
yinyiqian1
4b198cd5bb
fix: Disallow MPTClearRequireAuth if is set ( #6712 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-20 21:25:52 +00:00
Alex Kremer
726f20c8f6
feat: Add GRPC TLS support ( #6374 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-20 17:12:14 +00:00
Zhiyuan Wang
96643bb0fa
fix: Check for empty sfAdditionalBooks array in hybrid offer invariant ( #6716 )
2026-04-20 17:10:28 +00:00
chuanshanjida
e83818241a
chore: Remove repetitive word in multiple files ( #6978 )
...
Signed-off-by: chuanshanjida <chuanshanjida@outlook.com >
2026-04-20 16:56:03 +00:00
Alex Kremer
653a383ff5
chore: Enable clang-tidy include cleaner ( #6947 )
2026-04-17 16:43:49 +00:00
Gregory Tsipenyuk
affe5835fe
fix: Change AMMClawback return code to tecNO_PERMISSION ( #6946 )
2026-04-17 14:19:58 +00:00
Alex Kremer
f1a5ba43ad
chore: Enable clang-tidy readability checks ( #6930 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-17 13:30:52 +00:00
Jingchen
4a73be499d
fix: Fix unity build for book step ( #6942 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-16 17:12:00 +00:00
Sergey Kuznetsov
d52d735543
chore: Move codegen venv setup into build stage ( #6617 )
...
Co-authored-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-15 18:50:49 +00:00
Alex Kremer
6a0ce46755
chore: Enable most clang-tidy bugprone checks ( #6929 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-14 20:24:21 +00:00
Bart
2f029a2120
refactor: Improve exception handling ( #6540 ) ( #6735 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-14 17:14:24 +00:00
Zhiyuan Wang
61fbde3a71
refactor: Remove unused notTooManyOffers function from NFTokenUtils ( #6737 )
2026-04-13 23:18:10 +00:00
Bart
e2e537b3bb
fix: Change Tuning::bookOffers minimum limit to 1 ( #6812 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-10 14:38:46 +00:00
Gregory Tsipenyuk
56c9d1d497
fix: Add description for terLOCKED error ( #6811 )
2026-04-08 20:56:19 +00:00
yinyiqian1
d52dd29d20
fix: Address AI reviewer comments for Permission Delegation ( #6675 )
2026-04-08 20:22:19 +00:00
Mayukha Vadari
7793b5f10b
refactor: Combine AMMHelpers and AMMUtils ( #6733 )
2026-04-08 17:38:33 +00:00
Gregory Tsipenyuk
dfcad69155
feat: Add MPT support to DEX ( #5285 )
2026-04-08 16:17:37 +00:00
Pratik Mankawde
6d1a5be8d2
fix: Handle WSClient write failure when server closes WebSocket ( #6671 )
...
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-07 19:15:40 +00:00
Bart
c00ed673a8
refactor: Rename non-functional uses of ripple(d) to xrpl(d) ( #6676 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-07 13:00:17 +00:00
Mayukha Vadari
f239256d87
refactor: Move more helper files into libxrpl/ledger/helpers ( #6731 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-06 22:36:32 +00:00
Mayukha Vadari
00761dbb67
fix: Minor RPC fixes ( #6730 )
2026-04-06 22:15:16 +00:00
Zhiyuan Wang
077e03ff33
fix: Prevent deletion of MPTokens with active escrow ( #6635 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-06 17:51:46 +00:00
Vito Tumas
7d524a03b8
fix: Clamp VaultClawback to assetsAvailable for zero-amount clawback ( #6646 )
2026-04-06 15:13:03 +00:00