Commit Graph

14355 Commits

Author SHA1 Message Date
Ed Hennis
a428a753ef Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-number-simple 2026-01-08 21:37:08 -04:00
Gregory Tsipenyuk
5dde3e0242 Check if a withdrawal amount exceeds any applicable receiving limit. (#6117)
- Check the trust line limit is not exceeded for a withdraw to a third party Destination account.
2026-01-09 00:44:13 +00:00
Ed Hennis
b11a7faf01 Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-number-simple 2026-01-08 20:13:09 -04:00
Vito Tumas
0dabf4eaf8 refactor: Rename raw state to theoretical state (#6187) 2026-01-09 00:11:02 +00:00
Ed Hennis
4303e67bea Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-number-simple 2026-01-08 19:40:03 -04:00
Vito Tumas
e763dc8a5e Fix bugs: frozen pseudo-account, and FLC cutoff (#6170)
- Fixes LoanManage tfBAD_LEDGER case by capping the amount of FLC to use to cover a loss at the amount of cover available.
- Check if the Vault pseudo-account is frozen in LoanBrokerSet
2026-01-08 22:12:29 +00:00
Ed Hennis
7c341917a5 Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-number-simple 2026-01-08 17:15:19 -04:00
Ed Hennis
81ae6f1ca9 Merge branch 'ximinez/lending-XLS-66-2' into ximinez/lending-XLS-66-ongoing 2026-01-08 17:11:00 -04:00
Ed Hennis
c2d273f9a2 Merge branch 'ximinez/develop-nolending' into ximinez/lending-XLS-66-2 2026-01-08 17:10:55 -04:00
Ed Hennis
0136bf89bd Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-number-simple 2026-01-08 17:10:49 -04:00
Ed Hennis
8ad4058a36 Fix typo 2026-01-08 16:10:14 -05:00
Ed Hennis
000b9139c7 Merge branch 'develop' into ximinez/develop-nolending 2026-01-08 17:07:36 -04:00
Ed Hennis
579311fffa Merge branch 'ximinez/lending-XLS-66-2' into ximinez/lending-XLS-66-ongoing 2026-01-08 17:05:47 -04:00
Ed Hennis
db0b80e5b1 Merge branch 'ximinez/develop-nolending' into ximinez/lending-XLS-66-2 2026-01-08 16:04:23 -05:00
Bart
e1d97bea12 ci: Use updated prepare-runner in actions and worfklows (#6188)
This change updates the XRPLF pre-commit workflow and prepare-runner action to their latest versions. For naming consistency the prepare-runner action changed the disable_ccache variable into enable_ccache, which matches our naming.
2026-01-08 15:02:59 -05:00
Ed Hennis
9526a30dbc Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-number-simple 2026-01-08 13:20:05 -04:00
Ed Hennis
1a192fea07 Merge branch 'ximinez/lending-XLS-66-2' into ximinez/lending-XLS-66-ongoing 2026-01-08 13:12:20 -04:00
Ed Hennis
5a95a7426e Merge branch 'ximinez/develop-nolending' into ximinez/lending-XLS-66-2 2026-01-08 13:12:16 -04:00
Ed Hennis
9c2c9afc9f Merge remote-tracking branch 'XRPLF/develop' into ximinez/develop-nolending
* XRPLF/develop:
  refactor: Fix typos, enable cspell pre-commit (5719)
  fix: Reorder Batch Preflight Errors (6176)
  refactor: Remove unused credentials signature hash prefix (6186)
  refactor: Fix spelling issues in all variables/functions (6184)
  refactor: Fix spelling issues in private/local variables and functions (6182)
  refactor: Fix typos in comments, configure cspell (6164)
  ci: Move variable into right place (6179)
  ci: Use ccache to cache build objects for speeding up building (6104)
2026-01-08 12:11:19 -05:00
Mayukha Vadari
53aa5ca903 refactor: Fix typos, enable cspell pre-commit (#5719)
This change fixes the last of the spelling issues, and enables the pre-commit (and CI) check for spelling. There are no functionality changes, but it does rename some enum values.
2026-01-08 10:34:49 -05:00
Denis Angell
510c0d82e9 fix: Reorder Batch Preflight Errors (#6176)
This change fixes https://github.com/XRPLF/rippled/issues/6058.
2026-01-08 13:48:39 +00:00
Mayukha Vadari
17565d21d4 refactor: Remove unused credentials signature hash prefix (#6186)
This change removes the unused credentials signature hash prefix from `HashPrefix.h`.
2026-01-08 08:29:59 -05:00
Ed Hennis
7265804170 Point back to the class documentation in mantissa() and exponent() 2026-01-07 19:43:07 -05:00
Ed Hennis
a06de68ce4 Bring back Number::Guard::doRound* functions
- Based on feedback from @shawnxie999.
2026-01-07 18:32:18 -05:00
Mayukha Vadari
07ff532d30 refactor: Fix spelling issues in all variables/functions (#6184)
This change fixes many typos in comments, variables, and public functions. There is no functionality change.
2026-01-07 21:30:35 +00:00
Ed Hennis
c88dd55d07 Add documentation and static_asserts for range
* Make `maxRep` public.
* Document why template normalize takes min/max params.
* Add a check to normalizeToRange to ensure there are no signed/unsigned
  conversion issues.
* static_assert that maxRep is >= maxMPTokenAmount and INITIAL_XRP at
  their definition points. If something ever changes so that it's not,
  we'll know immediately.
2026-01-07 14:47:52 -05:00
Mayukha Vadari
2c37ef7762 refactor: Fix spelling issues in private/local variables and functions (#6182)
This change fixes several typos in private/local variables and private functions. There is no functionality change.
2026-01-07 14:26:14 -05:00
Mayukha Vadari
3c9f5b6252 refactor: Fix typos in comments, configure cspell (#6164)
This change sets up a `cspell `configuration and fixes lots of typos in comments. There are no other code changes.
2026-01-07 12:10:19 -05:00
Bart
f80059e467 ci: Move variable into right place (#6179)
This change moves the `enable_ccache` variable in the `on-trigger.yml` file to the correct location.
2026-01-07 06:07:53 -05:00
Bart
d734c8dddd ci: Use ccache to cache build objects for speeding up building (#6104)
Right now, each pipeline invocation builds the source code from scratch. Although compiled Conan dependencies are cached in a remote server, the source build objects are not. We are able to further speed up our builds by leveraging `ccache`. This change enables caching of build objects using `ccache` on Linux, macOS, and Windows.
2026-01-07 01:34:21 +00:00
Ed Hennis
c5c89c28a7 Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-number-simple 2026-01-06 14:21:22 -05:00
Ed Hennis
48c1c56f0c Merge branch 'ximinez/lending-XLS-66-2' into ximinez/lending-XLS-66-ongoing 2026-01-06 14:18:36 -05:00
Ed Hennis
9159969f5e Merge branch 'ximinez/develop-nolending' into ximinez/lending-XLS-66-2 2026-01-06 14:18:32 -05:00
Ed Hennis
fcc75cfc01 Merge remote-tracking branch 'XRPLF/develop' into ximinez/develop-nolending
* XRPLF/develop:
  test: add more tests for `ledger_entry` RPC (5858)
  refactor: Rename `rippled.cfg` to `xrpld.cfg` (6098)
  Revert "chore: Pin ruamel.yaml<0.19 in pre-commit-hooks (6166)" (6167)
  chore: Pin ruamel.yaml<0.19 in pre-commit-hooks (6166)
  fix: Remove cryptographic libs from libxrpl Conan package (6163)
2026-01-06 14:17:57 -05:00
Ed Hennis
fa6047f05d Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-number-simple 2026-01-06 14:01:41 -05:00
Vito Tumas
76272ffd0f Add minimum grace period validation (#6133) 2026-01-06 11:30:26 -05:00
Ed Hennis
6303dd5314 fixup! Document the Number mantissa range switching 2026-01-06 11:17:00 -05:00
Ed Hennis
16ab78d3df Document the Number mantissa range switching
- Prompted by review feedback from @gregtatcam.
- Should be pretty thorough.
- Tweaked how the MantissaRange class is instantiated, and added
  a couple more static_asserts.
2026-01-05 20:16:53 -05:00
Mayukha Vadari
44d21b8f6d test: add more tests for ledger_entry RPC (#5858)
This change adds some basic tests for all the `ledger_entry` helper functions, so each ledger entry type is covered. There are further some minor refactors in `parseAMM` to provide better error messages. Finally, to improve readability, alphabetization was applied in the helper functions.
2026-01-05 10:54:24 -05:00
Bart
3d1b3a49b3 refactor: Rename rippled.cfg to xrpld.cfg (#6098)
This change renames all occurrences of `rippled.cfg` to `xrpld.cfg`. It also provides a script to allow developers to replicate the changes in their local branch or fork to avoid conflicts. For the time being it maintains support for `rippled.cfg` as config file, if `xrpld.cfg` does not exist.
2026-01-05 14:55:12 +00:00
Ayaz Salikhov
0b87a26f04 Revert "chore: Pin ruamel.yaml<0.19 in pre-commit-hooks (#6166)" (#6167)
This reverts commit 0f23ad820c.
2026-01-05 14:01:14 +00:00
Ayaz Salikhov
0f23ad820c chore: Pin ruamel.yaml<0.19 in pre-commit-hooks (#6166)
See https://github.com/pre-commit/pre-commit-hooks/issues/1229 for more details.
2026-01-02 11:53:33 -05:00
Michael Legleux
b7139da4d0 fix: Remove cryptographic libs from libxrpl Conan package (#6163)
* fix: rm crypto libs and fix protobuf path

* update/rm comments
2025-12-23 16:38:35 -08:00
Ed Hennis
35a296d9a2 Merge branch 'ximinez/lending-XLS-66-2' into ximinez/lending-XLS-66-ongoing 2025-12-23 19:27:57 -05:00
Ed Hennis
b659cae66c Merge branch 'ximinez/develop-nolending' into ximinez/lending-XLS-66-2 2025-12-23 19:27:53 -05:00
Ed Hennis
381944e223 Merge branch 'develop' into ximinez/develop-nolending 2025-12-22 17:51:55 -05:00
Ed Hennis
59cafb0172 Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-number-simple 2025-12-22 17:39:34 -05:00
Ed Hennis
c81b26b09e Add a few minor changes (#6158)
- Updates or fixes a couple of things I noticed while reviewing changes
  to the spec.
- Rename sfPreviousPaymentDate to sfPreviousPaymentDueDate.
- Make the vault asset cap check added in #6124 a little more robust:
  1. Check in preflight if the vault is _already_ over the limit.
  2. Prevent overflow when checking with the loan value. (Subtract
     instead of adding, in case the values are near maxint. Both return
     the same result. Also add a unit test so each case is covered.
2025-12-22 17:38:39 -05:00
Bart
40198d9792 ci: Remove superfluous build directory creation (#6159)
This change modifies the build directory structure from `build/build/xxx` or `.build/build/xxx` to just `build/xxx`. Namely, the `conanfile.py` has the CMake generators build directory hardcoded to `build/generators`. We may as well leverage the top-level build directory without introducing another layer of directory nesting.
2025-12-22 16:30:23 -05:00
Gregory Tsipenyuk
c91b9a0223 fix: Enable LP Deposits when the broker is the asset issuer (#6119)
* Replace accountHolds with accountSpendable when checking
for account funds in VaultDeposit and LoanBrokerCoverDeposit
2025-12-19 21:51:45 +00:00