Pratik Mankawde
875911f156
Merge branch 'develop' into pratik/Retire_fixUniversalNumber_amendment
...
# Conflicts:
# include/xrpl/basics/CountedObject.h
# include/xrpl/basics/Expected.h
# include/xrpl/basics/IntrusivePointer.ipp
# include/xrpl/basics/IntrusiveRefCounts.h
# include/xrpl/basics/Log.h
# include/xrpl/basics/Number.h
# include/xrpl/basics/SlabAllocator.h
# include/xrpl/basics/TaggedCache.h
# include/xrpl/basics/TaggedCache.ipp
# include/xrpl/basics/UptimeClock.h
# include/xrpl/basics/base_uint.h
# include/xrpl/basics/chrono.h
# include/xrpl/basics/hardened_hash.h
# include/xrpl/basics/partitioned_unordered_map.h
# include/xrpl/basics/tagged_integer.h
# include/xrpl/beast/clock/abstract_clock.h
# include/xrpl/beast/clock/basic_seconds_clock.h
# include/xrpl/beast/container/aged_unordered_map.h
# include/xrpl/beast/container/detail/aged_container_iterator.h
# include/xrpl/beast/container/detail/aged_unordered_container.h
# include/xrpl/beast/core/List.h
# include/xrpl/beast/core/LockFreeStack.h
# include/xrpl/beast/hash/hash_append.h
# include/xrpl/beast/insight/Counter.h
# include/xrpl/beast/insight/Event.h
# include/xrpl/beast/insight/Gauge.h
# include/xrpl/beast/insight/Hook.h
# include/xrpl/beast/insight/Meter.h
# include/xrpl/beast/net/IPEndpoint.h
# include/xrpl/beast/unit_test/detail/const_container.h
# include/xrpl/beast/unit_test/global_suites.h
# include/xrpl/beast/unit_test/match.h
# include/xrpl/beast/unit_test/recorder.h
# include/xrpl/beast/unit_test/reporter.h
# include/xrpl/beast/unit_test/results.h
# include/xrpl/beast/unit_test/suite.h
# include/xrpl/beast/unit_test/suite_info.h
# include/xrpl/beast/utility/Journal.h
# include/xrpl/beast/utility/PropertyStream.h
# include/xrpl/core/ClosureCounter.h
# include/xrpl/core/Coro.ipp
# include/xrpl/core/Job.h
# include/xrpl/core/JobQueue.h
# include/xrpl/core/JobTypeData.h
# include/xrpl/core/JobTypeInfo.h
# include/xrpl/core/JobTypes.h
# include/xrpl/core/LoadMonitor.h
# include/xrpl/core/detail/Workers.h
# include/xrpl/core/detail/semaphore.h
# include/xrpl/json/json_value.h
# include/xrpl/json/json_writer.h
# include/xrpl/ledger/Ledger.h
# include/xrpl/ledger/helpers/TokenHelpers.h
# include/xrpl/nodestore/NodeObject.h
# include/xrpl/protocol/AmountConversions.h
# include/xrpl/protocol/ApiVersion.h
# include/xrpl/protocol/Book.h
# include/xrpl/protocol/ErrorCodes.h
# include/xrpl/protocol/Feature.h
# include/xrpl/protocol/Indexes.h
# include/xrpl/protocol/Quality.h
# include/xrpl/protocol/SField.h
# include/xrpl/protocol/STAmount.h
# include/xrpl/protocol/STArray.h
# include/xrpl/protocol/STBase.h
# include/xrpl/protocol/STLedgerEntry.h
# include/xrpl/protocol/STObject.h
# include/xrpl/protocol/STPathSet.h
# include/xrpl/protocol/STTx.h
# include/xrpl/protocol/STValidation.h
# include/xrpl/protocol/STVector256.h
# include/xrpl/protocol/Serializer.h
# include/xrpl/protocol/XRPAmount.h
# include/xrpl/protocol/detail/features.macro
# include/xrpl/protocol/json_get_or_throw.h
# include/xrpl/resource/Charge.h
# include/xrpl/resource/Consumer.h
# include/xrpl/server/InfoSub.h
# include/xrpl/shamap/FullBelowCache.h
# include/xrpl/shamap/SHAMapAddNode.h
# src/libxrpl/protocol/AMMCore.cpp
# src/libxrpl/protocol/IOUAmount.cpp
# src/libxrpl/protocol/STAmount.cpp
# src/libxrpl/tx/Transactor.cpp
# src/libxrpl/tx/applySteps.cpp
# src/test/app/AMM_test.cpp
# src/test/app/NFToken_test.cpp
# src/test/app/OfferMPT_test.cpp
# src/test/app/Offer_test.cpp
# src/test/jtx/AMM.h
# src/test/jtx/AMMTest.h
# src/test/jtx/Env.h
# src/test/jtx/Env_ss.h
# src/test/jtx/JTx.h
# src/test/jtx/PathSet.h
# src/test/jtx/TestHelpers.h
# src/test/jtx/amount.h
# src/test/jtx/balance.h
# src/test/jtx/batch.h
# src/test/jtx/credentials.h
# src/test/jtx/deposit.h
# src/test/jtx/escrow.h
# src/test/jtx/jtx_json.h
# src/test/jtx/mpt.h
# src/test/jtx/multisign.h
# src/test/jtx/paths.h
# src/test/jtx/prop.h
# src/test/jtx/regkey.h
# src/test/jtx/tags.h
# src/xrpld/app/misc/TxQ.h
# src/xrpld/app/misc/detail/TxQ.cpp
# src/xrpld/rpc/detail/AssetCache.h
# src/xrpld/rpc/detail/Pathfinder.h
# src/xrpld/rpc/detail/TrustLine.h
2026-05-05 13:49:14 +01:00
Pratik Mankawde
87f4a482c1
refactor: Align identifier naming with develop
...
Apply readability-identifier-naming clang-tidy check to branch-modified
files (and their transitive includes) in preparation for merging develop.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-05 13:43:49 +01:00
Alex Kremer
8995564ed6
refactor: Enable clang-tidy readability-identifier-naming check ( #6571 )
2026-05-03 10:31:53 +00:00
Pratik Mankawde
e9210ccb2e
Merge branch 'develop' into pratik/Retire_fixUniversalNumber_amendment
2026-05-01 15:02:43 +01:00
Pratik Mankawde
b9d35bbd5a
Merge branch 'pratik/Retire_fixUniversalNumber_amendment' of github.com:XRPLF/rippled into pratik/Retire_fixUniversalNumber_amendment
2026-05-01 15:02:28 +01:00
Pratik Mankawde
6e57c9e5b0
fixing bad merge issue
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-01 13:02:35 +01:00
Bart
182d844996
refactor: Revert certain Throws by LogicErrors ( #7036 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-01 09:50:00 +00:00
Pratik Mankawde
de744488bc
Merge branch 'develop' into pratik/Retire_fixUniversalNumber_amendment
2026-04-30 15:23:10 +01:00
Pratik Mankawde
444285dc75
minor cleanup
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-04-30 15:22:50 +01:00
Pratik Mankawde
7015d609e8
clang-tidy fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-04-30 14:45:30 +01:00
Pratik Mankawde
9edeb51b81
fixed 2 issues
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-04-30 14:15:27 +01:00
Vito Tumas
31180f94c2
fix: Prevents overwriting a bool value in an invariant ( #6609 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-30 13:05:09 +00:00
Pratik Mankawde
ca48805b3b
more cleanup
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-04-30 13:14:57 +01:00
Pratik Mankawde
a44385f739
more cleanup
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-04-30 12:26:32 +01:00
Pratik Mankawde
1f07ecb36e
Merge remote-tracking branch 'origin/develop' into pratik/Retire_fixUniversalNumber_amendment
2026-04-30 12:23:45 +01:00
Pratik Mankawde
e57bbcd618
added using-namespace back
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-04-30 12:22:53 +01:00
Pratik Mankawde
17f749b3e7
cleared more ref. to deleted functions
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-04-30 12:15:41 +01:00
Pratik Mankawde
1ebb5e1c7d
Merge branch 'develop' into pratik/Retire_fixUniversalNumber_amendment
2026-04-30 11:33:07 +01:00
Pratik Mankawde
84cc292217
removed call to getSTNumberSwitchover
2026-04-30 11:26:03 +01:00
Bart
4d0ea8ae36
refactor: Apply various minor improvements and corrections ( #7045 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-30 10:22:11 +00:00
Zhiyuan Wang
dbd646bd53
fix: Store Delegate object in delegating and authorized account directories for proper deletion ( #6681 )
2026-04-29 18:17:01 +00:00
Mayukha Vadari
7be98d95de
fix: Make assorted RPC fixes ( #6529 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-29 18:05:34 +00:00
Alex Kremer
f7275b7ad9
chore: Enable clang-tidy v21 new checks ( #7031 )
2026-04-29 15:17:35 +00:00
Jingchen
46b997b774
feat: Create new transaction testing framework TxTest ( #6537 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com >
2026-04-28 14:16:10 +00:00
Pratik Mankawde
3547112540
fix: Fix ubsan flagged issues ( #6151 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-27 20:34:16 +00:00
Alex Kremer
4dc923dcc5
chore: Enable clang-tidy modernize-use-nodiscard check ( #7015 )
2026-04-24 17:19:30 +00:00
Zhiyuan Wang
a6bd9251d2
docs: Update hybrid offer invariant comment ( #7007 )
2026-04-24 16:35:10 +00:00
Mayukha Vadari
9ae29612ea
fix: Fix flaky CI tests ( #7005 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-24 13:23:43 +00:00
Mayukha Vadari
7cfa5d4610
fix: Make assorted Payments fixes ( #6585 )
2026-04-24 12:56:50 +00:00
Pratik Mankawde
d081598378
code review changes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-04-24 13:19:34 +01:00
Pratik Mankawde
73aea396c6
Merge branch 'develop' into pratik/Retire_fixUniversalNumber_amendment
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-04-24 13:08:48 +01:00
Mayukha Vadari
248cb29681
refactor: Move LendingHelpers into libxrpl/ledger/helpers ( #6638 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-24 12:06:26 +00:00
Jingchen
7a449edebb
refactor: Clean up NetworkOPs ( #6575 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
2026-04-23 17:59:49 +00:00
Alex Kremer
19da25812b
fix: Remaining clang-tidy unchecked optionals ( #6979 )
2026-04-23 16:21:01 +00:00
Jingchen
7cd503859e
refactor: Remove seq from TMGetObjectByHash ( #6976 )
2026-04-23 13:59:23 +00:00
pdp2121
bd1b126230
feat: Add --definitions flag and artifact ( #6858 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-22 20:10:52 +00:00
Mayukha Vadari
1c6cdc653c
fix: More clang-tidy issues ( #6992 )
2026-04-22 17:42:15 +00:00
Vito Tumas
2e307329f0
refactor: Add transaction-specific invariant checking ( #6551 )
2026-04-22 14:41:19 +00:00
Jingchen
45d4aacb53
chore: Remove empty Taker.h ( #6984 )
2026-04-21 18:15:58 +00:00
Alex Kremer
ce3951bbb3
chore: Enable clang-tidy modernize checks ( #6975 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-21 15:32:51 +00:00
Alex Kremer
ea023121f5
fix: Add rounding to Vault invariants ( #6217 ) ( #6955 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-21 12:14:07 +00:00
yinyiqian1
4b198cd5bb
fix: Disallow MPTClearRequireAuth if is set ( #6712 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-20 21:25:52 +00:00
Alex Kremer
726f20c8f6
feat: Add GRPC TLS support ( #6374 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-20 17:12:14 +00:00
Zhiyuan Wang
96643bb0fa
fix: Check for empty sfAdditionalBooks array in hybrid offer invariant ( #6716 )
2026-04-20 17:10:28 +00:00
chuanshanjida
e83818241a
chore: Remove repetitive word in multiple files ( #6978 )
...
Signed-off-by: chuanshanjida <chuanshanjida@outlook.com >
2026-04-20 16:56:03 +00:00
Alex Kremer
653a383ff5
chore: Enable clang-tidy include cleaner ( #6947 )
2026-04-17 16:43:49 +00:00
Gregory Tsipenyuk
affe5835fe
fix: Change AMMClawback return code to tecNO_PERMISSION ( #6946 )
2026-04-17 14:19:58 +00:00
Alex Kremer
f1a5ba43ad
chore: Enable clang-tidy readability checks ( #6930 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-17 13:30:52 +00:00
Jingchen
4a73be499d
fix: Fix unity build for book step ( #6942 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-16 17:12:00 +00:00
Sergey Kuznetsov
d52d735543
chore: Move codegen venv setup into build stage ( #6617 )
...
Co-authored-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-15 18:50:49 +00:00