Ed Hennis
6f1f53a152
Add a 1/4s delay so the server doesn't restore the removed ledger
...
- Delay before removing the ledger index so the server can get all its
record keeping done before I mess with it.
2026-08-21 14:25:01 -04:00
Ed Hennis
2620ae59ae
Reapply "experiment: find where the deleted ledger is being put back"
...
- It's Schrodinger's ledger index. Not checking that it's removed allows
it to be put back.
This reverts commit 77793df659 .
2026-08-21 12:13:59 -04:00
Ed Hennis
77793df659
Revert "experiment: find where the deleted ledger is being put back"
...
This reverts commit e67e9f6660 .
2026-08-21 11:36:56 -04:00
Ed Hennis
6abcc9fe1a
Merge remote-tracking branch 'XRPLF/develop' into ximinez/online-delete-gaps
...
* XRPLF/develop:
fix: Reject vault deposits that move nothing from the depositor (8014)
perf: Speed up addition time for drastically different exponents (7825)
refactor: Collapse transactions.macro settings into a TxSettings struct (8001)
2026-08-21 11:35:50 -04:00
Timur Yalymov
046d4dd4af
fix: Reject vault deposits that move nothing from the depositor ( #8014 )
...
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-21 12:30:17 +00:00
Ed Hennis
e67e9f6660
experiment: find where the deleted ledger is being put back
2026-08-20 22:48:39 -04:00
Ed Hennis
6718b3276b
clang-tidy: Use switch. Duh
2026-08-20 21:29:34 -04:00
Ed Hennis
642dbad885
Fix timing issues in the gap test
...
- The coverage build exposed that the timing was more sensitive than
I had thought. Force things to run in the order I expect by changing
the server mode (via NetworkOPs::setMode).
2026-08-20 21:07:10 -04:00
Ed Hennis
d27beef500
perf: Speed up addition time for drastically different exponents ( #7825 )
2026-08-20 19:40:42 +00:00
Ed Hennis
833433b25e
Merge branch 'develop' into ximinez/online-delete-gaps
2026-08-20 15:39:42 -04:00
Mayukha Vadari
85512541ad
refactor: Collapse transactions.macro settings into a TxSettings struct ( #8001 )
...
Co-authored-by: Timur Yalymov <36795566+tyalymov@users.noreply.github.com >
Co-authored-by: Cursor <cursoragent@cursor.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-08-20 19:25:27 +00:00
Gregory Tsipenyuk
3ab5288ef2
fix: Enforce MPT balance invariants under the latest cleanup amendment ( #7889 )
2026-08-20 19:05:28 +00:00
Kassaking7
d0dbf9163c
fix: Prevent AMM auction slots from being acquired at zero cost when trading fee is zero ( #7430 )
2026-08-20 19:04:04 +00:00
Ayaz Salikhov
a1478fac39
docs: Fix yum installation baseurl ( #8066 )
2026-08-20 16:28:43 +00:00
Timur Yalymov
cc76708563
fix: Return specific and consistent errors from vault_info ( #8015 )
...
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-20 16:05:18 +00:00
Sergey Kuznetsov
422e5245e4
ci: Save cargo cache only from develop by default ( #8063 )
2026-08-20 16:02:26 +00:00
Shawn Xie
e3ba569187
fix: Check credential for LoanBrokerCoverWithdraw and VaultWithdraw ( #7107 )
...
Co-authored-by: Peter Chen <ychen@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-08-20 15:33:46 +00:00
Jingchen
959a186a0f
build: Suppress MSVC linker warning LNK4099 ( #8049 )
2026-08-20 13:19:07 +00:00
dependabot[bot]
3b1c9e4320
chore: [DEPENDABOT] Bump cxx from 1.0.198 to 1.0.199 in /crates in the rust-dependencies group across 1 directory ( #8050 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-08-20 13:12:14 +00:00
Ayaz Salikhov
a3a2c85c41
build: Use debian any distribution & signed (hosted) rpm repo ( #8053 )
2026-08-20 13:05:18 +00:00
Ayaz Salikhov
b1ac891210
ci: Do not cache cargo binaries ( #8062 )
2026-08-20 11:47:27 +00:00
Ed Hennis
23369e114a
clang-tidy: exclude 2 rules from rotation functionality
...
- readability-else-after-return
- readability-braces-around-statements
2026-08-19 18:08:01 -04:00
Ed Hennis
d3d0c6366a
Minor fixes from AI code review
2026-08-19 17:35:53 -04:00
Ed Hennis
af61140cd9
Merge branch 'develop' into ximinez/online-delete-gaps
2026-08-19 12:57:51 -04:00
Ed Hennis
4e1de43939
clang-tidy: Make changes uglier by adding a bunch of redundant {}s
2026-08-19 11:42:59 -04:00
Ayaz Salikhov
da57183e0c
build: Compress the RPM payload with zstd ( #8047 )
2026-08-19 15:05:04 +00:00
Sergey Kuznetsov
f370289733
chore: Rust-C++ cmake and CI integration ( #7034 )
2026-08-19 14:30:06 +00:00
Vito Tumas
d1dc7a6ccf
refactor: Extract invariant invocation into free checkInvariants runner ( #7404 )
...
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-19 14:10:11 +00:00
Ayaz Salikhov
5639863715
docs: Rewrite the install guide ( #8048 )
2026-08-19 14:02:42 +00:00
Ayaz Salikhov
1be4868875
build: Sign RPM packages ( #8046 )
2026-08-19 13:46:11 +00:00
Timur Yalymov
368ff1afce
fix: Exempt loan default from asset freeze ( #7932 )
...
Co-authored-by: Cursor <cursoragent@cursor.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-08-19 13:43:40 +00:00
Vito Tumas
3adf2d40b5
fix: Reject VaultWithdraw fixed-share amounts that round to zero ( #7950 )
2026-08-19 13:09:38 +00:00
Ed Hennis
e372201499
Merge branch 'develop' into ximinez/online-delete-gaps
2026-08-18 21:27:07 -04:00
Ed Hennis
8b2a7f6253
More review feedback from @vlntb: log warnings after a delay
...
- Log the "waiting" messages at warning level once the delay reaches 1/4
of the way to the circuit breaker cutoff.
- Also fix the exception message on configuration validation.
2026-08-18 21:15:52 -04:00
Ed Hennis
6211dbd1cc
Review feedback from @vlntb: Circuit breaker
...
- Adds a "max_waiting_ledgers" config, which defaults to the
"online_delete" value. If the rotation gets stuck for that number of
ledgers, abort the rotation and try again later. The existing gap will
be ignored on the next rotation.
- Create a new HealthResult::Expired. Update most healthWait() call
sites to account for the new possible result. Pay special note to the
calls in SHAMapStoreImp::run() to ensure they don't exit the thread
prematurely, or keep rotating when they should not.
- Did a little clean up while I was in there.
- Update tests.
2026-08-18 20:46:06 -04:00
Ayaz Salikhov
a6983f8bf3
build: Use AlmaLinux for the RHEL packaging image ( #8045 )
2026-08-19 00:25:46 +00:00
Ayaz Salikhov
4113b105a5
build: Run nix macos builds in CI; deny nix store references ( #8023 )
2026-08-18 23:34:16 +00:00
Olek
7442ff2dec
fix: Enable reserve checking on ending sponsorship ( #8044 )
2026-08-18 22:39:32 +00:00
Kassaking7
666e77b22c
fix: Add ValidPermissionedDEX invariant track for fully consumed offer ( #6736 )
2026-08-18 21:08:02 +00:00
Ed Hennis
d89063acae
AI review feedback: validate config, improve healthWait()
...
- Check that recovery_wait_time is non-zero.
- In healthWait(), explicitly check whether the only missing ledger is
the current validated ledger, in the process of being built. If so,
log lower, and only wait 1/10 of the time.
- Add the special case from #7793 that will let rotation run if the node
is disconnected.
2026-08-18 15:48:34 -04:00
Vito Tumas
8c12de6c56
test: Split Vault_test into topical suites under src/test/app/vault/ ( #8041 )
2026-08-18 17:57:12 +00:00
Shawn Xie
b21fd86f6e
fix: Fix assorted NFT and pDEX bugs ( #7749 )
2026-08-18 17:56:33 +00:00
Ayaz Salikhov
f5f47f1cf5
chore: Publish debian/rpm packages from GitHub directly ( #8031 )
2026-08-18 15:03:45 +00:00
Bart
ca39bff3c8
refactor: Add SHAMapNodeID::isPrefixOf ( #7939 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-08-18 12:35:32 +00:00
Vito Tumas
dd0edc19a0
fix: Conserve funds correctly when LoanPay fee payee is below reserve ( #7843 )
2026-08-18 11:09:33 +00:00
Ed Hennis
7d55bb7d8e
Merge branch 'develop' into ximinez/online-delete-gaps
2026-08-17 22:36:49 -04:00
Copilot
820ca5b332
refactor: Convert boost::beast::string_view to std::string_view ( #6306 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: Timur Yalymov <36795566+tyalymov@users.noreply.github.com >
Co-authored-by: Cursor <cursoragent@cursor.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-08-17 23:19:56 +00:00
Gregory Tsipenyuk
1b226c8b2e
perf: Optimize MPT freeze checks to reduce redundant state reads ( #7411 )
...
Co-authored-by: Chenna Keshava B S <21219765+ckeshava@users.noreply.github.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-17 21:15:16 +00:00
Gregory Tsipenyuk
ca6121c5b3
feat: Enforce MPT CanTransfer on AMM LPTokens transfers ( #7418 )
2026-08-17 20:58:46 +00:00
Gregory Tsipenyuk
c49789086a
fix: Extend locked-MPToken unauthorize check to fixCleanup3_4_0 ( #8004 )
2026-08-17 12:52:20 +00:00