Ed Hennis
5e860ec749
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-shortages
2025-11-15 03:13:07 -05:00
Ed Hennis
cfdcaf3f8d
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-15 03:08:29 -05:00
Ayaz Salikhov
13a12c6402
chore: Update nudb recipe to remove linker warnings ( #6038 )
2025-11-14 20:27:28 +00:00
Ed Hennis
b9fdf9e564
Add the testPoC_UnsignedUnderflowOnFullPayAfterEarlyPeriodic
...
- Updated to reflect that the issue in RIPD-3971 has been resolved by
commit 4396b77c4b
2025-11-14 12:52:27 -05:00
Bronek Kozicki
362ecbd1cb
fix: Apply object reserve for Vault pseudo-account ( #5954 )
2025-11-14 17:30:56 +00:00
Jingchen
7025e92080
refactor: Retire TicketBatch amendment ( #6032 )
...
Amendments activated for more than 2 years can be retired. This change retires the TicketBatch amendment.
2025-11-14 13:33:34 +00:00
Ed Hennis
4719e05d89
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-shortages
2025-11-13 14:46:25 -05:00
Ed Hennis
c65a311ad1
Remove a bunch of obsolete code, marked by "#if LOANCOMPLETE"
2025-11-13 14:26:47 -05:00
Ed Hennis
a868b1938d
Fix Vault test failure due to default field not being in RPC Json
2025-11-13 14:21:41 -05:00
Ed Hennis
c8394eb52f
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-shortages
2025-11-13 12:21:27 -05:00
Ed Hennis
2f94838bbf
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-13 12:18:42 -05:00
Ed Hennis
1c1cd1a391
Change Vault asset fields back to default
...
- Was unintentionally rolled back with `Number` changes.
2025-11-13 12:15:39 -05:00
Vlad
f81d0d8c98
chore: Clean up incorrect comments ( #6031 )
...
This change cleans up incorrect comments that were left in test cases after one of the amendments was retired.
2025-11-13 13:37:38 +00:00
Jingchen
508937f3d1
refactor: Retire MultiSignReserve and ExpandedSignerList amendments ( #5981 )
...
Amendments activated for more than 2 years can be retired. This change retires the MultiSignReserve and ExpandedSignerList amendments.
2025-11-13 11:42:45 +00:00
Ed Hennis
5a3df22cea
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-shortages
2025-11-13 01:53:46 -05:00
Ed Hennis
ad124ce7b2
Fix balance checking assertion in LoanPay when issuer is borrower
...
- Resolves RIPD-4096
2025-11-13 01:51:07 -05:00
Ed Hennis
b44859ff15
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-shortages
2025-11-12 20:12:43 -05:00
Ed Hennis
a4aa72eada
Fix revert issues
2025-11-12 19:19:06 -05:00
Ed Hennis
398170ef3d
Revert "Add optional enforcement of valid integer range to Number"
...
This reverts commit 3cb447a4fe .
2025-11-12 19:15:14 -05:00
Ed Hennis
9b0b7b5a91
Revert "Make all STNumber fields "soeDEFAULT""
...
This reverts commit 24f37d73f6 .
2025-11-12 19:15:07 -05:00
Ed Hennis
1b4e18a1a7
Revert "Add integer enforcement when converting to XRP/MPTAmount to Number"
...
This reverts commit b605a2cdcc .
2025-11-12 19:15:06 -05:00
Ed Hennis
814577758f
Revert "Fix build error - avoid copy"
...
This reverts commit cb6df196dc .
2025-11-12 19:15:03 -05:00
Ed Hennis
694abd1c79
Revert "Catch up the consequences of Number changes"
...
This reverts commit 0175dd70db .
2025-11-12 19:15:00 -05:00
Ed Hennis
2e34506835
Revert "Add a distinction between a "valid" and a "representable" Number"
...
This reverts commit 8e56af20ee .
2025-11-12 19:14:54 -05:00
Ed Hennis
b7ed35cb04
Fix merge issue: references to retired features
2025-11-12 16:34:41 -05:00
Ed Hennis
fe8d931992
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-shortages
2025-11-12 14:17:31 -05:00
Ed Hennis
8f772b9073
Merge remote-tracking branch 'XRPLF/develop' into ximinez/lending-XLS-66
...
* XRPLF/develop:
chore: Set version 3.1.0-b0 (5986)
ci: Clean workspace on Windows self-hosted runners (6024)
docs: fix spelling in comments (6002)
fix: floating point representation errors in vault (5997)
ci: Specify bash as the default shell in workflows (6021)
refactor: Add `XRPL_RETIRE_FIX` and `XRPL_RETIRE_FEATURE` macros (6014)
refactor: Retire DepositPreAuth and DepositAuth amendments (5978)
chore: Move running of unit tests out of coverage target (6018)
refactor: Retire PayChanRecipientOwnerDir amendment (5946)
2025-11-12 14:12:01 -05:00
Bronek Kozicki
8580a5795a
chore: Set version 3.1.0-b0 ( #5986 )
...
Technically b0 is not a release, so no "release" prefix here. It marks the point at which we moved the preceding release (3.0.0 in this case) from Beta to Release Candidate.
3.1.0-b0
2025-11-12 18:55:49 +00:00
Ed Hennis
ef66a1cc0e
Disable inner Batch transactions for Vault and Loan types
2025-11-12 13:51:57 -05:00
Bart
9b53bd9871
ci: Clean workspace on Windows self-hosted runners ( #6024 )
...
This change updates the `cleanup-workspace` action to its latest version, which added support for Windows.
2025-11-12 09:30:45 -05:00
hustrust
5fc07e3979
docs: fix spelling in comments ( #6002 )
2025-11-12 08:23:45 -05:00
Bronek Kozicki
2ebc2ca885
fix: floating point representation errors in vault ( #5997 )
...
This change fixes floating point errors in conversion of shares to assets and other way, used in `VaultDeposit`, `VaultWithdraw` and `VaultClawback`. In the floating point calculations the division introduces a larger error than multiplication. If we do division first, then the error introduced will be increased by the multiplication that follows, which is therefore the wrong order to perform these two operations. This change flips the order of arithmetic operations, which minimizes the error.
2025-11-11 19:39:09 +00:00
Ayaz Salikhov
c2a90b706f
ci: Specify bash as the default shell in workflows ( #6021 )
2025-11-11 18:17:03 +00:00
Jingchen
9ffb434315
refactor: Add XRPL_RETIRE_FIX and XRPL_RETIRE_FEATURE macros ( #6014 )
...
Rather than having a single `XRPL_RETIRE` macro that applies to both feature and fix amendments, this change replaces it by new `XRPL_RETIRE_FIX` and `XRPL_RETIRE_FEATURE` macros that avoids confusion between whether to prefix the amendment name with `feature` or `fix`.
2025-11-11 12:45:13 -05:00
Ed Hennis
6c375f1346
Convert sfNextPaymentDueDate from optional to default
...
- Simplifies some of the updates and checks
2025-11-11 12:02:58 -05:00
Jingchen
ff18cfef96
refactor: Retire DepositPreAuth and DepositAuth amendments ( #5978 )
...
Amendments activated for more than 2 years can be retired. This change retires the fDepositPreAuth and DepositAuth amendments.
2025-11-11 15:21:07 +00:00
Bronek Kozicki
03704f712b
chore: Move running of unit tests out of coverage target ( #6018 )
...
This change makes the progress of unit tests visible and also gives more flexibility when running them.
2025-11-11 14:55:16 +00:00
Pratik Mankawde
9b332d88c1
refactor: Retire PayChanRecipientOwnerDir amendment ( #5946 )
...
Amendments activated for more than 2 years can be retired. This change retires the PayChanRecipientOwnerDir amendment.
2025-11-11 09:07:45 -05:00
Ed Hennis
21eb13de0c
Reorder payment options to do full early payment first
...
- Since all the special cases are now specified with flags, the order is
less important.
- Avoids computing the periodic payment parts that are not needed for
full payment computation.
- A late payment without the late payment flag will override everything
else, though.
2025-11-10 23:28:25 -05:00
Ed Hennis
4396b77c4b
Add tfLoanLatePayment flag; full payment is no longer a special case
...
- A regular payment that is late, or a tfLoanLatePayment that is not
late will fail.
- Flags are mutually exclusive.
- Add a few interest computation shortcuts and overflow prevention
checks that return 0 if there's no time to compute for.
2025-11-10 23:17:42 -05:00
Ed Hennis
8d22409ab5
review feedback: Use the specific type in the "SendMulti" functions
2025-11-10 21:20:42 -05:00
Ed Hennis
1c99243ec2
Fix service fee accounting when a borrower is the broker ( #6016 )
...
- Add unit-test to verify the fix.
2025-11-10 21:10:13 -05:00
Ed Hennis
7712cbdfcc
Fix build issue - unused variable
2025-11-10 21:02:01 -05:00
Ed Hennis
0008e2d1db
Revert "Partially revert aed8e2b166 Fill in payment computation shortages ( #5941 )"
...
This reverts commit 95fdbe520f .
2025-11-10 19:54:56 -05:00
Ed Hennis
060b6d3231
Revert "Remove the shortage code completely"
...
This reverts commit 165478b929 .
2025-11-10 19:54:56 -05:00
Ed Hennis
abb05cc684
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-10 19:52:54 -05:00
Ed Hennis
2f064893bb
test: Add a test case reproducing the issue in RIPD-3902
2025-11-10 19:50:15 -05:00
Ed Hennis
6ad4b29878
Always round cover minimum calculations up
...
- Addresses RIPD-4016.
- Add and update testRoundingAllowsUndercoverage() unit test from ticket.
2025-11-10 17:59:10 -05:00
Ayaz Salikhov
33309480d4
ci: Update Conan to 2.22.2 ( #6019 )
...
This updates the CI image hashes after following change: https://github.com/XRPLF/ci/pull/81 . And, since we use latest Conan, we can have `conan.lock` with a newline at the end, and we don't need to exclude it from `pre-commit` hooks any longer.
2025-11-10 16:23:40 -05:00
Ed Hennis
73a857e69e
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-10 15:35:09 -05:00