Ed Hennis
5abecb9fcb
Significant rewrite
...
- Simplify Number::operator/= to use more constexpr values, and fewer
variations.
- Most significantly, rounding up doesn't need more precision, it only
needs to know if there's a remainder after the current precision work
is done. Tracked similarly Guard::xbit_.
- Build a constexpr lookup array for powers of 10. Only a handful of
values are used, but since it's built at compile time, and constexpr,
unused values do not affect memory or performance.
2026-05-27 00:07:48 -04:00
Ed Hennis
e851e80de0
Merge branch 'ximinez/number-fix-maxrepcusp' into ximinez/number-division-accuracy
2026-05-26 16:56:47 -04:00
Ed Hennis
a963035f76
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-26 16:56:43 -04:00
Ed Hennis
8ab904de57
Merge branch 'ximinez/number-fix-maxrepcusp' into ximinez/number-division-accuracy
2026-05-26 16:01:44 -04:00
Ed Hennis
100ec464d9
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-26 16:01:40 -04:00
Ed Hennis
e89e6f50e8
Merge remote-tracking branch 'XRPLF/ximinez/number-fix-maxrepcusp' into ximinez/number-division-accuracy
...
* XRPLF/ximinez/number-fix-maxrepcusp:
clang-tidy: implicit bool conversion
Address some AI review feedback: predeclare, include, format, comment
fix: Fix `VaultInvariant` and `VaultDeposit` precision bugs at IOU scale boundaries (7272)
ci: Add clang to nix images (7308)
fix: Include management-fee delta in doOverpayment assertion (7039)
fix: Fix clang-tidy pre-commit hook to locate compile_commands.json from repo root (7325)
fix: Use consistent scale for `debtTotal` (7093)
fix: Skip deleted book directories and non-root modifications in `ValidBookDirectory` invariant (7312)
fix: Address review feedback on FD/handle guarding (5823 follow-up) (7310)
fix: Fix non-canonical MPT amount (7117)
2026-05-26 15:53:36 -04:00
Ed Hennis
27456fa439
Use the local range instead of calling a function
2026-05-26 15:52:25 -04:00
Ed Hennis
d6844311c0
clang-tidy: missing header
2026-05-26 15:48:29 -04:00
Andrzej Budzanowski
85af406a0f
fix: Update clang-tidy to include src/tests directory header check ( #7307 )
2026-05-26 19:35:32 +00:00
Ed Hennis
fbee0349f5
clang-tidy: implicit bool conversion
2026-05-26 15:21:42 -04:00
Vito Tumas
49567e7283
fix: Fix edge-case where vault-depositor may get stuck ( #7139 )
2026-05-26 18:18:40 +00:00
Ed Hennis
84ca271d95
Address some AI review feedback: predeclare, include, format, comment
...
- Predeclare type reference in Rules.h
- Remove an unneeded include in EscrowToken_test
- Number_test will format negative BigInts correctly (unused)
- Remove an inaccurate comment
2026-05-26 13:51:06 -04:00
Ed Hennis
75dfc65f5f
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-26 13:47:33 -04:00
Vito Tumas
633ef4706f
fix: Fix VaultInvariant and VaultDeposit precision bugs at IOU scale boundaries ( #7272 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-26 16:32:44 +00:00
Vito Tumas
22a21b175e
fix: Include management-fee delta in doOverpayment assertion ( #7039 )
2026-05-26 14:01:52 +00:00
Jingchen
a911f9089e
fix: Use consistent scale for debtTotal ( #7093 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-24 20:44:29 +00:00
Peter Chen
e34c2667d7
fix: Skip deleted book directories and non-root modifications in ValidBookDirectory invariant ( #7312 )
2026-05-24 20:37:16 +00:00
Ed Hennis
48b1716e6f
Make Number::operator/= significantly more accurate
...
- Prevents extreme dust rounding from getting lost, especially when
rounding away from zero. (Upward for positive, downward for negative.)
2026-05-23 19:02:03 +01:00
Gregory Tsipenyuk
dcd2ff0b5f
fix: Fix non-canonical MPT amount ( #7117 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-23 06:40:26 +00:00
Ed Hennis
4ab886bcbc
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-22 17:56:15 -04:00
Bart
dfb9b8ed9a
release: Bump version to 3.2.0-b7 ( #7316 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-22 19:32:12 +00:00
Jingchen
179e73594a
fix: Check if the MPT first loss cover can be sent to the broker before deleting the broker ( #7125 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-05-22 11:58:48 +00:00
Gregory Tsipenyuk
3547a9335f
fix: Add assorted MPT/DEX fixes ( #7040 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-05-21 18:29:53 +00:00
Ed Hennis
7f64c337d8
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-21 14:25:50 -04:00
Bart
1a98182e23
refactor: Remove dead fetchBatch code ( #7309 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-21 17:52:41 +00:00
Bart
79308705c5
release: Bump version to 3.2.0-b6 ( #7311 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-21 17:50:59 +00:00
Vito Tumas
e24de65f42
chore: Revert graceful peer disconnection and follow-up fix ( #7296 )
2026-05-21 16:13:41 +00:00
Vito Tumas
7fdaa0a5ef
fix: Fix IOU precision issues in LoanBrokerCover transactions ( #7274 )
2026-05-21 14:51:58 +00:00
Vito Tumas
795dc5e364
fix: Avoid principal-zeroing in non-final loan payments at coarse scale ( #7050 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-05-21 14:46:26 +00:00
Ed Hennis
61bdd6fb78
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-21 10:10:00 -04:00
Pratik Mankawde
f6fd5ddb0a
fix: Add null check ( #7305 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-05-21 13:24:04 +00:00
Ed Hennis
8e06e78f11
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-21 07:11:49 -04:00
Ed Hennis
42fda85fbc
Fix more AMM tests, and to not exclude fixCleanup3_2_0
2026-05-21 12:04:29 +01:00
Shawn Xie
28cc20c816
fix: Fix wrong hybrid offer orderbook placement and update LedgerStateFix to amend ExchangeRate meta ( #7087 )
...
Co-authored-by: Peter Chen <ychen@ripple.com >
2026-05-21 06:19:04 +00:00
Ed Hennis
3a4b92b050
Change the priority of the amendments for large mantissas
...
- Order the checks so that large mantissa is only enabled if SAV or LP
are enabled. fixCleanup3_2_0 only enables the rounding fix.
- Fix tests, and don't exclude fixCleanup3_2_0 in AMM tests
- Also fix formatting
2026-05-21 00:53:07 +01:00
Ed Hennis
8b56749ca3
Apply suggestions from Copilot code review
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-20 18:39:46 -04:00
Ed Hennis
71cf996fc6
Review feedback from @tapanito: lambda checks condition in doRoundUp
2026-05-20 23:28:26 +01:00
Alex Kremer
a830ab10ef
style: More clang-tidy identifier renaming ( #7290 )
2026-05-20 21:31:15 +00:00
Shawn Xie
8c0080020f
fix: Update pDEX invariant firing under a valid offer deletion ( #7118 )
...
Co-authored-by: Peter Chen <ychen@ripple.com >
2026-05-20 21:10:04 +00:00
yinyiqian1
9cb0740673
fix: Fix multisign and signfor to check for delegate ( #7064 )
2026-05-20 20:24:09 +00:00
Mayukha Vadari
242ce3e9e4
refactor: Fix sfGeneric and sfInvalid field names ( #7300 )
2026-05-20 19:47:59 +00:00
box4wangjing
a5d238e7d4
docs: Fix some comments to improve readability ( #7122 )
...
Signed-off-by: box4wangjing <box4wangjing@outlook.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2026-05-20 19:46:45 +00:00
Vito Tumas
9cb049276d
feat: Propagate underlying MPT flags to vault shares ( #7077 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: Denis Angell <dangell@transia.co >
Co-authored-by: Fomo <508629+shortthefomo@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-20 19:44:09 +00:00
Ed Hennis
4c7ea64b6c
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-19 16:53:33 -04:00
Vito Tumas
93ac1aa7aa
fix: Disable unnecessary sanity-check in VaultDeposit ( #7288 )
2026-05-19 16:38:50 +00:00
Ed Hennis
09ae5b719f
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-19 05:15:47 -04:00
Denis Angell
ad3d172a1f
fix: Use account ledger entry when canceling token escrows ( #6171 )
2026-05-18 20:08:48 +00:00
Mayukha Vadari
ad7232cbc5
refactor: Rename account_ to accountID_ ( #7284 )
2026-05-18 10:56:54 +00:00
Michael Legleux
93836f22db
ci: Add Linux package builds (DEB + RPM) to CI ( #6639 )
2026-05-16 05:08:37 +00:00
Ed Hennis
09f2d06dd4
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-15 21:32:09 -04:00