Fix more AMM tests, and to not exclude fixCleanup3_2_0

This commit is contained in:
Ed Hennis
2026-05-21 12:02:42 +01:00
parent 3a4b92b050
commit 42fda85fbc
4 changed files with 4 additions and 8 deletions

View File

@@ -404,7 +404,6 @@ Number::Guard::doRoundUp(
safeToIncrement(mantissa),
"xrpl::Number::Guard::doRoundUp",
"can't recurse more than once");
// Here be dragons
doRoundUp(
negative,
mantissa,

View File

@@ -21,8 +21,7 @@ struct TestAMMArg
std::vector<FeatureBitset> features = {
// For now, just disable SAV entirely, which locks in the small Number
// mantissas
jtx::testableAmendments() - featureSingleAssetVault - featureLendingProtocol -
fixCleanup3_2_0};
jtx::testableAmendments() - featureSingleAssetVault - featureLendingProtocol};
bool noLog = false;
};
@@ -88,8 +87,7 @@ public:
{
// For now, just disable SAV entirely, which locks in the small Number
// mantissas
return jtx::testableAmendments() - featureSingleAssetVault - featureLendingProtocol -
fixCleanup3_2_0;
return jtx::testableAmendments() - featureSingleAssetVault - featureLendingProtocol;
}
protected:

View File

@@ -143,7 +143,7 @@ AMMTestBase::testAMM(std::function<void(jtx::AMM&, jtx::Env&)> const& cb, TestAM
// mantissas
Env env{
*this,
features - featureSingleAssetVault - featureLendingProtocol - fixCleanup3_2_0,
features - featureSingleAssetVault - featureLendingProtocol,
arg.noLog ? std::make_unique<CaptureLogs>(&logs) : nullptr};
auto const [asset1, asset2] = arg.pool ? *arg.pool : std::make_pair(XRP(10000), USD(10000));

View File

@@ -175,8 +175,7 @@ public:
// or time threshold
{
auto const all = testableAmendments();
for (auto const& feats :
{all - featureSingleAssetVault - featureLendingProtocol - fixCleanup3_2_0, all})
for (auto const& feats : {all - featureSingleAssetVault - featureLendingProtocol, all})
{
for (auto const mantissaSize : MantissaRange::getAllScales())
{