Pratik Mankawde
58b248d9a4
pass lld flag to cmake
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-14 11:23:59 +00:00
Pratik Mankawde
f1561c5b48
use lld
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-14 10:57:11 +00:00
Pratik Mankawde
73ab466029
use gold+large
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-14 10:25:39 +00:00
Pratik Mankawde
4cf4802971
for tsan only use medium
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-13 16:54:41 +00:00
Pratik Mankawde
8d6d2ec455
trying with bfd
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-13 16:31:41 +00:00
Pratik Mankawde
4248a1fbb6
only set mcmodel=large for gcc
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-13 16:18:34 +00:00
Pratik Mankawde
7edba0a856
trying with mcmodel=large
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-13 16:01:36 +00:00
Pratik Mankawde
b38ef53c44
trying lld.
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-13 15:03:23 +00:00
Pratik Mankawde
baee65bd28
fixing minor spacing issue
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-13 13:01:32 +00:00
Pratik Mankawde
2e53c5ab80
changed linker for gcc
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-13 12:28:48 +00:00
Pratik Mankawde
09a6e46c39
pass sanitizer flags to linker as well
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-12 17:32:39 +00:00
Pratik Mankawde
a93052e765
added -fPIC flag
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-12 16:58:01 +00:00
Pratik Mankawde
1cc00cddd8
trying with " and dyn linking
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-12 16:19:34 +00:00
Pratik Mankawde
5f2a351e3f
reverted mcmodel to medium
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-12 16:08:36 +00:00
Pratik Mankawde
5e89bce8d9
use mcmodel=large
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-12 14:48:10 +00:00
Pratik Mankawde
9b793cd429
linker flag correction
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-12 14:16:58 +00:00
Pratik Mankawde
b650852fa7
static liking for gcc
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-12 14:09:12 +00:00
Pratik Mankawde
1d76de83f6
minor correction
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-12 13:12:01 +00:00
Pratik Mankawde
ea4d062e68
added ubsan file
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-12 12:15:45 +00:00
Pratik Mankawde
dcd0553050
sanitizer builds only for gcc15 and clang20. no linking check for sanitizer builds
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-12 11:46:20 +00:00
Pratik Mankawde
6355eba88e
Merge branch 'develop' into pratik/Add-sanitizers-to-CI-builds
2025-11-12 10:37:48 +00:00
Pratik Mankawde
2e5afa7556
updated asan suppressions file
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-12 10:36:02 +00:00
Bronek Kozicki
2ebc2ca885
fix: floating point representation errors in vault ( #5997 )
...
This change fixes floating point errors in conversion of shares to assets and other way, used in `VaultDeposit`, `VaultWithdraw` and `VaultClawback`. In the floating point calculations the division introduces a larger error than multiplication. If we do division first, then the error introduced will be increased by the multiplication that follows, which is therefore the wrong order to perform these two operations. This change flips the order of arithmetic operations, which minimizes the error.
2025-11-11 19:39:09 +00:00
Pratik Mankawde
7d05090d68
setting variables in run
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 19:21:33 +00:00
Pratik Mankawde
916f00039c
try 8
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 19:15:50 +00:00
Pratik Mankawde
e687ab8653
try 7
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 19:07:22 +00:00
Pratik Mankawde
b182b6abf7
try 6
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 19:02:08 +00:00
Pratik Mankawde
509d388f97
try 6
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:58:21 +00:00
Pratik Mankawde
fd712770e1
try 5
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:53:42 +00:00
Pratik Mankawde
695f4a2cc9
try 4
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:50:04 +00:00
Pratik Mankawde
5ea3b4327d
try 3
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:46:13 +00:00
Pratik Mankawde
a9444d3a42
try 2
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:42:14 +00:00
Pratik Mankawde
20326a785b
putting commented code back
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:39:00 +00:00
Pratik Mankawde
5ef2ced584
testing by printing asan_options
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:38:21 +00:00
Pratik Mankawde
a011d29fcb
trying again with minor change
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:36:51 +00:00
Pratik Mankawde
9abec17536
commenting out windows and mac for now.
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:32:58 +00:00
Pratik Mankawde
2bc089a962
Merge branch 'develop' into pratik/Add-sanitizers-to-CI-builds
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:30:47 +00:00
Pratik Mankawde
14f605b2f9
minor
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:29:52 +00:00
Pratik Mankawde
f2365543fb
added variable in an early action
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:19:04 +00:00
Pratik Mankawde
d9c26bd7a9
another comb.
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 18:17:37 +00:00
Ayaz Salikhov
c2a90b706f
ci: Specify bash as the default shell in workflows ( #6021 )
2025-11-11 18:17:03 +00:00
Pratik Mankawde
937dc8740e
another combi
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 17:53:16 +00:00
Jingchen
9ffb434315
refactor: Add XRPL_RETIRE_FIX and XRPL_RETIRE_FEATURE macros ( #6014 )
...
Rather than having a single `XRPL_RETIRE` macro that applies to both feature and fix amendments, this change replaces it by new `XRPL_RETIRE_FIX` and `XRPL_RETIRE_FEATURE` macros that avoids confusion between whether to prefix the amendment name with `feature` or `fix`.
2025-11-11 12:45:13 -05:00
Pratik Mankawde
9b92aafe6d
fixed path to atsan
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 17:42:23 +00:00
Pratik Mankawde
124b6ca4bd
using GITHUB_WORKSPACE now
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 17:27:51 +00:00
Pratik Mankawde
28885a4638
path revert
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 17:13:45 +00:00
Pratik Mankawde
5478e4fee6
move working_dir up
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 16:57:32 +00:00
Pratik Mankawde
72b3a03538
Merge branch 'develop' into pratik/Add-sanitizers-to-CI-builds
2025-11-11 16:51:12 +00:00
Pratik Mankawde
18b65fd129
linked model flags specific to amd64
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 16:42:57 +00:00
Pratik Mankawde
ebf917ab15
no-var-tracking is gcc specific
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-11 15:33:17 +00:00