Pratik Mankawde
4d6ddb5f1f
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 14:56:09 +01:00
Pratik Mankawde
e7dea147cd
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 18:18:36 +01:00
Pratik Mankawde
8d730b8b9a
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase6-statsd
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 18:16:35 +01:00
Pratik Mankawde
2f96c6547c
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 16:51:31 +01:00
Pratik Mankawde
c187a62353
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 16:47:15 +01:00
Pratik Mankawde
c848e51e13
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 16:44:07 +01:00
Pratik Mankawde
8f9057729c
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 16:14:21 +01:00
Pratik Mankawde
f031befc6e
compilation fixes and levelization fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 16:04:19 +01:00
Pratik Mankawde
3a1f22583f
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 15:34:22 +01:00
Bart
2f3558c610
ci: Run PR title and description checks on staging and release branches ( #7331 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-28 14:57:29 +00:00
Ayaz Salikhov
f9551ac5ca
style: Run shfmt on workflows, actions and markdown bash code ( #7333 )
2026-05-27 19:24:18 +00:00
Ayaz Salikhov
1162371def
ci: Only push docker images in XRPLF/rippled ( #7330 )
2026-05-26 20:03:04 +00:00
dependabot[bot]
2a0feca46b
ci: [DEPENDABOT] bump docker/setup-buildx-action from 4.0.0 to 4.1.0 ( #7322 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-26 19:36:32 +00:00
dependabot[bot]
108a4c8217
ci: [DEPENDABOT] bump codecov/codecov-action from 6.0.0 to 6.0.1 ( #7321 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-26 19:36:21 +00:00
dependabot[bot]
4584b01bde
ci: [DEPENDABOT] bump docker/build-push-action from 7.1.0 to 7.2.0 ( #7320 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-26 19:36:13 +00:00
dependabot[bot]
7c59786565
ci: [DEPENDABOT] bump docker/metadata-action from 6.0.0 to 6.1.0 ( #7319 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-26 19:36:00 +00:00
dependabot[bot]
9623e67b76
ci: [DEPENDABOT] bump docker/login-action from 4.1.0 to 4.2.0 ( #7318 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-26 19:35:52 +00:00
Ayaz Salikhov
23d0812827
style: Use shfmt instead of bashate ( #7326 )
2026-05-26 18:28:23 +00:00
Ayaz Salikhov
49cb3f45a4
ci: Add clang to nix images ( #7308 )
...
Co-authored-by: semgrep-companion-app[bot] <218312740+semgrep-companion-app[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-26 15:45:33 +00:00
Pratik Mankawde
e9d885bd9b
fix: Fix clang-tidy pre-commit hook to locate compile_commands.json from repo root ( #7325 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-26 13:50:18 +00:00
Michael Legleux
a37afe13ff
ci: Re-enable full nproc for Linux ( #7315 )
2026-05-22 11:30:37 +00:00
dependabot[bot]
d9a3af8207
ci: [DEPENDABOT] bump actions/upload-artifact from 7.0.0 to 7.0.1 ( #7286 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-19 16:35:38 +00:00
Ayaz Salikhov
8d1083e5ea
ci: Only run reusable package in public repos ( #7293 )
2026-05-19 13:15:11 +00:00
Michael Legleux
93836f22db
ci: Add Linux package builds (DEB + RPM) to CI ( #6639 )
2026-05-16 05:08:37 +00:00
Alex Kremer
5b6e8b6f93
refactor: Rename static constants ( #7120 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-15 15:32:19 +00:00
Ayaz Salikhov
15b3ed1ae7
ci: Update XRPLF/actions ( #7281 )
2026-05-15 11:21:29 +00:00
Ayaz Salikhov
648ec747f2
feat: Implement nix-based Dockerfile for CI ( #7083 )
2026-05-13 15:10:53 +00:00
Pratik Mankawde
25d2dae798
fix(tests): align MockServiceRegistry overrides with ServiceRegistry interface
...
MockServiceRegistry in MetricsRegistry.cpp still used the old method
names (timeKeeper, cachedSLEs, validators, overlay, cluster, app, etc.)
while ServiceRegistry has been standardized on getXxx()/isXxx() forms.
Windows CI caught this as C3668 "did not override any base class methods"
errors and C2259 "cannot instantiate abstract class".
Rename all 13 mismatched overrides to match the current interface:
timeKeeper -> getTimeKeeper
cachedSLEs -> getCachedSLEs
validators -> getValidators
validatorSites -> getValidatorSites
validatorManifests -> getValidatorManifests
publisherManifests -> getPublisherManifests
overlay -> getOverlay
cluster -> getCluster
peerReservations -> getPeerReservations
pendingSaves -> getPendingSaves
openLedger (x2) -> getOpenLedger
getPathRequests -> getPathRequestManager (type rename too)
journal -> getJournal
logs -> getLogs
trapTxID -> getTrapTxID
app -> getApp
Also regenerate levelization ordering.txt to reflect the new
tests.libxrpl -> xrpl.core edge introduced by ServiceRegistry.h include.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com >
2026-05-13 12:12:59 +01:00
Pratik Mankawde
93a7df6147
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-05-13 11:31:16 +01:00
Pratik Mankawde
c096eeb239
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-05-13 11:30:22 +01:00
Michael Legleux
170eb5e588
ci: Limit nproc on Linux builds temporarily ( #7132 )
2026-05-12 20:46:33 +00:00
Ayaz Salikhov
aa55392453
ci: Make Show test failure summary work with no build dir ( #7124 )
2026-05-12 15:54:04 +00:00
Bronek Kozicki
d67e06102a
chore: Upgrade Clang sanitizer to clang-22 and switch gcc-15 sanitizer to Release ( #7079 )
2026-05-07 10:36:36 +00:00
Ayaz Salikhov
8e2aa33f64
chore: Add IWYU pragma for boost::optional to fix clang-tidy ( #7088 )
2026-05-06 23:31:10 +00:00
Pratik Mankawde
92072ecca4
fix(telemetry): fix CI failures — clang-tidy, levelization, linker
...
Clang-tidy fixes:
- Concatenate nested namespaces (modernize-concat-nested-namespaces)
in OTelCollector.h, OTelCollector.cpp, ValidationTracker.h/.cpp
- Add missing direct includes (misc-include-cleaner) in
ValidationTracker.cpp, test, CollectorManager.cpp, OTelCollector.cpp
- Make lock_guard variables const (misc-const-correctness)
- Add braces around single-line if/else (readability-braces-around-statements)
- Use designated initializer for WindowEvent (modernize-use-designated-initializers)
- Initialize LedgerEvent::seq field (cppcoreguidelines-pro-type-member-init)
Linker fix:
- Add ValidationTracker.cpp as source to xrpl.test.telemetry target
(it lives in src/xrpld/ but the test links against libxrpl only)
Levelization fix:
- Remove stale dependency edges from ordering.txt that were introduced
by the erroneous develop-merge commit
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-06 15:07:25 +01:00
Pratik Mankawde
b62987bda7
Revert "fix: revert all unrelated upstream develop changes from phase-7 PR"
...
This reverts commit f4555c80fe .
2026-05-06 14:13:59 +01:00
Pratik Mankawde
f08412b3e0
ordering update
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-06 13:27:29 +01:00
Ayaz Salikhov
27f7fdb3a6
chore: Do not duplicate sanitizer flags ( #7058 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-05 16:32:43 +00:00
Ayaz Salikhov
6e6fb9cdf3
ci: Run pre-commit on diff in clang-tidy workflow ( #7078 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-05 16:31:46 +00:00
Ayaz Salikhov
e092c52409
ci: Use XRPLF/create-issue ( #7076 )
2026-05-05 13:49:13 +00:00
Ayaz Salikhov
d050073842
ci: Rewrite clang-tidy workflow(s) in a reusable manner ( #7062 )
2026-05-04 12:51:07 +00:00
Alex Kremer
8995564ed6
refactor: Enable clang-tidy readability-identifier-naming check ( #6571 )
2026-05-03 10:31:53 +00:00
Ayaz Salikhov
37b895b678
ci: Rename print-env -> print-build-env ( #7061 )
2026-05-01 09:44:52 +00:00
Pratik Mankawde
40cc7f9ed7
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-04-30 17:00:39 +01:00
Pratik Mankawde
f4555c80fe
fix: revert all unrelated upstream develop changes from phase-7 PR
...
Reverts 259 files that carried unrelated upstream changes through the
phase-6 merge: enum class removals (cppcoreguidelines-use-enum-class),
scoped_lock→lock_guard conversions (modernize-use-scoped-lock),
nodestore Backend API changes (void const* key), .clang-tidy config,
test infrastructure deletions, and miscellaneous develop changes.
These changes belong on develop, not in the telemetry PR chain.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-04-30 16:59:24 +01:00
Pratik Mankawde
f2bc0b18f2
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-04-30 16:45:55 +01:00
Pratik Mankawde
f44b89b99d
fix: revert unrelated develop changes from phase-7 PR
...
- Revert reusable-build-test-config.yml to develop (action SHA update
and "Show test failure summary" step removal don't belong here)
- Revert upload-conan-deps.yml to develop (action SHA update)
- Revert features.macro: BatchInnerSigs and Batch back to Supported::no
(these feature flag changes are unrelated to telemetry)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-04-30 16:45:43 +01:00
Pratik Mankawde
9e12e660fe
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
...
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-04-29 20:25:13 +01:00
Pratik Mankawde
b65f91117f
fix: address CI checks (prettier, docs.sh rename, levelization)
...
- Prettier formatting for markdown docs and OTelCollector header
- docs.sh rippled→xrpld renames in OTelCollector.cpp comments/strings
- Updated levelization ordering with new dependency edges
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-04-29 20:03:22 +01:00
Pratik Mankawde
769668579a
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
...
# Conflicts:
# .codecov.yml
# .github/scripts/levelization/results/ordering.txt
# .github/workflows/reusable-clang-tidy-files.yml
# CMakeLists.txt
# OpenTelemetryPlan/00-tracing-fundamentals.md
# OpenTelemetryPlan/01-architecture-analysis.md
# OpenTelemetryPlan/02-design-decisions.md
# OpenTelemetryPlan/03-implementation-strategy.md
# OpenTelemetryPlan/04-code-samples.md
# OpenTelemetryPlan/05-configuration-reference.md
# OpenTelemetryPlan/06-implementation-phases.md
# OpenTelemetryPlan/07-observability-backends.md
# OpenTelemetryPlan/08-appendix.md
# OpenTelemetryPlan/09-data-collection-reference.md
# OpenTelemetryPlan/OpenTelemetryPlan.md
# OpenTelemetryPlan/POC_taskList.md
# OpenTelemetryPlan/Phase2_taskList.md
# OpenTelemetryPlan/Phase3_taskList.md
# OpenTelemetryPlan/Phase4_taskList.md
# OpenTelemetryPlan/Phase5_IntegrationTest_taskList.md
# OpenTelemetryPlan/Phase5_taskList.md
# OpenTelemetryPlan/presentation.md
# cfg/xrpld-example.cfg
# conan.lock
# conanfile.py
# cspell.config.yaml
# docker/telemetry/TESTING.md
# docker/telemetry/docker-compose.yml
# docker/telemetry/grafana/dashboards/consensus-health.json
# docker/telemetry/grafana/dashboards/transaction-overview.json
# docker/telemetry/grafana/provisioning/dashboards/dashboards.yaml
# docker/telemetry/grafana/provisioning/datasources/tempo.yaml
# docker/telemetry/integration-test.sh
# docker/telemetry/otel-collector-config.yaml
# docker/telemetry/tempo.yaml
# docker/telemetry/xrpld-telemetry.cfg
# docs/build/telemetry.md
# docs/telemetry-runbook.md
# include/xrpl/core/ServiceRegistry.h
# include/xrpl/protocol/detail/features.macro
# include/xrpl/telemetry/SpanGuard.h
# include/xrpl/telemetry/Telemetry.h
# include/xrpl/telemetry/TraceContextPropagator.h
# src/libxrpl/basics/MallocTrim.cpp
# src/libxrpl/nodestore/backend/MemoryFactory.cpp
# src/libxrpl/nodestore/backend/NuDBFactory.cpp
# src/libxrpl/nodestore/backend/RocksDBFactory.cpp
# src/libxrpl/telemetry/NullTelemetry.cpp
# src/libxrpl/telemetry/Telemetry.cpp
# src/libxrpl/telemetry/TelemetryConfig.cpp
# src/tests/libxrpl/basics/MallocTrim.cpp
# src/tests/libxrpl/telemetry/TelemetryConfig.cpp
# src/xrpld/app/consensus/RCLConsensus.cpp
# src/xrpld/app/consensus/RCLConsensus.h
# src/xrpld/app/ledger/detail/BuildLedger.cpp
# src/xrpld/app/ledger/detail/LedgerMaster.cpp
# src/xrpld/app/main/Application.cpp
# src/xrpld/app/misc/NetworkOPs.cpp
# src/xrpld/consensus/Consensus.h
# src/xrpld/overlay/detail/PeerImp.cpp
# src/xrpld/rpc/detail/RPCHandler.cpp
# src/xrpld/rpc/detail/ServerHandler.cpp
2026-04-29 19:50:32 +01:00