fix(tests): align MockServiceRegistry overrides with ServiceRegistry interface

MockServiceRegistry in MetricsRegistry.cpp still used the old method
names (timeKeeper, cachedSLEs, validators, overlay, cluster, app, etc.)
while ServiceRegistry has been standardized on getXxx()/isXxx() forms.
Windows CI caught this as C3668 "did not override any base class methods"
errors and C2259 "cannot instantiate abstract class".

Rename all 13 mismatched overrides to match the current interface:
  timeKeeper          -> getTimeKeeper
  cachedSLEs          -> getCachedSLEs
  validators          -> getValidators
  validatorSites      -> getValidatorSites
  validatorManifests  -> getValidatorManifests
  publisherManifests  -> getPublisherManifests
  overlay             -> getOverlay
  cluster             -> getCluster
  peerReservations    -> getPeerReservations
  pendingSaves        -> getPendingSaves
  openLedger (x2)     -> getOpenLedger
  getPathRequests     -> getPathRequestManager (type rename too)
  journal             -> getJournal
  logs                -> getLogs
  trapTxID            -> getTrapTxID
  app                 -> getApp

Also regenerate levelization ordering.txt to reflect the new
tests.libxrpl -> xrpl.core edge introduced by ServiceRegistry.h include.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Pratik Mankawde
2026-05-13 12:12:59 +01:00
parent 47e83c4e65
commit 25d2dae798
2 changed files with 19 additions and 18 deletions

View File

@@ -191,6 +191,7 @@ test.toplevel > xrpl.json
test.unit_test > xrpl.basics
test.unit_test > xrpl.protocol
tests.libxrpl > xrpl.basics
tests.libxrpl > xrpl.core
tests.libxrpl > xrpld.telemetry
tests.libxrpl > xrpl.json
tests.libxrpl > xrpl.net

View File

@@ -56,7 +56,7 @@ public:
throwUnimplemented();
}
TimeKeeper&
timeKeeper() override
getTimeKeeper() override
{
throwUnimplemented();
}
@@ -71,7 +71,7 @@ public:
throwUnimplemented();
}
CachedSLEs&
cachedSLEs() override
getCachedSLEs() override
{
throwUnimplemented();
}
@@ -106,37 +106,37 @@ public:
throwUnimplemented();
}
ValidatorList&
validators() override
getValidators() override
{
throwUnimplemented();
}
ValidatorSite&
validatorSites() override
getValidatorSites() override
{
throwUnimplemented();
}
ManifestCache&
validatorManifests() override
getValidatorManifests() override
{
throwUnimplemented();
}
ManifestCache&
publisherManifests() override
getPublisherManifests() override
{
throwUnimplemented();
}
Overlay&
overlay() override
getOverlay() override
{
throwUnimplemented();
}
Cluster&
cluster() override
getCluster() override
{
throwUnimplemented();
}
PeerReservationTable&
peerReservations() override
getPeerReservations() override
{
throwUnimplemented();
}
@@ -191,17 +191,17 @@ public:
throwUnimplemented();
}
PendingSaves&
pendingSaves() override
getPendingSaves() override
{
throwUnimplemented();
}
OpenLedger&
openLedger() override
getOpenLedger() override
{
throwUnimplemented();
}
OpenLedger const&
openLedger() const override
getOpenLedger() const override
{
throwUnimplemented();
}
@@ -225,8 +225,8 @@ public:
{
throwUnimplemented();
}
PathRequests&
getPathRequests() override
PathRequestManager&
getPathRequestManager() override
{
throwUnimplemented();
}
@@ -256,7 +256,7 @@ public:
return false;
}
beast::Journal
journal(std::string const&) override
getJournal(std::string const&) override
{
return beast::Journal(beast::Journal::getNullSink());
}
@@ -266,12 +266,12 @@ public:
throwUnimplemented();
}
Logs&
logs() override
getLogs() override
{
throwUnimplemented();
}
std::optional<uint256> const&
trapTxID() const override
getTrapTxID() const override
{
static std::optional<uint256> const empty;
return empty;
@@ -282,7 +282,7 @@ public:
throwUnimplemented();
}
Application&
app() override
getApp() override
{
throwUnimplemented();
}