Pratik Mankawde
4058ca01ac
minor cleanup
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-27 13:47:50 +00:00
Pratik Mankawde
9c5df200b8
cleanup
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-27 13:46:11 +00:00
Pratik Mankawde
96e8ee4bdd
added an extra line
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-27 13:33:28 +00:00
Pratik Mankawde
c182d13ab5
Merge branch 'develop' into pratik/Add-sanitizers-to-CI-builds
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-27 13:21:51 +00:00
Ayaz Salikhov
f399749ee2
chore: Add black pre-commit hook ( #6086 )
...
This change adds Black as a pre-commit hook to format Python files.
2025-11-26 19:14:17 +00:00
Ayaz Salikhov
2ed4047840
chore: Make conan lockfile generation commands into a script ( #6085 )
...
This change moves the lockfile instructions into a script, and instead of removing packages it sets the Conan home directory to a temporary directory.
There are several advantages, such as:
* Not affecting the user's Conan home directory, so there is no need to remove packages.
* Only the script needs to be run, rather than several commands.
2025-11-26 18:43:14 +00:00
Ayaz Salikhov
4e25dc9291
chore: Update lockfile ( #6083 )
...
This change update recipes, to make sure we have the best compatibility with latest compilers and so on.
2025-11-26 17:54:36 +00:00
Bart
a18b30b765
docs: Update instructions how to (re)generate conan.lock file ( #6070 )
...
This change updates the instructions for how to generate a Conan lockfile that is compatible with Linux, macOS, and Windows.
Whenever Conan dependencies change, the Conan lock file needs to be regenerated. However, different OSes have slightly different requirements, and thus require slightly different dependencies. Luckily a single `conan.lock` file can be used, as long as the union of dependencies is included.
The current instructions in the `BUILD.md` file are insufficient to regenerate the lock file such that it is compatible with all OSes, which this change addresses. The three profiles contain the bare minimum needed to generate the lockfile; it does not particularly matter whether the build type is Debug or Release, for instance.
2025-11-26 17:28:06 +00:00
Pratik Mankawde
d942fd9f9c
updated docs
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-26 15:19:13 +00:00
Pratik Mankawde
064d51b79c
more code changes
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-26 15:13:12 +00:00
Pratik Mankawde
6202148623
Merge branch 'develop' into pratik/Add-sanitizers-to-CI-builds
2025-11-26 14:07:07 +00:00
Pratik Mankawde
954fe68e91
added more info to package id configs
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-26 14:03:58 +00:00
Pratik Mankawde
1d38504d85
code review fixes 1
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-26 13:57:44 +00:00
Bart
856470203a
ci: Trigger clio pipeline on PRs targeting release branches ( #6080 )
...
This change triggers the Clio pipeline on PRs that target any of the `release*` branches (in addition to the `master` branch), as opposed to only the `release` branch.
2025-11-25 21:03:17 +00:00
Jingchen
b124c9f7e3
refactor: Retire Flow and FlowSortStrands amendments ( #6054 )
...
Amendments activated for more than 2 years can be retired. This change retires the Flow and FlowSortStrands amendments.
2025-11-25 14:21:17 +00:00
Bart
b550dc00ed
ci: Remove missing commits check ( #6077 )
...
This change removes the CI check for missing commits, as well as a stray path to the publish-docs workflow that isn't used in the on-trigger workflow.
2025-11-24 21:43:39 -05:00
Jingchen
21c02232a5
refactor: Retire RequireFullyCanonicalSig amendment ( #6035 )
...
Amendments activated for more than 2 years can be retired. This change retires the RequireFullyCanonicalSig amendment.
2025-11-24 13:58:37 +00:00
Jingchen
a791c03dc1
refactor: Retire DeletableAccounts amendment ( #6056 )
...
Amendments activated for more than 2 years can be retired. This change retires the DeletableAccounts amendment.
2025-11-24 11:52:08 +00:00
Jingchen
800a315383
refactor: Retire CryptoConditionsSuite amendment ( #6036 )
...
Amendments activated for more than 2 years can be retired. This change retires the CryptoConditionsSuite amendment.
2025-11-24 06:23:16 -05:00
Olek
8449c6c365
Fix: nullptr resolving without db config ( #6029 )
...
If the config disables SQL db usage, such as a validator:
```
[ledger_tx_tables]
use_tx_tables = 0
```
then the pointer to DB engine is null, but it was still resolved during startup. Although it didn't crash in Release mode, possibly due to the compiler optimizing it away, it did crash in Debug mode. This change explicitly checks for the validity of the pointer and generates a runtime error if not set.
2025-11-21 22:20:45 +00:00
Vito Tumas
58e03190ac
docs: Improve VaultWithdraw documentation ( #6068 )
2025-11-21 16:59:12 -05:00
Pratik Mankawde
9cdabe98e2
link to sanitizer_readme.md
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-21 18:10:18 +00:00
Pratik Mankawde
49f8daf82f
updated link
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-21 18:09:14 +00:00
Pratik Mankawde
dd9e554d4a
added readme.
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-21 18:06:01 +00:00
Jingchen
fb74dc28e1
chore: Clean up comment in NetworkOps_test.cpp ( #6066 )
...
This change removes a copyright notice that was accidentally copied over from another file.
2025-11-21 17:11:00 +00:00
Pratik Mankawde
facb6c63e3
cleanup and additions to asan, ubsan suppressions
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-21 16:24:38 +00:00
Pratik Mankawde
e4dccfd49b
refactor: Retire DisallowIncoming amendment ( #6045 )
...
Amendments activated for more than 2 years can be retired. This change retires the DisallowIncoming amendment.
2025-11-21 15:18:00 +00:00
Jingchen
57f4b4eb7f
refactor: Retire Checks amendment ( #6055 )
...
Amendments activated for more than 2 years can be retired. This change retires the Checks amendment.
2025-11-21 14:19:43 +00:00
Pratik Mankawde
32d129ee5e
Merge branch 'develop' into pratik/Add-sanitizers-to-CI-builds
2025-11-21 12:18:31 +00:00
Pratik Mankawde
6e32392f93
added no-PIC
...
Signed-off-by: Pratik Mankawde <pratikmankawde@gmail.com >
2025-11-21 12:17:53 +00:00
Ayaz Salikhov
adbeb94c2b
ci: Only upload artifacts in XRPLF repo owner ( #6060 )
...
This change prevents uploading too many artifacts in non-public repositories.
2025-11-20 18:09:03 +00:00
Mayukha Vadari
a3d4be4eaf
fix: Set correct index for limit in book_offers CLI ( #6043 )
...
This change fixes an indexing typo in the `book_offers` CLI processing, and does not affect the HTTPS/WS RPC processing.
2025-11-20 06:37:28 -05:00
Pratik Mankawde
39ace64833
updated blacklist file
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 18:40:11 +00:00
Pratik Mankawde
4430cb64b8
trying a diff. sanitizer-blacklist syntax
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 18:27:26 +00:00
Pratik Mankawde
d4b033958e
removed static linking.
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 18:05:39 +00:00
Pratik Mankawde
1a08b97fb6
Merge branch 'develop' into pratik/Add-sanitizers-to-CI-builds
2025-11-19 17:51:07 +00:00
Pratik Mankawde
6407788b0f
added halt on error=0 and -fno-pie
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 17:44:39 +00:00
Pratik Mankawde
702d94134e
minor correction
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 17:22:06 +00:00
Pratik Mankawde
7d3fc5c396
added static linking flags
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 17:13:31 +00:00
Pratik Mankawde
810f5e94db
statically link sanitizers
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 17:08:33 +00:00
Olek
6ff495fd9b
Fix: Perform array size check ( #6030 )
...
The `ledger_entry` and `deposit_preauth` requests require an array of credentials. However, the array size is not checked before is gets processing. This fix adds checks and return errors in case array size is too big.
2025-11-19 16:58:18 +00:00
Pratik Mankawde
d026d0640f
build conan deps with sanitizers to fix tsan crashes
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 15:34:24 +00:00
Pratik Mankawde
5befd5d249
added tsan option second_deadlock_stack=1 and more tsan supps
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 13:23:48 +00:00
Pratik Mankawde
4f496db291
few more additions
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 12:20:48 +00:00
Pratik Mankawde
10553fc437
added few more suppressions in tsan.supp
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 11:48:24 +00:00
Pratik Mankawde
087e52ea36
suppress crashes in tsan intrumentation code
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 11:02:55 +00:00
Pratik Mankawde
cb982e7a8a
added pie flag and signal suppressions
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-19 10:42:23 +00:00
sunnyraindy
ad37461ab2
chore: Fix some typos in comments ( #6040 )
2025-11-18 20:21:35 -05:00
Mayukha Vadari
d9c27da529
refactor: split up RPCHelpers.h into two ( #6047 )
...
This PR splits `RPCHelpers.h` into two files, by moving out all the ledger-fetching-related functions into a separate file, `RPCLedgerHelpers.h`. It also moves `getAccountObjects` to `AccountObjects.h`, since it is only used in that one place.
2025-11-18 15:44:39 -05:00
Pratik Mankawde
2610e653d6
only for clang
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
2025-11-18 17:58:59 +00:00