Vito
3f569f4cca
chore: Add more direct includes flagged by include-cleaner
...
Add direct includes for std::exception, std::distance, beast::Journal,
xrpl::ReadView, xrpl::Serializer, xrpl::SerialIter, xrpl::Number, and
xrpl::roundToAsset across files that use them. Also suppress
modernize-use-ranges on a std::is_sorted call where the ranges version
does not compile because SignerEntry is not std::totally_ordered.
2026-04-22 12:43:12 +02:00
Vito
cdef4f3f2c
chore: Apply readability fixes flagged by clang-tidy
...
Use container::empty() and container::contains() instead of size() == 0
and find() != end(), matching the readability-container-size-empty and
readability-container-contains checks.
2026-04-22 12:43:11 +02:00
Vito Tumas
4b9e3997f8
Merge branch 'develop' into tapanito/transaction-invariant
2026-04-22 11:21:39 +02:00
Vito
273f8a13cd
fix: Log transaction JSON on invariant failure
...
The fatal log emitted when finalizeInvariants returns false previously
lacked identifying information, making postmortems difficult. Include
the full transaction JSON, matching the global invariant checker.
2026-04-22 10:00:13 +02:00
Vito
50aa2603ec
docs: Clarify visitInvariantEntry after parameter semantics
...
Callers must use isDelete rather than after == nullptr to detect
deletions; after is non-null for erased SLEs as supplied by the apply
logic.
2026-04-22 10:00:01 +02:00
Alex Kremer
7c7c1894b9
chore: Add -fix to clang-tidy invocation ( #6990 )
2026-04-21 19:00:00 +00:00
Jingchen
45d4aacb53
chore: Remove empty Taker.h ( #6984 )
2026-04-21 18:15:58 +00:00
Vito
c84cab12ae
Merge remote-tracking branch 'origin/develop' into tapanito/transaction-invariant
...
# Conflicts:
# src/test/app/Invariants_test.cpp
2026-04-21 19:02:58 +02:00
Vito
96f60d6def
chore: Add direct includes flagged by include-cleaner
...
Add direct includes for std::shared_ptr, SLE, STTx, and XRPAmount in
transactor translation units that override visitInvariantEntry or
finalizeInvariants. Previously these types were pulled in transitively,
which misc-include-cleaner flags as errors under the project's
clang-tidy configuration.
2026-04-21 18:58:20 +02:00
Vito
687d9489d7
test: Guard against null transactor in Invariants_test
...
Addresses a review comment: the soft BEAST_EXPECT assertion would not
abort on failure, risking a null pointer dereference in the subsequent
checkInvariants call. Use an early-return guard instead.
2026-04-21 18:58:20 +02:00
Alex Kremer
ce3951bbb3
chore: Enable clang-tidy modernize checks ( #6975 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-21 15:32:51 +00:00
Vito Tumas
99d745d4a2
Merge branch 'develop' into tapanito/transaction-invariant
2026-04-21 16:56:01 +02:00
Vito
e28d5e5b50
formatting issues
2026-04-21 16:50:27 +02:00
Ayaz Salikhov
ab887f5049
ci: Upload clang-tidy git diff ( #6983 )
2026-04-21 14:22:33 +00:00
Vito
da44fdb5d3
Merge remote-tracking branch 'origin/develop' into tapanito/transaction-invariant
2026-04-21 14:41:20 +02:00
Alex Kremer
ea023121f5
fix: Add rounding to Vault invariants ( #6217 ) ( #6955 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-21 12:14:07 +00:00
Vito
9e9fdb40a8
Merge remote-tracking branch 'origin/develop' into tapanito/transaction-invariant
2026-04-21 13:47:31 +02:00
yinyiqian1
4b198cd5bb
fix: Disallow MPTClearRequireAuth if is set ( #6712 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-20 21:25:52 +00:00
Alex Kremer
726f20c8f6
feat: Add GRPC TLS support ( #6374 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-20 17:12:14 +00:00
Zhiyuan Wang
96643bb0fa
fix: Check for empty sfAdditionalBooks array in hybrid offer invariant ( #6716 )
2026-04-20 17:10:28 +00:00
chuanshanjida
e83818241a
chore: Remove repetitive word in multiple files ( #6978 )
...
Signed-off-by: chuanshanjida <chuanshanjida@outlook.com >
2026-04-20 16:56:03 +00:00
Ayaz Salikhov
852fbe955d
ci: Add workflow to check PR description has been filled ( #6965 )
2026-04-20 12:12:58 +00:00
dependabot[bot]
b33d0a0479
ci: [DEPENDABOT] Bump tj-actions/changed-files from 47.0.5 to 47.0.6 ( #6973 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-20 11:20:42 +00:00
Alex Kremer
653a383ff5
chore: Enable clang-tidy include cleaner ( #6947 )
2026-04-17 16:43:49 +00:00
Gregory Tsipenyuk
affe5835fe
fix: Change AMMClawback return code to tecNO_PERMISSION ( #6946 )
2026-04-17 14:19:58 +00:00
dependabot[bot]
ef2642f873
ci: [DEPENDABOT] bump actions/upload-pages-artifact from 4.0.0 to 5.0.0 ( #6927 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-17 14:02:02 +00:00
dependabot[bot]
b2038163bc
ci: [DEPENDABOT] bump actions/upload-artifact from 7.0.0 to 7.0.1 ( #6928 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-17 14:01:56 +00:00
Alex Kremer
f1a5ba43ad
chore: Enable clang-tidy readability checks ( #6930 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-17 13:30:52 +00:00
Jingchen
4a73be499d
fix: Fix unity build for book step ( #6942 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-16 17:12:00 +00:00
Sergey Kuznetsov
d52d735543
chore: Move codegen venv setup into build stage ( #6617 )
...
Co-authored-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-15 18:50:49 +00:00
Alex Kremer
6a0ce46755
chore: Enable most clang-tidy bugprone checks ( #6929 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-14 20:24:21 +00:00
Bart
2f029a2120
refactor: Improve exception handling ( #6540 ) ( #6735 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-14 17:14:24 +00:00
Zhiyuan Wang
61fbde3a71
refactor: Remove unused notTooManyOffers function from NFTokenUtils ( #6737 )
2026-04-13 23:18:10 +00:00
Bart
e2e537b3bb
fix: Change Tuning::bookOffers minimum limit to 1 ( #6812 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-10 14:38:46 +00:00
Ed Hennis
a873250019
chore: Make pre-commit line ending conversions work on Windows ( #6832 ) ( #6833 )
2026-04-10 10:12:52 +00:00
Gregory Tsipenyuk
56c9d1d497
fix: Add description for terLOCKED error ( #6811 )
2026-04-08 20:56:19 +00:00
yinyiqian1
d52dd29d20
fix: Address AI reviewer comments for Permission Delegation ( #6675 )
2026-04-08 20:22:19 +00:00
Mayukha Vadari
7793b5f10b
refactor: Combine AMMHelpers and AMMUtils ( #6733 )
2026-04-08 17:38:33 +00:00
Gregory Tsipenyuk
dfcad69155
feat: Add MPT support to DEX ( #5285 )
2026-04-08 16:17:37 +00:00
Pratik Mankawde
6d1a5be8d2
fix: Handle WSClient write failure when server closes WebSocket ( #6671 )
...
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-07 19:15:40 +00:00
Ayaz Salikhov
b0fe2ec58a
ci: Change conditions for uploading artifacts in public/private/org repos ( #6734 )
2026-04-07 14:32:13 +00:00
Bart
c00ed673a8
refactor: Rename non-functional uses of ripple(d) to xrpl(d) ( #6676 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-07 13:00:17 +00:00
Mayukha Vadari
f239256d87
refactor: Move more helper files into libxrpl/ledger/helpers ( #6731 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-06 22:36:32 +00:00
Mayukha Vadari
00761dbb67
fix: Minor RPC fixes ( #6730 )
2026-04-06 22:15:16 +00:00
Zhiyuan Wang
077e03ff33
fix: Prevent deletion of MPTokens with active escrow ( #6635 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-06 17:51:46 +00:00
Vito Tumas
7d524a03b8
fix: Clamp VaultClawback to assetsAvailable for zero-amount clawback ( #6646 )
2026-04-06 15:13:03 +00:00
Vito Tumas
c0ee813666
fix: Add assorted Lending Protocol fixes ( #6678 )
...
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-04-03 17:41:45 +00:00
Mayukha Vadari
8e05416211
fix: Change variable signedness and correctly handle std::optional ( #6657 )
2026-04-03 15:16:50 +00:00
Mayukha Vadari
81555d5456
refactor: Reorganize RPC handler files ( #6628 )
2026-04-02 23:46:17 +00:00
Ayaz Salikhov
6b55c4cdc8
chore: Update XRPLF/actions ( #6713 )
2026-04-02 21:34:20 +00:00