Pratik Mankawde
b0e9e1a24d
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-06-03 16:16:53 +01:00
Pratik Mankawde
bf0b843ce1
docs(telemetry): document Task 4.9 consensus span attribute gap fill
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-06-03 16:16:43 +01:00
Pratik Mankawde
fce770e4f4
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-06-03 16:15:43 +01:00
Pratik Mankawde
8dd5ac55e8
docs(telemetry): document Task 3.11 TX/TxQ span attribute gap fill
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-06-03 16:15:33 +01:00
Pratik Mankawde
507828edde
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-06-03 16:14:57 +01:00
Pratik Mankawde
aca6623f14
docs(telemetry): document Task 2.10 RPC/PathFind span attribute gap fill
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-06-03 16:14:49 +01:00
Pratik Mankawde
765c96919c
feat(telemetry): enrich consensus spans with state, disputes, and ledger_hash
...
Adds workflow-critical attributes to consensus spans:
- consensus.proposal.send: is_bow_out (identifies resignation proposals)
- consensus.accept: consensus_state (yes/moved_on/expired), disputes_count
- consensus.validation.send: ledger_hash (correlates validation to ledger)
Enables answering: "Did we reach consensus or time out?", "How many
disputes existed at acceptance?", "Which ledger did we validate?"
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-06-03 16:09:41 +01:00
Pratik Mankawde
7a9215a4d3
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-06-03 16:07:02 +01:00
Pratik Mankawde
dd9cde88f3
fix(telemetry): qualify tx_span with telemetry:: namespace in apply()
...
The apply() function doesn't have a `using namespace telemetry` directive
(unlike processTransaction), so tx_span attrs need explicit qualification.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-06-03 16:06:51 +01:00
Pratik Mankawde
e52f1470b6
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-06-03 16:02:26 +01:00
Pratik Mankawde
1a2f9a71f5
feat(telemetry): add ter_result and applied attributes to tx.process span
...
Enriches the tx.process span with final outcome after batch application:
- ter_result: the TER code string (e.g., "tesSUCCESS", "tecPATH_DRY")
- applied: boolean whether the transaction was included in the ledger
These attributes complete the tx.process span lifecycle — it now captures
identity (tx_type, tx_hash), intent (fee, sequence), and outcome
(ter_result, applied) for full workflow traceability.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-06-03 16:02:04 +01:00
Pratik Mankawde
ebf107e73c
feat(telemetry): enrich TX and TxQ spans with tx_type, fee, sequence, and status
...
Adds workflow-identifying attributes to transaction lifecycle spans:
- tx.process: tx_type, fee (drops), sequence
- tx.receive: tx_type
- txq.enqueue: tx_type
- txq.accept.tx: txq_status (applied/failed/retried)
- txq.accept: ledger_changed
Enables filtering traces by transaction type (Payment, AMMDeposit, etc.)
and understanding TxQ outcomes without correlating tx_hash externally.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-06-03 15:52:21 +01:00
Pratik Mankawde
d5f9242f84
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-06-03 15:47:42 +01:00
Pratik Mankawde
84fc829be3
feat(telemetry): enrich RPC and PathFind spans with workflow-identifying attributes
...
Wire up span attributes that enable filtering/grouping traces by request
characteristics: batch detection, payload size, resource cost category,
command name on WS spans, and pathfinding search parameters (destination
amount/currency, source asset count).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-06-03 15:46:40 +01:00
Pratik Mankawde
bdd7dea4b4
code coverage fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-03 14:23:24 +01:00
Pratik Mankawde
b46ee12a19
formatting fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-03 14:07:21 +01:00
Ayaz Salikhov
1441d4690d
chore: Update flake.lock to allow conan with clang-22 support ( #7390 )
2026-06-03 00:16:02 +00:00
Vito Tumas
225ed204ad
test: Suppress invariant-failure logs in Vault and LoanBroker bug-regression tests ( #7379 )
2026-06-02 17:12:09 +00:00
Ayaz Salikhov
ad111bcc22
ci: Patch binaries in nix-based images and test in every distro ( #7376 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-06-02 13:51:20 +00:00
Pratik Mankawde
25e08b1840
clang-tidy fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-02 10:46:27 +01:00
Pratik Mankawde
66e6310b56
more clang-tidy fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 19:24:20 +01:00
Pratik Mankawde
11717a5431
build fixed
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 18:13:10 +01:00
Pratik Mankawde
994e425804
more clang-tid fixes!
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 18:07:23 +01:00
Ayaz Salikhov
d4cb68d5a1
ci: Check binaries separately from building them ( #7355 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-06-01 16:47:01 +00:00
Pratik Mankawde
615d339f84
fix(docs): apply rename scripts — prefix=rippled to prefix=xrpld
...
The check-rename CI job requires all rename scripts to have been run.
The telemetry config files had 'prefix=rippled' which should be 'xrpld'.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-06-01 17:03:27 +01:00
Pratik Mankawde
ece8c62bca
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-06-01 17:01:05 +01:00
Pratik Mankawde
bed6770751
Merge branch 'pratik/otel-phase7-native-metrics' into pratik/otel-phase8-log-correlation
2026-06-01 16:58:22 +01:00
Pratik Mankawde
dfdda305ee
clang-tidy fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 16:58:05 +01:00
Pratik Mankawde
2ac93c504e
fix(tests): rename make_Telemetry to telemetry::makeTelemetry in Peer.h
...
The project-wide rename check changed the factory function name but
missed this call site in the consensus simulation test framework.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-06-01 16:45:38 +01:00
Pratik Mankawde
124e3a154d
fix(tests): add getMetricsRegistry() override to TestServiceRegistry
...
ServiceRegistry gained the pure virtual getMetricsRegistry() in phase 7
but TestServiceRegistry was never updated. Returns nullptr since tests
don't need a real MetricsRegistry.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-06-01 16:32:43 +01:00
dependabot[bot]
e209ee5371
ci: [DEPENDABOT] bump eps1lon/actions-label-merge-conflict from 3.0.3 to 3.1.0 ( #7375 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-06-01 15:29:12 +00:00
Vito Tumas
109b649106
refactor: Use STLedgerEntry type aliases instead of std::shared_ptr ( #7282 )
2026-06-01 15:27:13 +00:00
Pratik Mankawde
5697e43921
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-06-01 16:12:30 +01:00
Pratik Mankawde
47f3480fb9
fix(telemetry): replace indirect OTel includes with direct headers in Log.cpp
...
clang-tidy misc-include-cleaner requires each symbol to be provided by
a directly-included header. Replace the convenience trace/context.h
(which only provides GetSpan/SetSpan) with the specific headers for
kSpanKey, holds_alternative, get, shared_ptr, Span, and span.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-06-01 16:11:14 +01:00
Pratik Mankawde
20a6274a48
minor namespace fix
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 16:07:58 +01:00
Pratik Mankawde
7c09c38a5b
Merge branch 'pratik/otel-phase7-native-metrics' into pratik/otel-phase8-log-correlation
2026-06-01 16:01:56 +01:00
Pratik Mankawde
c5ae16cdd9
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-06-01 16:01:42 +01:00
Pratik Mankawde
1162b6f3bc
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase6-statsd
2026-06-01 16:00:14 +01:00
Pratik Mankawde
0bcc7635ac
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-06-01 16:00:00 +01:00
Pratik Mankawde
1ab28d0cf0
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-06-01 15:59:32 +01:00
Pratik Mankawde
967f0082c3
minor compilation issue introduced by merge
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 15:59:16 +01:00
Pratik Mankawde
eeae09c645
build issues
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 15:53:30 +01:00
Pratik Mankawde
34a2afa704
clang-tidy issue fix
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 15:42:59 +01:00
Pratik Mankawde
b8602b7821
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-06-01 15:29:58 +01:00
Pratik Mankawde
7bc6c65bb2
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
2026-06-01 15:29:25 +01:00
Pratik Mankawde
d6fefe2468
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-06-01 15:28:52 +01:00
Pratik Mankawde
781e08a6a6
force static build of otel protobuf on windows
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 15:28:12 +01:00
Pratik Mankawde
a8d70c15f8
clang-tidy issue
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 15:08:10 +01:00
Pratik Mankawde
33aa48b2c7
clang-tidy fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 15:00:09 +01:00
Pratik Mankawde
4d6ddb5f1f
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 14:56:09 +01:00