Ed Hennis
2fdfd2b420
Review feedback from Tapanito and AI
...
- Add missing headers.
- Improve code coverage exclusions.
- Clean up several variable names.
- Improve explanatory comments.
- Remove the switch statement from MantissaRange::getMin. Change it to
a straight power of ten lookup.
2026-05-28 18:41:19 -04:00
Ed Hennis
06a3f76ccd
Skip clang-tidy false positive: misc-include-cleaner
2026-05-28 17:47:41 -04:00
Ed Hennis
dadf4d737d
Merge branch 'develop' into ximinez/number-division-accuracy
2026-05-28 17:46:40 -04:00
Bart
2f3558c610
ci: Run PR title and description checks on staging and release branches ( #7331 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-28 14:57:29 +00:00
Ed Hennis
7b66b42713
Merge branch 'develop' into ximinez/number-division-accuracy
2026-05-27 17:00:59 -04:00
Ayaz Salikhov
f9551ac5ca
style: Run shfmt on workflows, actions and markdown bash code ( #7333 )
2026-05-27 19:24:18 +00:00
Ed Hennis
18ac8a0583
Merge branch 'develop' into ximinez/number-division-accuracy
2026-05-27 15:18:17 -04:00
Bart
1acc42313c
release: Bump version to 3.2.0-rc2 ( #7348 )
2026-05-27 15:11:38 -04:00
Bart
396d772a15
refactor: Enable support for fixCleanup3_2_0 amendment ( #7347 )
2026-05-27 19:10:33 +00:00
Ayaz Salikhov
1438bf1c67
release: Bump version to 3.2.0-rc1 ( #7335 )
2026-05-27 13:20:57 -04:00
Ed Hennis
de2efa5cb9
Remove TMax entirely from normalizeToRange; check type matching directly
2026-05-27 13:06:52 -04:00
Ed Hennis
8dcd88e83c
Tweak how the denominator is handled in division
...
- Removes one int64 to 128 conversion
2026-05-27 12:34:49 -04:00
Ed Hennis
5333422402
Merge remote-tracking branch 'XRPLF/develop' into ximinez/number-division-accuracy
...
* XRPLF/develop:
fix: Fix a rounding error at the `Number::maxRep` cusp (7051)
2026-05-27 12:17:30 -04:00
Ed Hennis
4ec049e727
Minor fixes: missing include, variable init, typo
2026-05-27 12:09:13 -04:00
Ed Hennis
7da643d864
fix: Fix a rounding error at the Number::maxRep cusp ( #7051 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-05-27 15:19:20 +00:00
Ed Hennis
ae9c72bb7c
Test optimization: Number_test::pow10
2026-05-27 00:36:38 -04:00
Ed Hennis
5abecb9fcb
Significant rewrite
...
- Simplify Number::operator/= to use more constexpr values, and fewer
variations.
- Most significantly, rounding up doesn't need more precision, it only
needs to know if there's a remainder after the current precision work
is done. Tracked similarly Guard::xbit_.
- Build a constexpr lookup array for powers of 10. Only a handful of
values are used, but since it's built at compile time, and constexpr,
unused values do not affect memory or performance.
2026-05-27 00:07:48 -04:00
Ed Hennis
12670b0c3f
Merge branch 'ximinez/number-fix-maxrepcusp' into ximinez/number-division-accuracy
2026-05-26 19:21:05 -04:00
Ed Hennis
1e7876a03c
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-26 19:21:01 -04:00
Ed Hennis
e851e80de0
Merge branch 'ximinez/number-fix-maxrepcusp' into ximinez/number-division-accuracy
2026-05-26 16:56:47 -04:00
Ed Hennis
a963035f76
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-26 16:56:43 -04:00
Ayaz Salikhov
1162371def
ci: Only push docker images in XRPLF/rippled ( #7330 )
2026-05-26 20:03:04 +00:00
Ed Hennis
8ab904de57
Merge branch 'ximinez/number-fix-maxrepcusp' into ximinez/number-division-accuracy
2026-05-26 16:01:44 -04:00
Ed Hennis
100ec464d9
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-26 16:01:40 -04:00
Ed Hennis
e89e6f50e8
Merge remote-tracking branch 'XRPLF/ximinez/number-fix-maxrepcusp' into ximinez/number-division-accuracy
...
* XRPLF/ximinez/number-fix-maxrepcusp:
clang-tidy: implicit bool conversion
Address some AI review feedback: predeclare, include, format, comment
fix: Fix `VaultInvariant` and `VaultDeposit` precision bugs at IOU scale boundaries (7272)
ci: Add clang to nix images (7308)
fix: Include management-fee delta in doOverpayment assertion (7039)
fix: Fix clang-tidy pre-commit hook to locate compile_commands.json from repo root (7325)
fix: Use consistent scale for `debtTotal` (7093)
fix: Skip deleted book directories and non-root modifications in `ValidBookDirectory` invariant (7312)
fix: Address review feedback on FD/handle guarding (5823 follow-up) (7310)
fix: Fix non-canonical MPT amount (7117)
2026-05-26 15:53:36 -04:00
Ed Hennis
27456fa439
Use the local range instead of calling a function
2026-05-26 15:52:25 -04:00
Ed Hennis
d6844311c0
clang-tidy: missing header
2026-05-26 15:48:29 -04:00
dependabot[bot]
2a0feca46b
ci: [DEPENDABOT] bump docker/setup-buildx-action from 4.0.0 to 4.1.0 ( #7322 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-26 19:36:32 +00:00
dependabot[bot]
108a4c8217
ci: [DEPENDABOT] bump codecov/codecov-action from 6.0.0 to 6.0.1 ( #7321 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-26 19:36:21 +00:00
dependabot[bot]
4584b01bde
ci: [DEPENDABOT] bump docker/build-push-action from 7.1.0 to 7.2.0 ( #7320 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-26 19:36:13 +00:00
dependabot[bot]
7c59786565
ci: [DEPENDABOT] bump docker/metadata-action from 6.0.0 to 6.1.0 ( #7319 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-26 19:36:00 +00:00
dependabot[bot]
9623e67b76
ci: [DEPENDABOT] bump docker/login-action from 4.1.0 to 4.2.0 ( #7318 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-26 19:35:52 +00:00
Andrzej Budzanowski
85af406a0f
fix: Update clang-tidy to include src/tests directory header check ( #7307 )
2026-05-26 19:35:32 +00:00
Ed Hennis
fbee0349f5
clang-tidy: implicit bool conversion
2026-05-26 15:21:42 -04:00
Ayaz Salikhov
ac33fb32a7
chore: Pin Python packages for codegen using uv ( #7329 )
2026-05-26 18:35:38 +00:00
Ayaz Salikhov
23d0812827
style: Use shfmt instead of bashate ( #7326 )
2026-05-26 18:28:23 +00:00
Vito Tumas
49567e7283
fix: Fix edge-case where vault-depositor may get stuck ( #7139 )
2026-05-26 18:18:40 +00:00
Ed Hennis
84ca271d95
Address some AI review feedback: predeclare, include, format, comment
...
- Predeclare type reference in Rules.h
- Remove an unneeded include in EscrowToken_test
- Number_test will format negative BigInts correctly (unused)
- Remove an inaccurate comment
2026-05-26 13:51:06 -04:00
Ed Hennis
75dfc65f5f
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-26 13:47:33 -04:00
Vito Tumas
633ef4706f
fix: Fix VaultInvariant and VaultDeposit precision bugs at IOU scale boundaries ( #7272 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-26 16:32:44 +00:00
Ayaz Salikhov
49cb3f45a4
ci: Add clang to nix images ( #7308 )
...
Co-authored-by: semgrep-companion-app[bot] <218312740+semgrep-companion-app[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-26 15:45:33 +00:00
Vito Tumas
22a21b175e
fix: Include management-fee delta in doOverpayment assertion ( #7039 )
2026-05-26 14:01:52 +00:00
Pratik Mankawde
e9d885bd9b
fix: Fix clang-tidy pre-commit hook to locate compile_commands.json from repo root ( #7325 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-26 13:50:18 +00:00
Jingchen
a911f9089e
fix: Use consistent scale for debtTotal ( #7093 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-24 20:44:29 +00:00
Peter Chen
e34c2667d7
fix: Skip deleted book directories and non-root modifications in ValidBookDirectory invariant ( #7312 )
2026-05-24 20:37:16 +00:00
Ed Hennis
48b1716e6f
Make Number::operator/= significantly more accurate
...
- Prevents extreme dust rounding from getting lost, especially when
rounding away from zero. (Upward for positive, downward for negative.)
2026-05-23 19:02:03 +01:00
Valentin Balaschenko
30de556224
fix: Address review feedback on FD/handle guarding ( #5823 follow-up) ( #7310 )
2026-05-23 14:48:48 +00:00
Gregory Tsipenyuk
dcd2ff0b5f
fix: Fix non-canonical MPT amount ( #7117 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-23 06:40:26 +00:00
Ed Hennis
4ab886bcbc
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-22 17:56:15 -04:00
Bart
dfb9b8ed9a
release: Bump version to 3.2.0-b7 ( #7316 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
3.2.0-b7
2026-05-22 19:32:12 +00:00