Pratik Mankawde
2aeea61964
docs(telemetry): use SpanNames constants (not literals) in SpanGuard @code examples
...
The otel-naming Rule F check scans @code doc examples as call sites; raw
string literals there trip the rule. Reference *SpanNames.h constants /
placeholder identifiers in the examples so comments follow the naming rules.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-17 22:11:24 +01:00
Pratik Mankawde
4f9650502b
feat(telemetry): add SpanGuard::detached() and rootSpan() to fix cross-thread scope leak
...
detached() strips the thread-local OTel Scope so a guard can be safely
moved to and destroyed on another thread; it pops the Scope on the origin
thread and moves the span into a scope-less guard. rootSpan() starts a span
as a fresh trace root (kIsRootSpanKey) so inbound entry points never inherit
an ambient span left active on the thread.
Impl now holds an optional<Scope> (nullopt for detached guards). Updated the
SpanGuard class docs and docs/build/telemetry.md with the cross-thread rules.
The unit test lands on phase2 where the telemetry test module exists.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-17 19:42:44 +01:00
Pratik Mankawde
7be57a460b
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-17 14:27:46 +01:00
Pratik Mankawde
4d64d3215d
updates to node-health
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-17 14:26:27 +01:00
Vito Tumas
5ce0b1c2c7
refactor: Restructure LendingHelpers to improve readability ( #7807 )
2026-07-16 15:47:56 +00:00
Andrzej Budzanowski
701311f27e
test: Add google benchmark dependency and migrate nodestore timing test as a benchmark ( #7317 )
...
Co-authored-by: Marek Foss <marek.foss@neti-soft.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-16 15:44:43 +00:00
Sergey Kuznetsov
b1a670c46e
ci: Add Rust to CI ( #7808 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-07-16 15:28:04 +00:00
Bart
18e311e1e2
chore: Bump version to 3.3.0-rc1 ( #7806 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
3.3.0-rc1
2026-07-16 13:54:12 +00:00
Denis Angell
69b70d7a0d
fix: Refactor Batch Transaction IDs ( #7736 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2026-07-16 13:15:59 +00:00
Mayukha Vadari
b42cde3e85
refactor: Remove redundant enable checks in ConfidentialMPT txs ( #7809 )
2026-07-16 09:51:19 +00:00
Peter Chen
cd38c0e800
chore: Update mpt-crypto-lib to 0.4.0-rc4 ( #7813 )
2026-07-15 23:47:22 +00:00
Vlad
433e5f6896
fix: Reject zero CheckID in CheckCancel and CheckCash ( #7685 )
2026-07-15 22:08:45 +00:00
Ayaz Salikhov
781ab723af
ci: Fix workflow launch on matrix-unrelated labels ( #7812 )
2026-07-15 18:24:31 +00:00
Ed Hennis
a24e543af3
fix: Allocate TaggedCache::getKeys() memory outside of lock ( #7567 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-07-15 13:30:20 +00:00
Sophia Xie
a0fd1cce54
fix: Re-store nodes missing from both backends during online_delete rotation ( #7763 )
...
Co-authored-by: Valentin Balaschenko <13349202+vlntb@users.noreply.github.com >
2026-07-14 23:42:40 +00:00
Kassaking7
cda63d00a2
fix: Add amendment sponsor for AccountRootsDeletedClean ( #7801 )
2026-07-14 19:41:53 +00:00
Ed Hennis
530e09dbe8
fix: Update base_uint and test changes released in 3.1.3 ( #7570 )
...
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-07-14 18:48:10 +00:00
Ed Hennis
f10dd7b450
fix: Handle rounding just above kMaxRep more accurately ( #7389 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-07-14 18:47:41 +00:00
Ed Hennis
0a4676d947
fix: Document and assert "after" is never null in invariants ( #7354 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-07-14 18:16:46 +00:00
Ayaz Salikhov
0dc942508e
ci: Run full matrix only on Ready to merge or Full CI build labeled PRs ( #7689 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-07-14 16:09:20 +00:00
Gregory Tsipenyuk
2403670da9
fix: Strengthen Clawback invariant checks for MPT balances ( #7285 )
2026-07-14 14:31:06 +00:00
Jingchen
c621136748
test: Add unit tests for IP address related functions ( #7744 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-07-14 14:29:18 +00:00
Sergey Kuznetsov
2e25435a4a
ci: Add Rust to Nix docker image ( #7571 )
2026-07-14 13:28:55 +00:00
Ayaz Salikhov
ab3ff66cd9
docs: Add more information about pre-commit hooks and how to set them up ( #7802 )
2026-07-14 12:55:34 +00:00
Alex Kremer
73e97b8b84
test: Add JSON array size tests ( #7592 )
2026-07-14 12:35:04 +00:00
Ayaz Salikhov
e1d4f357dc
chore: Enable most readability checks ( #7772 )
2026-07-14 12:21:40 +00:00
Bart
acd54fd627
ci: Do not run conflict checker when label is applied ( #7774 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-07-14 10:22:49 +00:00
Ayaz Salikhov
cd06ee221d
chore: Run clang_tidy_check with pass_filenames: false from pre-commit ( #7800 )
2026-07-13 19:19:18 +00:00
Peter Chen
752dab8b30
feat: Add delegate filter param for account_tx RPC ( #6126 )
2026-07-13 18:44:59 +00:00
Mayukha Vadari
86583bc34e
refactor: Move jss.h include out of Indexes.h ( #7799 )
2026-07-13 17:44:47 +00:00
Ayaz Salikhov
2b4d067ace
test: Add tests for check doxygen style ( #7795 )
2026-07-13 14:38:33 +00:00
Ayaz Salikhov
62634463f4
style: Add pre-commit hook to check doxygen style ( #7794 )
2026-07-13 13:27:14 +00:00
Ayaz Salikhov
73b6852a12
style: Unify style for all Doxygen comments ( #7776 )
2026-07-13 10:40:40 +00:00
Pratik Mankawde
a512009170
fix(telemetry): replace std::format with string concat for gcc-12
...
libstdc++ ships <format> starting with gcc-13, so std::format in
SpanGuard::span() fails to compile on gcc-12. Build the "<prefix>.<name>"
span name via std::string::append instead and drop the <format> include.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-11 17:59:33 +01:00
Ed Hennis
8306ac7710
fix: Improve Number addition/subtraction rounding ( #7369 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-07-11 00:18:31 +00:00
Olek
fd2cc6dcb3
feat: XLS-68: Sponsor, #5887 continuation ( #7350 )
...
Co-authored-by: tequ <git@tequ.dev >
Co-authored-by: yinyiqian1 <yqian@ripple.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Peter Chen <34582813+PeterChen13579@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <96991820+Kassaking7@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <asalikhov@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <1830604455@qq.com >
2026-07-10 21:58:19 +00:00
Pratik Mankawde
c7b04a043e
fix(telemetry): drop unused <cstddef> from SpanGuard.h (misc-include-cleaner)
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-09 14:00:17 +01:00
Pratik Mankawde
e7ba376839
fix(telemetry): add missing span_metadata.h for SpanKind (misc-include-cleaner)
2026-07-08 18:41:59 +01:00
Sergey Kuznetsov
c7adb215ed
chore: Add .envrc for automatic devshell switch by direnv ( #7756 )
2026-07-08 17:28:48 +00:00
Pratik Mankawde
22f5b77e0c
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
2026-07-08 16:02:43 +01:00
Pratik Mankawde
adeda255f0
Merge remote-tracking branch 'origin/develop' into pratik/otel-phase1a-plan-docs
2026-07-08 16:02:37 +01:00
Ayaz Salikhov
71ee0f400b
chore: Use same compiler in Nix devshell as in CI ( #7751 )
2026-07-08 14:51:39 +00:00
Pratik Mankawde
4e9df8b5c3
fix(telemetry): add missing <cstddef> include for std::size_t in SpanGuard.h
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-07-08 15:40:38 +01:00
Pratik Mankawde
c6be7cf83a
fix(telemetry): resolve clang-tidy CI errors (include-cleaner, braces)
...
Add missing <cstdint> include for std::uint32_t in Telemetry.h.
Add braces around single-line if bodies in Telemetry.cpp.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-07-08 15:17:58 +01:00
Ayaz Salikhov
58af1e6f18
release: Bump version to 3.3.0-b1 ( #7755 )
3.3.0-b1
2026-07-08 12:40:24 +00:00
Ayaz Salikhov
e372c45836
chore: Enable most performance checks ( #7727 )
2026-07-07 21:03:56 +00:00
Ayaz Salikhov
2ebc96a4a6
perf: Use std::from/to_chars for JSON double parsing/formating ( #7735 )
2026-07-07 21:02:39 +00:00
Pratik Mankawde
b1af0a9511
docs(telemetry): remove Phase reference from tempo.yaml base-filter comment
...
Reviewer noted implementation-phase references should not appear in
shipped config comments. Drop the "Phase 1b" token, keep the filter
description.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-07-07 19:43:40 +01:00
Ayaz Salikhov
c5a6de6ef7
chore: Enable most cppcoreguidelines checks ( #7660 )
2026-07-07 13:12:52 +00:00
Marek Foss
f5e63f8a91
test: Migrate basics Beast tests to GTest ( #7136 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-06 19:48:36 +00:00