Commit Graph

2218 Commits

Author SHA1 Message Date
JoelKatz
159fe2145a Copy the correct hash 2012-09-05 14:36:50 -07:00
JoelKatz
7a300f6c7b Fix deadlock. 2012-09-05 10:18:23 -07:00
JoelKatz
1dfdf8e9d8 Count a validation for its previous ledger if it's during consensus time. 2012-09-05 10:05:15 -07:00
JoelKatz
7785b89b5d Some extra debugging. Don't jump back to the ledger we just left (yeah,
there was another way that could happen.)
2012-09-05 07:22:04 -07:00
JoelKatz
00199d3915 An imperfect fix for the case where we get validations during the consensus process for the next ledger and
think it's a change in the previous ledger.
2012-09-03 20:36:51 -07:00
JoelKatz
cfedc4b981 Bugfix. 2012-09-03 20:29:59 -07:00
JoelKatz
4930ebb945 Simplify the way we handle validations. Include a signing time instead of a
closing time. Keep only the validation with the most recent signing time.
Sign using network time. This eliminates the ValidationPair nightmare and
makes the logic must easier to understand, increasing confidence that it
does what it's supposed to do.
2012-09-03 20:13:57 -07:00
JoelKatz
0862ed2957 Don't get stuck in consensus process. 2012-09-03 10:14:25 -07:00
JoelKatz
f4dad6fe3c Timestamps were expiring too soon. 2012-09-03 09:54:27 -07:00
JoelKatz
1891cf0654 Improve error message. 2012-09-03 09:50:25 -07:00
JoelKatz
ee78114033 Convenience type. 2012-09-03 09:47:14 -07:00
JoelKatz
7eef087d53 Typo. 2012-09-03 09:47:03 -07:00
JoelKatz
c598b25b87 Remove annoying debug. 2012-09-03 09:46:49 -07:00
JoelKatz
203533db3d Remove chatty debug. 2012-09-03 09:46:35 -07:00
JoelKatz
0149c3948b Ack! Test for stale proposals was backwards. 2012-09-03 08:50:28 -07:00
JoelKatz
46f6110cdd Small cleanup. 2012-09-03 08:40:10 -07:00
JoelKatz
df1e5ab95a Cleanup.
Fix a bug when we incompletely remove a vote on a disputed transaction.
2012-09-03 08:35:53 -07:00
JoelKatz
b4548760df New-style proposal support. 2012-09-03 06:03:45 -07:00
JoelKatz
cc4827559c Support for proposals that contain the previous ledger hash.
A fix for ledger acquires not stopping when they should.
2012-09-03 06:03:09 -07:00
JoelKatz
7d6259d8b3 Whitespace fix. 2012-09-03 06:02:42 -07:00
JoelKatz
4f598af582 Change 'shouldClose' to return a bool.
Clear structures on LCL view change during consensus window.
Cleaner calculation of 'rounded' close times.
Maintain close time offset.
2012-09-03 05:16:32 -07:00
JoelKatz
8eb33f6bb5 Better logging of time offsets on connection. 2012-09-03 05:16:08 -07:00
JoelKatz
81793192cb Bugfix and close time offset set function. 2012-09-03 04:37:25 -07:00
JoelKatz
9f8c1bdc7a Cleanups. 2012-09-03 03:15:42 -07:00
JoelKatz
9977463122 You no longer need .getFullText() on an operator<< to an ostream.
There's like 25 of them in TransactionEngine.cpp that can be removed when convenient
2012-09-03 02:30:17 -07:00
JoelKatz
d5fe3261ab Cleanups and simplfications. 2012-09-03 01:47:03 -07:00
JoelKatz
b950877758 Some proposal cleanups. 2012-09-03 01:19:58 -07:00
JoelKatz
3005d46b12 Cleanup. 2012-09-01 01:01:28 -07:00
JoelKatz
3bd054748e Fix a vulnerability. Someone could see a ledger proposal and send us a
malformed version of that ledger proposal that failed our validity check but
was similar enough to the real proposal to trick us into suppressing that
proposal as a duplicate.
2012-09-01 00:53:40 -07:00
JoelKatz
02bd898e51 Some const-correctness.
const SLE::pointer & -> SLE::ref
2012-08-31 18:26:45 -07:00
JoelKatz
9ef0a5491b Use "Ledger::ref" instead of "const Ledger::pointer&". 2012-08-31 18:11:41 -07:00
JoelKatz
ad12e318ba Allow a peer position to be removed from the consensus logic if the peer is
not responding. This version uses static timing. A peer takes a position
every 12 seconds and a position is valid for 20 seconds. It might make sense
to either make that timing adaptive or include a "validity time" field in
the position. However, I think this is really only going to be an issue in
fairly small networks (which is why we are seeing it).
2012-08-31 15:51:41 -07:00
JoelKatz
f636ae861e Merge branch 'master' of github.com:jedmccaleb/NewCoin 2012-08-31 14:47:55 -07:00
JoelKatz
c3603c403d Code to determine how old a proposal is.
Low-level code to remove a peer from the consensus process.
2012-08-31 14:47:31 -07:00
Arthur Britto
69de9f9ce2 Progress toward ripple pre restructuring forward. 2012-08-31 14:05:37 -07:00
Arthur Britto
73e6e70f13 Use stl for min and max. 2012-08-30 21:16:07 -07:00
Arthur Britto
e8a74c7679 Work on ripple. 2012-08-30 21:15:46 -07:00
Arthur Britto
22a1cb6eed Work towards ripple. 2012-08-30 15:19:28 -07:00
Arthur Britto
61de69e8d0 Merge branch 'ripple' 2012-08-30 13:17:57 -07:00
Arthur Britto
657084f5b9 Rework applyTransaction to use new TERs. 2012-08-30 13:17:38 -07:00
JoelKatz
4d3fc5b6a5 Stash and apply proposals received with a different LCL. 2012-08-30 12:28:02 -07:00
JoelKatz
faaedb806f Start of the proposal defer/playback code.
Clean up tem codes to tap codes.
2012-08-30 11:43:20 -07:00
JoelKatz
651cee5738 Clean up ledger JSON output. 2012-08-30 10:44:21 -07:00
JoelKatz
de5c9cc1a2 Comment out some code that's causing an issue. 2012-08-30 10:44:09 -07:00
JoelKatz
dbc2b4c4e9 Improve log message text. 2012-08-30 10:30:19 -07:00
JoelKatz
ee71603dec Logic error in last close logic making us thing consensus was slow. 2012-08-30 10:29:56 -07:00
JoelKatz
9308abc8e1 Extra logging. 2012-08-30 10:05:33 -07:00
JoelKatz
e5af7072bc Propogate a view change during consensus to the NetworkOPs code. 2012-08-30 10:04:58 -07:00
JoelKatz
c8d3de7b7d Remove an incorrect assertion. 2012-08-30 09:48:59 -07:00
JoelKatz
c481bd6cba Simplify the code that handles a ledger change in the consensus window.
Remove duplicate code. Handle edge cases correctly in all code paths.
2012-08-30 09:38:44 -07:00