Commit Graph

13904 Commits

Author SHA1 Message Date
JCW
14617931d4 Fix PR comments 2026-04-02 11:33:16 +01:00
JCW
a2e8e37064 Fix issues
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
2026-03-26 11:06:13 +00:00
JCW
64469a75f8 Fix issues
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
2026-03-26 10:51:17 +00:00
Jingchen
1406354e36 Update src/tests/libxrpl/helpers/TxTest.cpp
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-03-26 10:22:51 +00:00
JCW
a65fcfd152 fix levelisation error
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
2026-03-25 18:44:04 +00:00
JCW
c5d4d6f2fa Fix comments
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
2026-03-25 18:38:21 +00:00
Jingchen
aebae05e3e Update src/tests/libxrpl/helpers/TxTest.cpp
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-03-25 18:35:35 +00:00
JCW
371f1b8111 Fix comments
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
2026-03-25 18:32:34 +00:00
JCW
81f221155e Fix comments
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
2026-03-25 18:23:04 +00:00
JCW
9b3b71e7ab Fix comments
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
2026-03-25 18:21:42 +00:00
JCW
0e2855c6ba Merge remote-tracking branch 'origin/develop' into a1q123456/new-jtx
Signed-off-by: JCW <a1q123456@users.noreply.github.com>

# Conflicts:
#	.github/scripts/levelization/results/ordering.txt
#	cmake/XrplCore.cmake
#	cmake/XrplProtocolAutogen.cmake
#	include/xrpl/ledger/Ledger.h
#	include/xrpl/protocol_autogen/LedgerEntryBase.h
#	include/xrpl/protocol_autogen/LedgerEntryBuilderBase.h
#	include/xrpl/protocol_autogen/STObjectValidation.h
#	include/xrpl/protocol_autogen/TransactionBase.h
#	include/xrpl/protocol_autogen/transactions/LoanBrokerCoverClawback.h
#	include/xrpl/protocol_autogen/transactions/LoanBrokerCoverDeposit.h
#	include/xrpl/protocol_autogen/transactions/LoanBrokerCoverWithdraw.h
#	include/xrpl/protocol_autogen/transactions/LoanBrokerDelete.h
#	include/xrpl/protocol_autogen/transactions/LoanBrokerSet.h
#	include/xrpl/protocol_autogen/transactions/LoanDelete.h
#	include/xrpl/protocol_autogen/transactions/LoanManage.h
#	include/xrpl/protocol_autogen/transactions/LoanPay.h
#	include/xrpl/protocol_autogen/transactions/LoanSet.h
#	include/xrpl/protocol_autogen/transactions/VaultClawback.h
#	include/xrpl/protocol_autogen/transactions/VaultCreate.h
#	include/xrpl/protocol_autogen/transactions/VaultDelete.h
#	include/xrpl/protocol_autogen/transactions/VaultDeposit.h
#	include/xrpl/protocol_autogen/transactions/VaultSet.h
#	include/xrpl/protocol_autogen/transactions/VaultWithdraw.h
#	scripts/generate_ledger_classes.py
#	scripts/generate_tx_classes.py
#	scripts/macro_parser_common.py
#	scripts/requirements.txt
#	src/libxrpl/ledger/Ledger.cpp
#	src/test/app/AccountSet_test.cpp
#	src/test/app/FeeVote_test.cpp
#	src/test/consensus/NegativeUNL_test.cpp
#	src/tests/libxrpl/CMakeLists.txt
#	src/xrpld/app/ledger/detail/LedgerCleaner.cpp
#	src/xrpld/app/main/Application.cpp
#	src/xrpld/rpc/detail/RippleLineCache.cpp
#	src/xrpld/rpc/detail/RippleLineCache.h
#	src/xrpld/rpc/detail/TrustLine.cpp
#	src/xrpld/rpc/detail/TrustLine.h
#	src/xrpld/rpc/handlers/AccountLines.cpp
#	src/xrpld/rpc/handlers/GatewayBalances.cpp
#	src/xrpld/rpc/handlers/NoRippleCheck.cpp
2026-03-25 18:09:13 +00:00
Jingchen
8f182e825a refactor: Modularise ledger (#6536)
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
Co-authored-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
2026-03-25 16:32:45 +00:00
Ayaz Salikhov
cd78569d94 chore: Use unpatched version of soci (#6649) 2026-03-25 16:06:31 +00:00
Mayukha Vadari
2c7af360c2 fix: Remove unused/unreachable transactor code (#6612) 2026-03-25 16:02:14 +00:00
Alex Kremer
403fd7c649 fix: More clang-tidy issues found after merging to develop (#6640)
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
2026-03-25 14:28:28 +00:00
Ayaz Salikhov
dfed0481f7 docs: Rewrite conan docs for custom recipes (#6647) 2026-03-25 14:25:33 +00:00
Bart
0dc0c8e912 docs: Update LICENSE.md year to present (#6636)
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
2026-03-25 14:24:10 +00:00
Ayaz Salikhov
0510ee47d7 chore: Update some external dependencies (#6642) 2026-03-25 10:44:14 +00:00
Ayaz Salikhov
589c9c694c chore: Update external dependencies due to upstream merge (#6630) 2026-03-24 23:18:41 +00:00
Jingchen
4096623ae1 chore: Remove the forward declarations that cause build errors when unity build is enabled (#6633)
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
2026-03-24 23:00:41 +00:00
Alex Kremer
dda162087f docs: Add note about clang-tidy installation (#6634) 2026-03-24 21:18:03 +00:00
Mayukha Vadari
85a4015a64 fix: Assorted Permissioned Domain fixes (#6587) 2026-03-24 18:53:57 +00:00
Mayukha Vadari
f7bb4018fa fix: Assorted Vault fixes (#6607) 2026-03-24 18:53:49 +00:00
Alex Kremer
0eedefbf45 refactor: Enable more clang-tidy readability checks (#6595)
Co-authored-by: Sergey Kuznetsov <kuzzz99@gmail.com>
2026-03-24 15:42:12 +00:00
Mayukha Vadari
8b986e4ab0 refactor: Improve imports to only call the needed helpers (#6624) 2026-03-24 10:20:32 +00:00
Olek
dcfcdab14e fix: Remove superfluous view update from credentials (#6545) 2026-03-23 18:29:34 +00:00
Mayukha Vadari
e0dbe90370 refactor: Move ledger entry helper functions from View.h/View.cpp to dedicated helper files (#6453)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-23 15:39:58 +00:00
dependabot[bot]
c463d0ff06 ci: [DEPENDABOT] bump codecov/codecov-action from 5.5.2 to 5.5.3 (#6615)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-03-23 14:04:22 +00:00
Mayukha Vadari
be1cc48d84 fix: Assorted Oracle fixes (#6570) 2026-03-22 18:08:18 +00:00
Ayaz Salikhov
cf2eb149ee fix: Update .git-blame-ignore-revs (#6577) 2026-03-19 22:48:20 +00:00
Ayaz Salikhov
762922a07f chore: Don't allow files more than 400kb to be added to the repo (#6597) 2026-03-19 21:20:56 +00:00
Bart
fd28656ded ci: Check for signed commits in PR (#6559)
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
2026-03-19 17:38:09 +00:00
Ayaz Salikhov
9316da784a ci: Update XRPLF/actions (#6594) 2026-03-19 17:29:22 +00:00
Michael Legleux
6efd31229a fix: Use correct format and event for workflows for release tags (#6554) 2026-03-19 10:23:51 +00:00
Alex Kremer
12954d5392 fix: Address remaining issue after clang-tidy merge (#6582) 2026-03-18 22:41:09 +00:00
Jingchen
b1e5ba0518 feat: Add code generator for transactions and ledger entries (#6443)
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
2026-03-18 21:11:51 +00:00
Mayukha Vadari
d360e7c5b6 refactor: Rename transactor files/classes to match the tx name (#6580) 2026-03-18 19:52:07 +00:00
Ayaz Salikhov
804a351773 ci: Use external action implementation of check-pr-title (#6578) 2026-03-18 18:31:42 +00:00
Ayaz Salikhov
697fb64e8c ci: Don't check PR title for drafts (#6573) 2026-03-18 17:46:27 +00:00
Alex Kremer
57e4cbbcd9 refactor: Add simple clang-tidy readability checks (#6556)
This change enables the following clang-tidy checks:
-  readability-avoid-nested-conditional-operator,
-  readability-avoid-return-with-void-value,
-  readability-braces-around-statements,
-  readability-const-return-type,
-  readability-container-contains,
-  readability-container-size-empty,
-  readability-else-after-return,
-  readability-make-member-function-const,
-  readability-redundant-casting,
-  readability-redundant-inline-specifier,
-  readability-redundant-member-init,
-  readability-redundant-string-init,
-  readability-reference-to-constructed-temporary,
-  readability-static-definition
2026-03-18 16:41:49 +00:00
Mayukha Vadari
b92a9a3053 fix: Make assorted NFT fixes (#6566)
This change:
* Removes a set of unnecessary brackets in the initialization of an `std::uint32_t`.
* Fixes a couple of incorrect flags (same value, just wrong variables - so no amendment needed).
2026-03-18 14:47:59 +00:00
Mayukha Vadari
dcaef828b4 refactor: Replace !=/== tesSuccess with using isTesSuccess (#6409)
This change replaces all instances of `<variable> != tesSUCCESS` with `!isTesSuccess(<variable>)` and `<variable> == tesSUCCESS` with `isTesSuccess(<variable>)`.
2026-03-18 14:15:10 +00:00
yinyiqian1
6fbeb04d9e fix: Disallow empty permission list when Delegate object is absent (#6542)
This change fixes delegation:
* If the Delegate object is not present, we should disallow empty permission list in DelegateSet preclaim.
* Empty permission list is only allowed to delete the existing Delegate object.
* In `doApply`, permission list being empty returns `tecINTERNAL`, which should not happen.
2026-03-18 13:39:31 +00:00
Alex Kremer
2a325e7e2c chore: Enable clang-tidy bugprone-use-after-move check (#6476) 2026-03-18 00:12:06 +00:00
Bart
808e814489 ci: Update check-pr-title action hash (#6572) 2026-03-17 23:26:01 +00:00
Copilot
9e14707e77 fix: Peer crawler port field type inconsistency (#6318)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com>
Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
2026-03-17 22:03:56 +00:00
Mayukha Vadari
95a45d7442 chore: Add comment explaining why ammLPHolds is called twice (#6546) 2026-03-17 20:11:36 +00:00
Bart
5fc4ab3e37 ci: Let required runs be triggered by merge group events (#6563)
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
2026-03-17 20:03:48 +00:00
tequ
b129b71c33 refactor: Use ReadView instead of ApplyView in authorizedDepositPreauth() (#6560) 2026-03-17 15:56:51 -04:00
tequ
013c2d6a56 refactor: Add const qualifier to SLE in verifyDepositPreauth parameter (#6555) 2026-03-17 19:33:18 +00:00