- Originally defined as uint64_t, but the testIssuerLoan() test called
it with a negative number, causing an overflow to a very large number
that in some circumstances could be silently cast back to an int64_t,
but might not be. I believe this is UB, and we don't want to rely on
that.
- Exclude LogicError lines in ApplyView.cpp (specifically directory
operations) from code coverage.
- Replace the ability to set the next page on a new directory page with
an assert, because nothing uses it right now.
- Early return with success for batch inner transactions in preflight2.
- Spec: XLS-66
- Introduces amendment "LendingProtocol", but leaves it UNSUPPORTED to
allow for standalone testing, future development work, and potential
bug fixes.
- AccountInfo RPC will indicate the type of pseudo-account when
appropriate.
- Refactors and improves several existing classes and functional areas,
including Number, STAmount, STObject, json_value, Asset, directory
handling, View helper functions, and unit test helpers.
- Exclude LogicError lines in ApplyView.cpp (specifically directory
operations) from code coverage.
- Replace the ability to set the next page on a new directory page with
an assert, because nothing uses it right now.
- Early return with success for batch inner transactions in preflight2.
This change moves the lockfile instructions into a script, and instead of removing packages it sets the Conan home directory to a temporary directory.
There are several advantages, such as:
* Not affecting the user's Conan home directory, so there is no need to remove packages.
* Only the script needs to be run, rather than several commands.
This change updates the instructions for how to generate a Conan lockfile that is compatible with Linux, macOS, and Windows.
Whenever Conan dependencies change, the Conan lock file needs to be regenerated. However, different OSes have slightly different requirements, and thus require slightly different dependencies. Luckily a single `conan.lock` file can be used, as long as the union of dependencies is included.
The current instructions in the `BUILD.md` file are insufficient to regenerate the lock file such that it is compatible with all OSes, which this change addresses. The three profiles contain the bare minimum needed to generate the lockfile; it does not particularly matter whether the build type is Debug or Release, for instance.
* XRPLF/ximinez/lending-XLS-66:
Review feedback from @shawnxie999: MPT Clawback
Move the ValidPseudoAccounts class back to its original location
Fix formatting again
refactor: Retire Flow and FlowSortStrands amendments (6054)
Add additional documentation to Lending Protocol (6037)
This change triggers the Clio pipeline on PRs that target any of the `release*` branches (in addition to the `master` branch), as opposed to only the `release` branch.
- The class didn't actually change much, if at all, but somehow got
relocated.
- This should make the review easier, and reduce the footprint of the
PR.
* XRPLF/ximinez/lending-XLS-66: (47 commits)
Review feedback from @gregtatcam: typo
Review feedback from @Tapanito, @gregtatcam, and @shawnxie999
Update src/xrpld/app/tx/detail/LoanBrokerCoverClawback.cpp
Fix formatting
Add deep freeze check to LoanBrokerDelete (6053)
Fix build error with LoanBroker invariant
Address a couple of feedback items from @Tapanito and @shawnxie999:
Review feedback from @shawnxie999: removeEmptyHolding
Review feedback from @shawnxie999: broker owner count
Update src/xrpld/app/tx/detail/LoanBrokerCoverClawback.cpp
Update src/xrpld/app/tx/detail/LoanBrokerCoverDeposit.cpp
Update src/xrpld/app/tx/detail/LoanBrokerSet.cpp
Add a LoanBroker invariant to compare CoverAvailable to balance
refactor: Retire RequireFullyCanonicalSig amendment (6035)
refactor: Retire DeletableAccounts amendment (6056)
refactor: Retire CryptoConditionsSuite amendment (6036)
Review feedback from @gregtatcam: variable name
Review feedback from @gregtatcam: readability
From discussion with @gregtatcam: Revert "Payment"
Review feedback from @gregtatcam: compute vs. calculate
...
- Created a common doWithdraw function for VaultWithdraw and
LoanBrokerCoverWithdraw. Added verifyDepositPreauth to it, so that
both transactions will get the check.
- Add a missing null check to LoanBrokerSet, and add log messages to the
existing checks.
