ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix clang-tidy issues

Browse Source
This commit is contained in:
Mayukha Vadari
2026-04-03 12:33:14 -04:00
parent 6afa51142d
commit fe2e5ce649
3 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp
View File

@@ -384,7 +384,7 @@ EscrowFinish::doApply()
JLOG(j_.trace()) << "The escrow has a finish function, running WASM code...";
// WASM execution
auto const wasmStr = slep->getFieldVL(sfFinishFunction);
std::vector<uint8_t> wasm(wasmStr.begin(), wasmStr.end());
std::vector<uint8_t> const wasm(wasmStr.begin(), wasmStr.end());
WasmHostFunctionsImpl ledgerDataProvider(ctx_, k);

19
src/test/app/EscrowSmart_test.cpp
View File

@@ -489,7 +489,7 @@ struct EscrowSmart_test : public beast::unit_test::suite
std::uint32_t const allowance = 467;
auto escrowCreate = escrow::create(alice, carol, XRP(1000));
auto [createFee, finishFee] = [&]() {
Env env(*this, features);
Env const env(*this, features);
auto createFee = env.current()->fees().base * 10 + ledgerSqnWasmHex.size() / 2 * 5;
auto finishFee = env.current()->fees().base +
(allowance * env.current()->fees().gasPrice) / MICRO_DROPS_PER_DROP + 1;
@@ -760,7 +760,8 @@ struct EscrowSmart_test : public beast::unit_test::suite
auto const seq = env.seq(alice);
BEAST_EXPECT(env.ownerCount(alice) == 0);
auto escrowCreate = escrow::create(alice, alice, XRP(1000));
XRPAmount txnFees = env.current()->fees().base * 10 + updateDataWasmHex.size() / 2 * 5;
XRPAmount const txnFees =
env.current()->fees().base * 10 + updateDataWasmHex.size() / 2 * 5;
env(escrowCreate,
escrow::finish_function(updateDataWasmHex),
escrow::finish_time(env.now() + 2s),
@@ -816,7 +817,7 @@ struct EscrowSmart_test : public beast::unit_test::suite
uint64_t const allowance = 467;
auto escrowCreate = escrow::create(alice, carol, XRP(1000));
auto createFee = [&]() {
Env env(*this, features);
Env const env(*this, features);
auto createFee = env.current()->fees().base * 10 + ledgerSqnWasmHex.size() / 2 * 5;
return createFee;
}();
@@ -853,7 +854,7 @@ struct EscrowSmart_test : public beast::unit_test::suite
env.close();
auto const bigAllowance = 996'433;
uint64_t partialFeeCalc =
uint64_t const partialFeeCalc =
(static_cast<uint64_t>(bigAllowance) * 1'000'000) / MICRO_DROPS_PER_DROP +
1; // to avoid an overflow
auto finishFee = env.current()->fees().base + partialFeeCalc;
@@ -910,7 +911,7 @@ struct EscrowSmart_test : public beast::unit_test::suite
auto const seq = env.seq(alice);
BEAST_EXPECT(env.ownerCount(alice) == 0);
auto escrowCreate = escrow::create(alice, carol, XRP(1000));
XRPAmount txnFees =
XRPAmount const txnFees =
env.current()->fees().base * 10 + allHostFunctionsWasmHex.size() / 2 * 5;
env(escrowCreate,
escrow::finish_function(allHostFunctionsWasmHex),
@@ -991,7 +992,7 @@ struct EscrowSmart_test : public beast::unit_test::suite
BEAST_EXPECT(env.ownerCount(alice) == 2);
// set up a bunch of objects to check their keylets
AMM amm(env, carol, XRP(10), carol["USD"](1000));
AMM const amm(env, carol, XRP(10), carol["USD"](1000));
env(check::create(alice, carol, XRP(100)));
env(credentials::create(alice, alice, "termsandconditions"));
env(delegate::set(alice, carol, {"TrustSet"}));
@@ -1004,11 +1005,11 @@ struct EscrowSmart_test : public beast::unit_test::suite
env(token::createOffer(carol, tokenId, XRP(100)), token::owner(alice));
env(offer(alice, carol["GBP"](0.1), XRP(100)));
env(paychan::create(alice, carol, XRP(1000), 100s, alice.pk()));
pdomain::Credentials credentials{{alice, "first credential"}};
pdomain::Credentials const credentials{{alice, "first credential"}};
env(pdomain::setTx(alice, credentials));
env(signers(alice, 1, {{carol, 1}}));
env(ticket::create(alice, 1));
Vault vault{env};
Vault const vault{env};
auto [tx, _keylet] = vault.create({.owner = alice, .asset = xrpIssue()});
env(tx);
env.close();
@@ -1017,7 +1018,7 @@ struct EscrowSmart_test : public beast::unit_test::suite
if (BEAST_EXPECTS(env.seq(alice) == 20, std::to_string(env.seq(alice))))
{
auto const seq = env.seq(alice);
XRPAmount txnFees =
XRPAmount const txnFees =
env.current()->fees().base * 10 + allKeyletsWasmHex.size() / 2 * 5;
env(escrow::create(alice, carol, XRP(1000)),
escrow::finish_function(allKeyletsWasmHex),

2
src/test/app/wasm_fixtures/fixtures.cpp
View File

@@ -88,7 +88,7 @@ generateDataBlob(uint32_t data_size)
appendBytes(wasm, FUNC_TYPE0);
// Memory Section: must be large enough for data_size
uint32_t pages = (data_size + 65535) / 65536;
uint32_t const pages = (data_size + 65535) / 65536;
std::vector<uint8_t> mem_p;
pushLeb128(mem_p, 1); // 1 memory defined
mem_p.push_back(0x00); // Flags (minimum only)