ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-28 09:30:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return invalid for bad root nodes

Browse Source
This commit is contained in:
Bart
2026-07-22 11:15:52 -04:00
parent 662205f865
commit f3654fa7ca
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/xrpld/app/ledger/detail/TransactionAcquire.cpp
View File

@@ -208,6 +208,7 @@ TransactionAcquire::takeNodes(
{
JLOG(journal_.warn()) << "TX acquire got bad root node for TX set " << hash_
<< " from peer " << peer->id();
return SHAMapAddNode::invalid();
}
else
{

10
src/xrpld/overlay/detail/PeerImp.cpp
View File

@@ -1718,15 +1718,15 @@ PeerImp::onMessage(std::shared_ptr<protocol::TMLedgerData> const& m)
// of the nodes is consistent - either all use the legacy format or the new format.
auto const peerSupportsNodeDepth =
peer->supportsFeature(ProtocolFeature::LedgerNodeDepth);
enum class MessageType { unknown, legacy, nodeDepth };
MessageType messageType = MessageType::unknown;
enum class MessageType { Unknown, Legacy, NodeDepth };
MessageType messageType = MessageType::Unknown;
for (int i = 0; i < m->nodes_size(); ++i)
{
auto* ledgerNode = m->mutable_nodes(i);
MessageType const msgType =
ledgerNode->has_nodeid() ? MessageType::legacy : MessageType::nodeDepth;
if (messageType != MessageType::unknown && messageType != msgType)
ledgerNode->has_nodeid() ? MessageType::Legacy : MessageType::NodeDepth;
if (messageType != MessageType::Unknown && messageType != msgType)
{
badData(
"Received mixed mode message while relaying ledger data for " +
@@ -1736,7 +1736,7 @@ PeerImp::onMessage(std::shared_ptr<protocol::TMLedgerData> const& m)
}
messageType = msgType;
if (peerSupportsNodeDepth || msgType == MessageType::legacy)
if (peerSupportsNodeDepth || msgType == MessageType::Legacy)
continue;
switch (ledgerNode->reference_case())