fix(telemetry): fix CI failures in MetricsRegistry test, levelization, and dashboard titles

- Update MockServiceRegistry to match current ServiceRegistry interface
  (17 method renames: get* prefix, PathRequests→PathRequestManager)
- Make throwUnimplemented() static to satisfy clang-tidy
- Regenerate levelization ordering.txt and loops.txt
- Remove 'rippled' prefix from 3 StatsD dashboard titles

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

.github/scripts/levelization/results/loops.txt

@@ -17,7 +17,7 @@ Loop: xrpld.app xrpld.shamap
   xrpld.shamap ~= xrpld.app
 
 Loop: xrpld.app xrpld.telemetry
-  xrpld.telemetry == xrpld.app
+  xrpld.telemetry ~= xrpld.app
 
 Loop: xrpld.overlay xrpld.rpc
   xrpld.rpc ~= xrpld.overlay

.github/scripts/levelization/results/ordering.txt

@@ -175,6 +175,8 @@ test.shamap > xrpl.basics
 test.shamap > xrpl.nodestore
 test.shamap > xrpl.protocol
 test.shamap > xrpl.shamap
+test.telemetry > xrpl.core
+test.telemetry > xrpld.telemetry
 test.toplevel > test.csf
 test.toplevel > xrpl.json
 test.unit_test > xrpl.basics
@@ -230,7 +232,6 @@ xrpld.app > xrpl.basics
 xrpld.app > xrpl.core
 xrpld.app > xrpld.consensus
 xrpld.app > xrpld.core
-xrpld.app > xrpld.telemetry
 xrpld.app > xrpl.json
 xrpld.app > xrpl.ledger
 xrpld.app > xrpl.net
@@ -289,6 +290,7 @@ xrpld.rpc > xrpl.tx
 xrpld.shamap > xrpl.shamap
 xrpld.telemetry > xrpl.basics
 xrpld.telemetry > xrpl.core
+xrpld.telemetry > xrpld.core
 xrpld.telemetry > xrpl.nodestore
 xrpld.telemetry > xrpl.protocol
 xrpld.telemetry > xrpl.rdb

docker/telemetry/grafana/dashboards/statsd-network-traffic.json

@@ -465,6 +465,6 @@
   "tags": ["rippled", "statsd", "network", "telemetry"],
   "templating": { "list": [] },
   "time": { "from": "now-1h", "to": "now" },
-  "title": "rippled Network Traffic (StatsD)",
+  "title": "Network Traffic (StatsD)",
   "uid": "rippled-statsd-network"
 }

docker/telemetry/grafana/dashboards/statsd-node-health.json

@@ -410,6 +410,6 @@
     "from": "now-1h",
     "to": "now"
   },
-  "title": "rippled Node Health (StatsD)",
+  "title": "Node Health (StatsD)",
   "uid": "rippled-statsd-node-health"
 }

docker/telemetry/grafana/dashboards/statsd-rpc-pathfinding.json

@@ -391,6 +391,6 @@
     "from": "now-1h",
     "to": "now"
   },
-  "title": "rippled RPC & Pathfinding (StatsD)",
+  "title": "RPC & Pathfinding (StatsD)",
   "uid": "rippled-statsd-rpc"
 }

src/test/telemetry/MetricsRegistry_test.cpp

@@ -29,8 +29,8 @@ namespace test {
 */
 class MockServiceRegistry : public ServiceRegistry
 {
-    [[noreturn]] void
-    throwUnimplemented() const
+    [[noreturn]] static void
+    throwUnimplemented()
     {
         Throw<std::logic_error>("MockServiceRegistry: method not implemented");
     }
@@ -48,7 +48,7 @@ public:
         throwUnimplemented();
     }
     TimeKeeper&
-    timeKeeper() override
+    getTimeKeeper() override
     {
         throwUnimplemented();
     }
@@ -63,7 +63,7 @@ public:
         throwUnimplemented();
     }
     CachedSLEs&
-    cachedSLEs() override
+    getCachedSLEs() override
     {
         throwUnimplemented();
     }
@@ -98,37 +98,37 @@ public:
         throwUnimplemented();
     }
     ValidatorList&
-    validators() override
+    getValidators() override
     {
         throwUnimplemented();
     }
     ValidatorSite&
-    validatorSites() override
+    getValidatorSites() override
     {
         throwUnimplemented();
     }
     ManifestCache&
-    validatorManifests() override
+    getValidatorManifests() override
     {
         throwUnimplemented();
     }
     ManifestCache&
-    publisherManifests() override
+    getPublisherManifests() override
     {
         throwUnimplemented();
     }
     Overlay&
-    overlay() override
+    getOverlay() override
     {
         throwUnimplemented();
     }
     Cluster&
-    cluster() override
+    getCluster() override
     {
         throwUnimplemented();
     }
     PeerReservationTable&
-    peerReservations() override
+    getPeerReservations() override
     {
         throwUnimplemented();
     }
@@ -183,17 +183,17 @@ public:
         throwUnimplemented();
     }
     PendingSaves&
-    pendingSaves() override
+    getPendingSaves() override
     {
         throwUnimplemented();
     }
     OpenLedger&
-    openLedger() override
+    getOpenLedger() override
     {
         throwUnimplemented();
     }
     OpenLedger const&
-    openLedger() const override
+    getOpenLedger() const override
     {
         throwUnimplemented();
     }
@@ -217,8 +217,8 @@ public:
     {
         throwUnimplemented();
     }
-    PathRequests&
-    getPathRequests() override
+    PathRequestManager&
+    getPathRequestManager() override
     {
         throwUnimplemented();
     }
@@ -248,7 +248,7 @@ public:
         return false;
     }
     beast::Journal
-    journal(std::string const&) override
+    getJournal(std::string const&) override
     {
         return beast::Journal(beast::Journal::getNullSink());
     }
@@ -258,12 +258,12 @@ public:
         throwUnimplemented();
     }
     Logs&
-    logs() override
+    getLogs() override
     {
         throwUnimplemented();
     }
     std::optional<uint256> const&
-    trapTxID() const override
+    getTrapTxID() const override
     {
         static std::optional<uint256> const empty;
         return empty;
@@ -274,7 +274,7 @@ public:
         throwUnimplemented();
     }
     Application&
-    app() override
+    getApp() override
     {
         throwUnimplemented();
     }