ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-25 16:10:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify rules for creating holdings in LoanSet

Browse Source 
- Lender and borrower both signed the transaction. Duh.
This commit is contained in:
Ed Hennis
2025-10-09 17:59:27 -04:00
parent 1efc532b21
commit ec20974cae
1 changed files with 31 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
src/xrpld/app/tx/detail/LoanSet.cpp
View File

@@ -425,19 +425,21 @@ LoanSet::doApply()
// from vault pseudo-account to the borrower.
// Create a holding for the borrower if one does not already exist.
if (borrower == account_)
{
if (auto const ter = addEmptyHolding(
view,
borrower,
borrowerSle->at(sfBalance).value().xrp(),
vaultAsset,
j_);
ter && ter != tecDUPLICATE)
// ignore tecDUPLICATE. That means the holding already exists, and
// is fine here
return ter;
}
XRPL_ASSERT_PARTS(
borrower == account_ || borrower == counterparty,
"ripple::LoanSet::doApply",
"borrower signed transaction");
if (auto const ter = addEmptyHolding(
view,
borrower,
borrowerSle->at(sfBalance).value().xrp(),
vaultAsset,
j_);
ter && ter != tecDUPLICATE)
// ignore tecDUPLICATE. That means the holding already exists, and
// is fine here
return ter;
if (auto const ter =
requireAuth(view, vaultAsset, borrower, AuthType::StrongAuth))
return ter;
@@ -448,19 +450,22 @@ LoanSet::doApply()
{
// Create the holding if it doesn't already exist (necessary for MPTs).
// The owner may have deleted their MPT / line at some point.
if (brokerOwner == account_)
{
if (auto const ter = addEmptyHolding(
view,
brokerOwner,
brokerOwnerSle->at(sfBalance).value().xrp(),
vaultAsset,
j_);
!isTesSuccess(ter) && ter != tecDUPLICATE)
// ignore tecDUPLICATE. That means the holding already exists,
// and is fine here
return ter;
}
XRPL_ASSERT_PARTS(
brokerOwner == account_ || brokerOwner == counterparty,
"ripple::LoanSet::doApply",
"broker owner signed transaction");
if (auto const ter = addEmptyHolding(
view,
brokerOwner,
brokerOwnerSle->at(sfBalance).value().xrp(),
vaultAsset,
j_);
!isTesSuccess(ter) && ter != tecDUPLICATE)
// ignore tecDUPLICATE. That means the holding already exists,
// and is fine here
return ter;
if (auto const ter = requireAuth(
view, vaultAsset, brokerOwner, AuthType::StrongAuth))
return ter;