fixup! Make a few tweaks to the changes in merge cc83ea8

This commit is contained in:
Ed Hennis
2025-07-11 17:14:53 -04:00
parent 9d052dc86c
commit e9d2dfe329
2 changed files with 10 additions and 3 deletions

View File

@@ -622,7 +622,7 @@ STTx::getBatchTransactionIDs() const
XRPL_ASSERT(
getFieldArray(sfRawTransactions).size() != 0,
"STTx::getBatchTransactionIDs : empty raw transactions");
// Don't early return so that the size check is always done.
// Don't early return so that the size assert is always hit.
if (batch_txn_ids_.size() == 0)
{
for (STObject const& rb : getFieldArray(sfRawTransactions))

View File

@@ -46,11 +46,18 @@ CreateOffer::makeTxConsequences(PreflightContext const& ctx)
bool
CreateOffer::isEnabled(PreflightContext const& ctx)
{
// TODO: Remove or update this check. Even though FlowCross was enabled a
// long time ago, if a network did manage to enable PermissionedDex and not
// FlowCross, then no offers of any kind would be allowed.
//
// Permissioned offers should use the PE (which must be enabled by
// featureFlowCross amendment)
if (ctx.rules.enabled(featurePermissionedDEX) &&
!ctx.rules.enabled(featureFlowCross))
return false;
return (!ctx.tx.isFieldPresent(sfDomainID)) ||
(ctx.rules.enabled(featurePermissionedDEX) &&
ctx.rules.enabled(featureFlowCross));
ctx.rules.enabled(featurePermissionedDEX);
}
std::uint32_t