ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-21 11:35:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

code review changes

Browse Source 
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
This commit is contained in:
Pratik Mankawde
2025-11-05 09:46:56 +00:00
parent 7ae3a85f21
commit e95299dac5
5 changed files with 14 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.github/actions/build-deps/action.yml vendored
View File

@@ -22,10 +22,9 @@ inputs:
required: false required: false
default: "verbose" default: "verbose"
sanitizers: sanitizers:
description: "The sanitizers to enable ('None', 'Address', 'Thread')." description: "The sanitizers to enable ('Address+UndefinedBehaviour' or 'Thread+UndefinedBehaviour')."
required: true required: true
type: string default: ""
default: "None"
runs: runs:
using: composite using: composite

11
.github/scripts/strategy-matrix/generate.py vendored
View File

@@ -124,11 +124,12 @@ def generate_strategy_matrix(all: bool, config: Config) -> list:
cmake_args = f'{cmake_args} -Dwextra=ON' cmake_args = f'{cmake_args} -Dwextra=ON'
if build_type == 'Release': if build_type == 'Release':
cmake_args = f'{cmake_args} -Dassert=ON' cmake_args = f'{cmake_args} -Dassert=ON'
if sanitizers == 'Address': if os['distro_version'] == 'bookworm':
cmake_args = f'{cmake_args} -fsanitize=address,undefined,float-divide-by-zero,unsigned-integer-overflow' if sanitizers == 'Address':
elif sanitizers == 'Thread': cmake_args += ' -fsanitize=address,undefined,float-divide-by-zero,unsigned-integer-overflow'
cmake_args = f'{cmake_args} -fsanitize=thread,undefined,float-divide-by-zero,unsigned-integer-overflow' elif sanitizers == 'Thread':
cmake_args += ' -fsanitize=thread,undefined,float-divide-by-zero,unsigned-integer-overflow'
# We skip all RHEL on arm64 due to a build failure that needs further # We skip all RHEL on arm64 due to a build failure that needs further
# investigation. # investigation.

5
.github/workflows/reusable-build-test-config.yml vendored
View File

@@ -25,10 +25,9 @@ on:
type: string type: string
required: true required: true
sanitizers: sanitizers:
description: "The sanitizers to enable ('None', 'Address', 'Thread')." description: "The sanitizers to enable ('Address+UndefinedBehaviour' or 'Thread+UndefinedBehaviour')."
required: true required: true
type: string default: ""
default: "None"
runs_on: runs_on:
description: Runner to run the job on as a JSON string description: Runner to run the job on as a JSON string

5
.github/workflows/reusable-build-test.yml vendored
View File

@@ -24,10 +24,9 @@ on:
type: string type: string
default: "minimal" default: "minimal"
sanitizers: sanitizers:
description: "The sanitizers to enable ('None', 'Address', 'Thread')." description: "The sanitizers to enable ('Address+UndefinedBehaviour' or 'Thread+UndefinedBehaviour')."
required: true required: true
type: string default: ""
default: "None"
secrets: secrets:
CODECOV_TOKEN: CODECOV_TOKEN:
description: "The Codecov token to use for uploading coverage reports." description: "The Codecov token to use for uploading coverage reports."

5
.github/workflows/reusable-build.yml vendored
View File

@@ -20,10 +20,9 @@ on:
required: true required: true
type: string type: string
sanitizers: sanitizers:
description: "The sanitizers to enable ('None', 'Address', 'Thread')." description: "The sanitizers to enable ('Address+UndefinedBehaviour' or 'Thread+UndefinedBehaviour')."
required: true required: true
type: string default: ""
default: "None"
runs_on: runs_on:
description: Runner to run the job on as a JSON string description: Runner to run the job on as a JSON string