code review changes

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>

.github/actions/build-deps/action.yml

@@ -22,10 +22,9 @@ inputs:
     required: false
     default: "verbose"
   sanitizers:
-    description: "The sanitizers to enable ('None', 'Address', 'Thread')."
+    description: "The sanitizers to enable ('Address+UndefinedBehaviour' or 'Thread+UndefinedBehaviour')."
     required: true
-    type: string
-    default: "None"
+    default: ""
 
 runs:
   using: composite

.github/scripts/strategy-matrix/generate.py

@@ -124,11 +124,12 @@ def generate_strategy_matrix(all: bool, config: Config) -> list:
             cmake_args = f'{cmake_args} -Dwextra=ON'
         if build_type == 'Release':
             cmake_args = f'{cmake_args} -Dassert=ON'
-
-        if sanitizers == 'Address':
-            cmake_args = f'{cmake_args} -fsanitize=address,undefined,float-divide-by-zero,unsigned-integer-overflow'
-        elif sanitizers == 'Thread':
-            cmake_args = f'{cmake_args} -fsanitize=thread,undefined,float-divide-by-zero,unsigned-integer-overflow'
+        
+        if os['distro_version'] == 'bookworm':
+            if sanitizers == 'Address':
+                cmake_args += ' -fsanitize=address,undefined,float-divide-by-zero,unsigned-integer-overflow'
+            elif sanitizers == 'Thread':
+                cmake_args += ' -fsanitize=thread,undefined,float-divide-by-zero,unsigned-integer-overflow'
 
         # We skip all RHEL on arm64 due to a build failure that needs further
         # investigation.

.github/workflows/reusable-build-test-config.yml

@@ -25,10 +25,9 @@ on:
         type: string
         required: true
       sanitizers:
-        description: "The sanitizers to enable ('None', 'Address', 'Thread')."
+        description: "The sanitizers to enable ('Address+UndefinedBehaviour' or 'Thread+UndefinedBehaviour')."
         required: true
-        type: string
-        default: "None"
+        default: ""
 
       runs_on:
         description: Runner to run the job on as a JSON string

.github/workflows/reusable-build-test.yml

@@ -24,10 +24,9 @@ on:
         type: string
         default: "minimal"
       sanitizers:
-        description: "The sanitizers to enable ('None', 'Address', 'Thread')."
+        description: "The sanitizers to enable ('Address+UndefinedBehaviour' or 'Thread+UndefinedBehaviour')."
         required: true
-        type: string
-        default: "None"
+        default: ""
     secrets:
       CODECOV_TOKEN:
         description: "The Codecov token to use for uploading coverage reports."

.github/workflows/reusable-build.yml

@@ -20,10 +20,9 @@ on:
         required: true
         type: string
       sanitizers:
-        description: "The sanitizers to enable ('None', 'Address', 'Thread')."
+        description: "The sanitizers to enable ('Address+UndefinedBehaviour' or 'Thread+UndefinedBehaviour')."
         required: true
-        type: string
-        default: "None"
+        default: ""
 
       runs_on:
         description: Runner to run the job on as a JSON string