Fix clang-tidy errors

include/xrpl/tx/invariants/MPTInvariant.h

@@ -86,7 +86,7 @@ private:
      * returns true if reqAuth is false or lsfMPTAuthorized was set at deletion.
      * For existing MPTokens, returns the result of requireAuth()
      */
-    bool
+    [[nodiscard]] bool
     isAuthorized(
         ReadView const& view,
         MPTID const& mptid,

src/libxrpl/ledger/helpers/NFTokenHelpers.cpp

@@ -27,6 +27,7 @@
 #include <xrpl/protocol/XRPAmount.h>
 #include <xrpl/protocol/nft.h>
 #include <xrpl/protocol/nftPageMask.h>
+#include <xrpl/protocol/UintTypes.h>
 
 #include <algorithm>
 #include <cstddef>

src/libxrpl/ledger/helpers/OfferHelpers.cpp

@@ -10,6 +10,7 @@
 #include <xrpl/protocol/STArray.h>  // IWYU pragma: keep
 #include <xrpl/protocol/STLedgerEntry.h>
 #include <xrpl/protocol/TER.h>
+#include <xrpl/protocol/LedgerFormats.h>
 
 #include <memory>
 

src/libxrpl/protocol/Quality.cpp

@@ -3,8 +3,10 @@
 #include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/protocol/Asset.h>
 #include <xrpl/protocol/STAmount.h>
+#include <xrpl/beast/utility/Zero.h>
 
 #include <cstdint>
+#include <limits>
 
 namespace xrpl {
 

src/libxrpl/protocol/STInteger.cpp

@@ -16,6 +16,7 @@
 #include <cstdint>
 #include <iterator>
 #include <string>
+#include <system_error>
 
 namespace xrpl {
 

src/libxrpl/protocol/STNumber.cpp

@@ -15,6 +15,7 @@
 #include <boost/regex/v5/regbase.hpp>
 #include <boost/regex/v5/regex.hpp>
 #include <boost/regex/v5/regex_match.hpp>
+#include <xrpl/protocol/Rules.h>
 
 #include <cstddef>
 #include <cstdint>

src/libxrpl/protocol/STValidation.cpp

@@ -12,6 +12,7 @@
 #include <xrpl/protocol/STBase.h>
 #include <xrpl/protocol/STObject.h>
 #include <xrpl/protocol/Serializer.h>
+#include <xrpl/protocol/KeyType.h>
 
 #include <cstddef>
 #include <utility>

src/libxrpl/tx/transactors/dex/AMMDeposit.cpp

@@ -21,7 +21,6 @@
 #include <xrpl/protocol/STTx.h>
 #include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/TxFlags.h>
-#include <xrpl/protocol/TxFormats.h>
 #include <xrpl/protocol/XRPAmount.h>
 #include <xrpl/tx/Transactor.h>
 

src/test/app/PayChan_test.cpp

@@ -38,6 +38,7 @@
 #include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/TxFlags.h>
 #include <xrpl/protocol/jss.h>
+#include <xrpl/beast/utility/Zero.h>
 
 #include <algorithm>
 #include <cassert>

src/test/jtx/impl/amount.cpp

@@ -12,6 +12,7 @@
 #include <cstdint>
 #include <iomanip>
 #include <ios>
+#include <limits>
 #include <ostream>
 #include <sstream>
 #include <string>

src/test/rpc/DepositAuthorized_test.cpp

@@ -11,6 +11,7 @@
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/TxFlags.h>
 #include <xrpl/protocol/jss.h>
+#include <xrpl/protocol/Protocol.h>
 
 #include <cassert>
 #include <cstdint>

src/xrpld/app/ledger/detail/BuildLedger.cpp

@@ -16,6 +16,8 @@
 #include <xrpl/protocol/LedgerHeader.h>
 #include <xrpl/protocol/Protocol.h>
 #include <xrpl/tx/apply.h>
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/SystemParameters.h>
 
 #include <cstddef>
 #include <exception>

src/xrpld/app/ledger/detail/InboundLedger.cpp

@@ -30,6 +30,8 @@
 #include <xrpl/shamap/SHAMapSyncFilter.h>
 
 #include <boost/iterator/function_output_iterator.hpp>
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/SystemParameters.h>
 
 #include <xrpl.pb.h>
 

src/xrpld/app/ledger/detail/LedgerPersistence.cpp

@@ -10,6 +10,8 @@
 #include <xrpl/ledger/PendingSaves.h>
 #include <xrpl/protocol/Rules.h>
 #include <xrpl/rdb/RelationalDatabase.h>
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/SystemParameters.h>
 
 #include <cstdint>
 #include <memory>

src/xrpld/app/ledger/detail/OpenLedger.cpp

@@ -23,6 +23,7 @@
 #include <xrpl/tx/apply.h>
 
 #include <boost/range/adaptor/transformed.hpp>
+#include <xrpl/protocol/SField.h>
 
 #include <xrpl.pb.h>
 

src/xrpld/app/main/Application.cpp

@@ -108,6 +108,8 @@
 #include <boost/system/detail/error_code.hpp>
 #include <boost/system/system_error.hpp>
 
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/SystemParameters.h>
 #include <date/date.h>
 
 #include <algorithm>

src/xrpld/app/misc/FeeVoteImpl.cpp

@@ -18,6 +18,7 @@
 #include <xrpl/shamap/SHAMap.h>
 #include <xrpl/shamap/SHAMapItem.h>
 #include <xrpl/shamap/SHAMapTreeNode.h>
+#include <xrpl/protocol/Protocol.h>
 
 #include <algorithm>
 #include <cstdint>

src/xrpld/rpc/handlers/orderbook/AMMInfo.cpp

@@ -23,6 +23,7 @@
 #include <xrpl/protocol/STAmount.h>
 #include <xrpl/protocol/jss.h>
 
+#include <xrpl/protocol/Feature.h>
 #include <date/date.h>
 
 #include <chrono>