ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-23 15:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

respond to comments

Browse Source
This commit is contained in:
Mayukha Vadari
2026-01-22 12:02:53 -05:00
parent b4fcf80df3
commit e42f243913
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/test/rpc/RPCCall_test.cpp
View File

@@ -1593,7 +1593,6 @@ static RPCCallTestData const rpcCallTestArray[] = {
"rnUy2SHTrB9DubsPmkJZUXTf5FcNDGrYEA",
"ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789",
"200",
"0",
"MyMarker",
"extra"},
R"({

13
src/xrpld/rpc/detail/RPCCall.cpp
View File

@@ -16,7 +16,6 @@
#include <xrpl/protocol/PublicKey.h>
#include <xrpl/protocol/RPCErr.h>
#include <xrpl/protocol/SystemParameters.h>
#include <xrpl/protocol/UintTypes.h>
#include <xrpl/protocol/jss.h>
#include <boost/algorithm/string/predicate.hpp>
@@ -300,6 +299,8 @@ private:
std::int32_t ledgerMin, ledgerMax;
if (auto const ledgerMinOpt = jvParseInt(jvParams[1u]))
{
// A value of -1 instructs the server to use the most recent
// validated ledger version available
ledgerMin = *ledgerMinOpt;
}
else
@@ -329,7 +330,7 @@ private:
if (iParams >= 4)
{
if (auto const limit = jvParseInt(jvParams[3u]))
if (auto const limit = jvParseUInt(jvParams[3u]))
jvRequest[jss::limit] = *limit;
else
return RPC::invalid_field_error(jss::limit);
@@ -390,10 +391,9 @@ private:
if (jvParams.size() >= 5)
{
if (auto const limit = jvParseInt(jvParams[4u]))
if (auto const limit = jvParseUInt(jvParams[4u]))
{
if (limit >= 0)
jvRequest[jss::limit] = *limit;
jvRequest[jss::limit] = *limit;
}
else
return RPC::invalid_field_error(jss::limit);
@@ -450,8 +450,7 @@ private:
std::size_t colon = ip.find_last_of(":");
jvRequest[jss::ip] = std::string{ip, 0, colon};
std::uint32_t port;
if (beast::lexicalCastChecked(port, std::string{ip, colon + 1}))
if (auto const port = jvParseUInt(std::string{ip, colon + 1}))
jvRequest[jss::port] = port;
else
return RPC::invalid_field_error(jss::port);