ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-21 14:20:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Use tecPSEUDO_ACCOUNT instead of tecNO_PERMISSION where relevant

Browse Source
This commit is contained in:
Bart
2026-07-16 16:32:54 -04:00
committed by Ayaz Salikhov
parent 6c793edf72
commit e1dae5f775
8 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libxrpl/tx/transactors/credentials/CredentialCreate.cpp
View File

@@ -101,7 +101,7 @@ CredentialCreate::preclaim(PreclaimContext const& ctx)
if (ctx.view.rules().enabled(fixCleanup3_3_0) && isPseudoAccount(subjectSle))
{
JLOG(ctx.j.trace()) << "Subject is a pseudo-account.";
return tecNO_PERMISSION;
return tecPSEUDO_ACCOUNT;
}
return tesSUCCESS;

2
src/libxrpl/tx/transactors/delegate/DelegateSet.cpp
View File

@@ -57,7 +57,7 @@ DelegateSet::preclaim(PreclaimContext const& ctx)
return tecNO_TARGET;
if (isPseudoAccount(sleAuthorize))
return tecNO_PERMISSION;
return tecPSEUDO_ACCOUNT;
// Deleting the delegate object is invalid if it doesn’t exist.
if (ctx.tx.getFieldArray(sfPermissions).empty() &&

2
src/libxrpl/tx/transactors/payment/DepositPreauth.cpp
View File

@@ -110,7 +110,7 @@ DepositPreauth::preclaim(PreclaimContext const& ctx)
if (ctx.view.rules().enabled(fixCleanup3_3_0) && isPseudoAccount(sleAuth))
{
JLOG(ctx.j.debug()) << "Authorized account is a pseudo-account.";
return tecNO_PERMISSION;
return tecPSEUDO_ACCOUNT;
}
// Verify that the Preauth entry they asked to add is not already

2
src/libxrpl/tx/transactors/sponsor/SponsorshipSet.cpp
View File

@@ -146,7 +146,7 @@ SponsorshipSet::preclaim(PreclaimContext const& ctx)
// Pseudo-accounts cannot participate in sponsorship.
if (isPseudoAccount(sponsorAccSle) || isPseudoAccount(sponseeSle))
return tecNO_PERMISSION;
return tecPSEUDO_ACCOUNT;
auto const sponsorshipSle = ctx.view.read(keylet::sponsorship(sponsorID, sponseeID));

2
src/test/app/Credentials_test.cpp
View File

@@ -580,7 +580,7 @@ struct Credentials_test : public beast::unit_test::Suite
return;
Account const vaultPseudo{"vault", sleVault->at(sfAccount)};
auto const expectedResult =
features[fixCleanup3_3_0] ? Ter(tecNO_PERMISSION) : Ter(tesSUCCESS);
features[fixCleanup3_3_0] ? Ter(tecPSEUDO_ACCOUNT) : Ter(tesSUCCESS);
env(credentials::create(vaultPseudo, issuer, credType), expectedResult);
env.close();

4
src/test/app/Delegate_test.cpp
View File

@@ -236,7 +236,7 @@ class Delegate_test : public beast::unit_test::Suite
env(delegate::set(gw, Account("unknown"), {"Payment"}), Ter(tecNO_TARGET));
}
// Delegating to a pseudo-account is not allowed, should return tecNO_PERMISSION
// Delegating to a pseudo-account is not allowed, should return tecPSEUDO_ACCOUNT
{
Vault const vault{env};
auto [tx, keylet] = vault.create({.owner = gw, .asset = xrpIssue()});
@@ -246,7 +246,7 @@ class Delegate_test : public beast::unit_test::Suite
auto const sleVault = env.le(keylet);
BEAST_EXPECT(sleVault);
Account const vaultPseudo{"vault", sleVault->at(sfAccount)};
env(delegate::set(gw, vaultPseudo, {"Payment"}), Ter(tecNO_PERMISSION));
env(delegate::set(gw, vaultPseudo, {"Payment"}), Ter(tecPSEUDO_ACCOUNT));
}
// non-delegable transaction

2
src/test/app/DepositAuth_test.cpp
View File

@@ -575,7 +575,7 @@ struct DepositPreauth_test : public beast::unit_test::Suite
Account const vaultPseudo{"vault", sleVault->at(sfAccount)};
auto const expectedResult =
features[fixCleanup3_3_0] ? Ter(tecNO_PERMISSION) : Ter(tesSUCCESS);
features[fixCleanup3_3_0] ? Ter(tecPSEUDO_ACCOUNT) : Ter(tesSUCCESS);
env(deposit::auth(alice, vaultPseudo), expectedResult);
env.close();
env.require(Owners(alice, features[fixCleanup3_3_0] ? 0 : 1));

8
src/test/app/Sponsor_test.cpp
View File

@@ -353,17 +353,17 @@ public:
Account const pseudoAcc("vault", vaultSle->getAccountID(sfAccount));
env.memoize(pseudoAcc);
// Sponsee is a pseudo account -> tecNO_PERMISSION
// Sponsee is a pseudo account -> tecPSEUDO_ACCOUNT
env(sponsor::set(sp, 0, 100, XRP(100)),
sponsor::SponseeAcc(pseudoAcc),
Ter(tecNO_PERMISSION));
Ter(tecPSEUDO_ACCOUNT));
env.close();
// Sponsor is a pseudo account -> tecNO_PERMISSION
// Sponsor is a pseudo account -> tecPSEUDO_ACCOUNT
// (submitted by bob with counterpartySponsor pointing to pseudo account)
env(sponsor::set(bob, tfDeleteObject),
sponsor::CounterpartySponsor(pseudoAcc),
Ter(tecNO_PERMISSION));
Ter(tecPSEUDO_ACCOUNT));
env.close();
}