ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-09-26 23:19:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(telemetry): Inject the send span's own context into consensus messages

Browse Source 
propose() and validate() both injected the ambient span context, but no
span is ever activated on the threads that reach them: the round span is
deliberately non-ambient and the validation span is parented through a
stored context. So no TraceContext was written, every receiving peer took
its standalone-span fallback, and the consensus receive spans arrived as
orphan trace roots.

Inject from the span in hand instead, which is the form the propagation
helper documents and the transaction relay path already uses.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Pratik Mankawde
2026-09-22 21:11:38 +01:00
parent cae3f3c477
commit daa82cea33
1 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/xrpld/app/consensus/RCLConsensus.cpp
View File

@@ -280,15 +280,16 @@ RCLConsensus::Adaptor::propose(RCLCxPeerPos::Proposal const& proposal)
app_.getHashRouter().addSuppression(suppression);
// Inject the current thread's active span context (e.g. the consensus
// round span) so receiving peers can link their proposal.receive span
// as a child of this trace.
// Inject this send span's own context, so receiving peers can parent their
// proposal.receive span to it. Reading the ambient context instead would
// find nothing: no span is activated on either thread that reaches here,
// and the round span is deliberately never ambient.
//
// The helper injects only when a span is actually active, so a node with
// telemetry compiled out, disabled by config, or simply not tracing this
// round sends no TraceContext at all rather than an empty one that makes
// every peer take its has_trace_context() branch for nothing.
telemetry::injectCurrentContext(prop);
// Injection writes only when the span is live, so a node with telemetry
// compiled out, disabled by config, or simply not tracing this round sends
// no TraceContext at all rather than an empty one that makes every peer
// take its has_trace_context() branch for nothing.
telemetry::injectSpanContext(span, prop);
app_.getOverlay().broadcast(prop);
}
@@ -1109,18 +1110,20 @@ RCLConsensus::Adaptor::validate(RCLCxLedger const& ledger, RCLTxSet const& txns,
// Broadcast to all our peers:
protocol::TMValidation val;
val.set_validation(serialized.data(), serialized.size());
// Inject the current thread's active span context so receiving
// peers can link their validation.receive span as a child.
// Inject this validation span's own context, so receiving peers can parent
// their validation.receive span to it. Reading the ambient context instead
// would find nothing: valSpan is parented through a stored context and is
// never activated on this thread.
//
// The trace_context appended below is outside the signature on
// `serialized`, so it is not covered by validation authenticity.
// Downstream consumers treat it as advisory only. A signature-covered
// trace context is a possible future enhancement.
//
// As on the proposal path, the helper injects only when a span is actually
// active, so a node that is not tracing sends no TraceContext at all
// rather than an empty one.
telemetry::injectCurrentContext(val);
// Injection writes only when the span is live, so a node that is not
// tracing sends no TraceContext at all rather than an empty one.
if (valSpan)
telemetry::injectSpanContext(*valSpan, val);
app_.getOverlay().broadcast(val);
// Publish to all our subscribers: