ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-02 08:55:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Properly handle incorrect port numbers in parseURL (fixes #4200)

Browse Source
This commit is contained in:
Chenna Keshava B S
2022-06-17 14:33:28 -07:00
committed by Nik Bougalis
parent 3172a816fa
commit d632f9f6c8
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/ripple/basics/impl/StringUtilities.cpp
View File

@@ -90,6 +90,13 @@ parseUrl(parsedURL& pUrl, std::string const& strUrl)
if (!port.empty())
{
pUrl.port = beast::lexicalCast<std::uint16_t>(port);
// For inputs larger than 2^32-1 (65535), lexicalCast returns 0.
// parseUrl returns false for such inputs.
if (pUrl.port == 0)
{
return false;
}
}
pUrl.path = smMatch[6];

7
src/test/basics/StringUtilities_test.cpp
View File

@@ -289,6 +289,13 @@ public:
BEAST_EXPECT(!parseUrl(pUrl, "nonsense"));
BEAST_EXPECT(!parseUrl(pUrl, "://"));
BEAST_EXPECT(!parseUrl(pUrl, ":///"));
BEAST_EXPECT(
!parseUrl(pUrl, "scheme://user:pass@domain:65536/abc:321"));
BEAST_EXPECT(!parseUrl(pUrl, "UPPER://domain:23498765/"));
BEAST_EXPECT(!parseUrl(pUrl, "UPPER://domain:0/"));
BEAST_EXPECT(!parseUrl(pUrl, "UPPER://domain:+7/"));
BEAST_EXPECT(!parseUrl(pUrl, "UPPER://domain:-7234/"));
BEAST_EXPECT(!parseUrl(pUrl, "UPPER://domain:@#$56!/"));
}
{