Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration

include/xrpl/telemetry/Telemetry.h

@@ -136,7 +136,7 @@ public:
      * Get the global Telemetry instance.
      * @return Pointer to the active instance, or nullptr if not started.
      */
-    static Telemetry*
+    [[nodiscard]] static Telemetry*
     getInstance()
     {
         return instance.load(std::memory_order_acquire);
@@ -276,10 +276,9 @@ public:
      * @param id  The node's base58-encoded public key or custom identifier.
      */
     virtual void
-    setServiceInstanceId(std::string const& id)
+    setServiceInstanceId([[maybe_unused]] std::string const& id)
     {
         // Default no-op for NullTelemetry implementations.
-        (void)id;
     }
 
     /**
@@ -339,7 +338,7 @@ public:
      * @param name  Tracer name used to identify the instrumentation library.
      * @return A shared pointer to the Tracer.
      */
-    virtual opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer>
+    [[nodiscard]] virtual opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer>
     getTracer(std::string_view name = kTracerName) = 0;
 
     /**
@@ -357,7 +356,7 @@ public:
      * - kConsumer: async message receive
      * @return A shared pointer to the new Span.
      */
-    virtual opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>
+    [[nodiscard]] virtual opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>
     startSpan(
         std::string_view name,
         opentelemetry::trace::SpanKind kind = opentelemetry::trace::SpanKind::kInternal) = 0;
@@ -373,7 +372,7 @@ public:
      * @param kind           The span kind (defaults to kInternal).
      * @return A shared pointer to the new Span.
      */
-    virtual opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>
+    [[nodiscard]] virtual opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>
     startSpan(
         std::string_view name,
         opentelemetry::context::Context const& parentContext,