Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration

include/xrpl/telemetry/Telemetry.h

@@ -136,7 +136,7 @@ public:
      * Get the global Telemetry instance.
      * @return Pointer to the active instance, or nullptr if not started.
      */
-    static Telemetry*
+    [[nodiscard]] static Telemetry*
     getInstance()
     {
         return instance.load(std::memory_order_acquire);
@@ -276,10 +276,9 @@ public:
      * @param id  The node's base58-encoded public key or custom identifier.
      */
     virtual void
-    setServiceInstanceId(std::string const& id)
+    setServiceInstanceId([[maybe_unused]] std::string const& id)
     {
         // Default no-op for NullTelemetry implementations.
-        (void)id;
     }
 
     /**
@@ -339,7 +338,7 @@ public:
      * @param name  Tracer name used to identify the instrumentation library.
      * @return A shared pointer to the Tracer.
      */
-    virtual opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer>
+    [[nodiscard]] virtual opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer>
     getTracer(std::string_view name = kTracerName) = 0;
 
     /**
@@ -357,7 +356,7 @@ public:
      * - kConsumer: async message receive
      * @return A shared pointer to the new Span.
      */
-    virtual opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>
+    [[nodiscard]] virtual opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>
     startSpan(
         std::string_view name,
         opentelemetry::trace::SpanKind kind = opentelemetry::trace::SpanKind::kInternal) = 0;
@@ -373,7 +372,7 @@ public:
      * @param kind           The span kind (defaults to kInternal).
      * @return A shared pointer to the new Span.
      */
-    virtual opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>
+    [[nodiscard]] virtual opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>
     startSpan(
         std::string_view name,
         opentelemetry::context::Context const& parentContext,

src/libxrpl/telemetry/NullTelemetry.cpp

@@ -104,7 +104,7 @@ public:
     }
 
 #ifdef XRPL_ENABLE_TELEMETRY
-    opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer>
+    [[nodiscard]] opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer>
     getTracer(std::string_view) override
     {
         static auto noopTracer = opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer>(
@@ -112,14 +112,14 @@ public:
         return noopTracer;
     }
 
-    opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>
+    [[nodiscard]] opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>
     startSpan(std::string_view, opentelemetry::trace::SpanKind) override
     {
         return opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>(
             new opentelemetry::trace::NoopSpan(nullptr));
     }
 
-    opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>
+    [[nodiscard]] opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>
     startSpan(
         std::string_view,
         opentelemetry::context::Context const&,

src/libxrpl/telemetry/Telemetry.cpp

@@ -216,7 +216,7 @@ public:
         return false;
     }
 
-    opentelemetry::nostd::shared_ptr<trace_api::Tracer>
+    [[nodiscard]] opentelemetry::nostd::shared_ptr<trace_api::Tracer>
     getTracer(std::string_view) override
     {
         static auto noopTracer =
@@ -224,13 +224,13 @@ public:
         return noopTracer;
     }
 
-    opentelemetry::nostd::shared_ptr<trace_api::Span>
+    [[nodiscard]] opentelemetry::nostd::shared_ptr<trace_api::Span>
     startSpan(std::string_view, trace_api::SpanKind) override
     {
         return opentelemetry::nostd::shared_ptr<trace_api::Span>(new trace_api::NoopSpan(nullptr));
     }
 
-    opentelemetry::nostd::shared_ptr<trace_api::Span>
+    [[nodiscard]] opentelemetry::nostd::shared_ptr<trace_api::Span>
     startSpan(std::string_view, opentelemetry::context::Context const&, trace_api::SpanKind)
         override
     {
@@ -430,7 +430,7 @@ public:
         return setup_.traceLedger;
     }
 
-    opentelemetry::nostd::shared_ptr<trace_api::Tracer>
+    [[nodiscard]] opentelemetry::nostd::shared_ptr<trace_api::Tracer>
     getTracer(std::string_view name = kTracerName) override
     {
         if (!sdkProvider_)
@@ -440,7 +440,7 @@ public:
         return sdkProvider_->GetTracer(std::string(name));
     }
 
-    opentelemetry::nostd::shared_ptr<trace_api::Span>
+    [[nodiscard]] opentelemetry::nostd::shared_ptr<trace_api::Span>
     startSpan(std::string_view name, trace_api::SpanKind kind) override
     {
         auto tracer = getTracer();
@@ -449,7 +449,7 @@ public:
         return tracer->StartSpan(std::string(name), opts);
     }
 
-    opentelemetry::nostd::shared_ptr<trace_api::Span>
+    [[nodiscard]] opentelemetry::nostd::shared_ptr<trace_api::Span>
     startSpan(
         std::string_view name,
         opentelemetry::context::Context const& parentContext,

src/libxrpl/telemetry/TelemetryConfig.cpp

@@ -65,7 +65,7 @@ constexpr std::uint32_t maxQueueSize = 2048u;
  * @param networkId  The network identifier from [network_id] config.
  * @return "mainnet", "testnet", "devnet", or "unknown" for other values.
  */
-std::string
+[[nodiscard]] std::string
 networkTypeFromId(std::uint32_t networkId)
 {
     switch (networkId)