ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 00:36:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Add another rounding unit test

Browse Source
This commit is contained in:
Ed Hennis
2026-05-29 19:03:34 -04:00
parent f6a26ca34f
commit d1af39d9dd
1 changed files with 41 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/test/basics/Number_test.cpp
View File

@@ -1869,6 +1869,47 @@ public:
break;
}
}
{
testcase << "normalization cusp: ToNearest and Downward disagree" << to_string(scale);
constexpr auto kMaxRep = Number::kMaxRep;
// Both ToNearest and Downward should round to `below`
auto const actual = static_cast<std::uint64_t>(kMaxRep) + 1;
Number const below{static_cast<std::int64_t>(kMaxRep), 0};
Number const above{
false, static_cast<std::uint64_t>(kMaxRep) + 3, 0, Number::Unchecked{}};
Number toNearest;
{
NumberRoundModeGuard const roundGuard{Number::RoundingMode::ToNearest};
toNearest = Number(false, actual, 0, Number::Normalized{});
}
Number downward;
{
NumberRoundModeGuard const roundGuard{Number::RoundingMode::Downward};
downward = Number(false, actual, 0, Number::Normalized{});
}
log << "\n"
<< " actual = " << actual << " (kMaxRep + 1)\n"
<< " below = " << below << " (kMaxRep, distance 1)\n"
<< " above = " << above << " (kMaxRep + 3, distance 2)\n"
<< " ToNearest = " << toNearest << "\n"
<< " Downward = " << downward << "\n\n";
// ToNearest rounds UP when the DOWN neighbor is strictly closer
BEAST_EXPECT(toNearest == above);
BEAST_EXPECT(toNearest != below);
// Downward undershoots: it returns a value below `below`
BEAST_EXPECT(downward < below);
// Both should have given the same answer, but they differ
BEAST_EXPECT(toNearest != downward);
}
}
void