ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-19 21:21:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a couple of issues: fix error check, remove incorrect test

Browse Source
This commit is contained in:
Ed Hennis
2026-07-16 18:59:26 -04:00
parent e0ced0e375
commit cbf2c87d7c
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libxrpl/basics/Number.cpp
View File

@@ -429,10 +429,10 @@ Number::Guard::doDropDigitWithTarget(T& mantissa, int& exponent, int const targe
{
XRPL_ASSERT(
targetExponent > exponent, "Number::Guard::doDropDigitWithTarget : something to do");
if (mantissa == 0 && unrecoverable() && targetExponent >= exponent)
if (mantissa == 0 && unrecoverable() && targetExponent > exponent)
{
// No number of dropped digits is going to change any of the operative parameters at this
// point
// point.
exponent = targetExponent;
return;
}

6
src/test/protocol/STNumber_test.cpp
View File

@@ -185,14 +185,16 @@ struct STNumber_test : public beast::unit_test::Suite
}
catch (std::exception const& e)
{
BEAST_EXPECT(std::string(e.what()) == expected);
std::ostringstream out;
out << "Json: " << num.asString() << " got exception: " << e.what()
<< ", expected: " << expected;
BEAST_EXPECTS(std::string(e.what()) == expected, out.str());
}
};
// Obvious overflows tested here
expectJsonThrows("1e2000000", "Number::normalize 2");
expectJsonThrows("1e2000000000", "Number::normalize 2");
expectJsonThrows("1e2000000000000", "Number::normalize 2");
// Obvious non-numbers tested here
expectJsonThrows("", "'' is not a number");