mirror of
https://github.com/XRPLF/rippled.git
synced 2026-08-21 14:20:56 +00:00
test(telemetry): name the metrics under test instead of plan task numbers
The integration-test sections, alert provisioning headers and a naming-check test comment were indexed by rollout phase and task numbers defined only in planning documents outside the shipped tree. Each now names what it covers.
This commit is contained in:
@@ -509,7 +509,7 @@ class RuleEAllowDottedMarkerEnforcement(unittest.TestCase):
|
||||
)
|
||||
|
||||
def test_all_named_keys_exempt_on_a_table_row(self):
|
||||
# The real shape in the plan docs: a "was -> is now" row naming two old
|
||||
# The real-world shape: a "was -> is now" row naming two old
|
||||
# dotted keys, with both listed in the marker.
|
||||
tokens, _ = _run_rule_e_docs(
|
||||
{
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
# Grafana contact-point provisioning for rippled OTel alerts.
|
||||
#
|
||||
# Phase 9: Internal metric gap fill — alerting on health-critical metrics.
|
||||
# Alerting on health-critical internal metrics.
|
||||
#
|
||||
# A contact point is where a firing alert is delivered. Two are defined:
|
||||
# xrpld-default — Slack only; receives warning-severity alerts.
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
# Grafana notification-policy provisioning for rippled OTel alerts.
|
||||
#
|
||||
# Phase 9: Internal metric gap fill — alerting on health-critical metrics.
|
||||
# Alerting on health-critical internal metrics.
|
||||
#
|
||||
# The notification policy tree decides which contact point receives a firing
|
||||
# alert and how alerts are batched. Routing is split by severity:
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
# Grafana alert-rule provisioning for rippled OTel metrics.
|
||||
#
|
||||
# Phase 9: Internal metric gap fill — alerting on health-critical metrics.
|
||||
# Alerting on health-critical internal metrics.
|
||||
#
|
||||
# Thirteen rules across five subsystems: consensus/ledger health, validator
|
||||
# health, the job queue, node operating state, and the overlay (manifests).
|
||||
|
||||
@@ -660,10 +660,10 @@ else
|
||||
fi
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Step 10c: Verify Phase 9 OTel SDK Metrics
|
||||
# Step 10c: Verify OTel SDK Metrics
|
||||
# ---------------------------------------------------------------------------
|
||||
log ""
|
||||
log "--- Phase 9: OTel SDK Metrics (MetricsRegistry) ---"
|
||||
log "--- OTel SDK Metrics (MetricsRegistry) ---"
|
||||
log "Waiting 15s for OTel metric export + Prometheus scrape..."
|
||||
sleep 15
|
||||
|
||||
@@ -679,34 +679,34 @@ check_otel_metric() {
|
||||
fi
|
||||
}
|
||||
|
||||
# Task 9.1: NodeStore I/O
|
||||
# NodeStore I/O
|
||||
check_otel_metric 'nodestore_state{metric="node_reads_total"}'
|
||||
check_otel_metric 'nodestore_state{metric="write_load"}'
|
||||
|
||||
# Task 9.2: Cache hit rates
|
||||
# Cache hit rates
|
||||
check_otel_metric 'cache_metrics{metric="SLE_hit_rate"}'
|
||||
check_otel_metric 'cache_metrics{metric="treenode_cache_size"}'
|
||||
|
||||
# Task 9.3: TxQ metrics
|
||||
# TxQ metrics
|
||||
check_otel_metric 'txq_metrics{metric="txq_count"}'
|
||||
check_otel_metric 'txq_metrics{metric="txq_reference_fee_level"}'
|
||||
|
||||
# Task 9.4: Per-RPC metrics
|
||||
# Per-RPC metrics
|
||||
check_otel_metric "rpc_method_started_total"
|
||||
check_otel_metric "rpc_method_finished_total"
|
||||
|
||||
# Task 9.5: Per-job metrics
|
||||
# Per-job metrics
|
||||
check_otel_metric "job_queued_total"
|
||||
check_otel_metric "job_finished_total"
|
||||
|
||||
# Task 9.6: Counted object instances
|
||||
# Counted object instances
|
||||
check_otel_metric "object_count"
|
||||
|
||||
# Task 9.7: Load factor breakdown
|
||||
# Load factor breakdown
|
||||
check_otel_metric 'load_factor_metrics{metric="load_factor"}'
|
||||
check_otel_metric 'load_factor_metrics{metric="load_factor_server"}'
|
||||
|
||||
# Task 7.15 / Phase 9: ValidationTracker rolling-window agreement gauge.
|
||||
# ValidationTracker rolling-window agreement gauge.
|
||||
# MetricsRegistry::registerValidationAgreementGauge() publishes
|
||||
# validation_agreement with a `metric` label for each window
|
||||
# (1h / 24h / 7d) plus the matching agreement/miss counts. The 7-day
|
||||
|
||||
Reference in New Issue
Block a user