ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-23 15:10:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix clang-tidy

Browse Source
This commit is contained in:
Mayukha Vadari
2026-07-21 18:43:08 -04:00
parent 8763260b55
commit c67e41d795
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/test/rpc/LedgerRPC_test.cpp
View File

@@ -24,6 +24,7 @@
#include <xrpl/protocol/TER.h>
#include <xrpl/protocol/jss.h>
#include <cstdint>
#include <memory>
#include <string>
#include <utility>
@@ -755,9 +756,9 @@ class LedgerRPC_test : public beast::unit_test::Suite
BEAST_EXPECT(jrr[jss::status] == "success");
auto const& txns = jrr[jss::ledger][jss::transactions];
BEAST_EXPECT(txns.isArray() && txns.size() > 0);
for (unsigned i = 0; i < txns.size(); ++i)
for (auto const& txn : txns)
{
BEAST_EXPECT(txns[i].isMember(jss::ctid));
BEAST_EXPECT(txn.isMember(jss::ctid));
}
}
@@ -773,9 +774,9 @@ class LedgerRPC_test : public beast::unit_test::Suite
BEAST_EXPECT(jrr[jss::status] == "success");
auto const& txns = jrr[jss::ledger][jss::transactions];
BEAST_EXPECT(txns.isArray() && txns.size() > 0);
for (unsigned i = 0; i < txns.size(); ++i)
for (auto const& txn : txns)
{
BEAST_EXPECT(txns[i].isMember(jss::ctid));
BEAST_EXPECT(txn.isMember(jss::ctid));
}
}
@@ -789,9 +790,9 @@ class LedgerRPC_test : public beast::unit_test::Suite
BEAST_EXPECT(jrr[jss::status] == "success");
auto const& txns = jrr[jss::ledger][jss::transactions];
BEAST_EXPECT(txns.isArray() && txns.size() > 0);
for (unsigned i = 0; i < txns.size(); ++i)
for (auto const& txn : txns)
{
BEAST_EXPECT(txns[i].isString());
BEAST_EXPECT(txn.isString());
}
}
}

3
src/xrpld/app/ledger/detail/LedgerToJson.cpp
View File

@@ -29,6 +29,7 @@
#include <xrpl/protocol/jss.h>
#include <xrpl/protocol/serialize.h>
#include <cstdint>
#include <exception>
#include <memory>
#include <string>
@@ -196,7 +197,7 @@ fillJsonTx(
}
// compute outgoing CTID
if (fill.context && stMeta && stMeta->isFieldPresent(sfTransactionIndex))
if ((fill.context != nullptr) && stMeta && stMeta->isFieldPresent(sfTransactionIndex))
{
uint32_t const lgrSeq = fill.ledger.seq();
uint32_t const txnIdx = stMeta->getFieldU32(sfTransactionIndex);