ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-22 23:00:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update list of "constant" fields from spec

Browse Source 
- Also add a general check for all object types for the type and index
  fields
This commit is contained in:
Ed Hennis
2025-03-19 17:16:38 -04:00
parent 319e7a6bcb
commit c6127ef034
2 changed files with 28 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/xrpld/app/tx/detail/InvariantCheck.cpp
View File

@@ -1591,11 +1591,7 @@ NoModifiedUnmodifiableFields::visitEntry(
// Creation and deletion are ignored
return;
auto const type = after->getType();
if (knownTypes_.contains(type))
{
changedEntries_.emplace(before, after);
}
changedEntries_.emplace(before, after);
}
bool
@@ -1628,7 +1624,12 @@ NoModifiedUnmodifiableFields::finalize(
* potential issues even when the amendment is disabled.
*/
enforce = view.rules().enabled(featureLendingProtocol);
bad = fieldChanged(before, after, sfVaultID) ||
bad = fieldChanged(before, after, sfLedgerEntryType) ||
fieldChanged(before, after, sfLedgerIndex) ||
fieldChanged(before, after, sfSequence) ||
fieldChanged(before, after, sfOwnerNode) ||
fieldChanged(before, after, sfVaultNode) ||
fieldChanged(before, after, sfVaultID) ||
fieldChanged(before, after, sfAccount) ||
fieldChanged(before, after, sfOwner) ||
fieldChanged(before, after, sfManagementFeeRate) ||
@@ -1642,7 +1643,12 @@ NoModifiedUnmodifiableFields::finalize(
* potential issues even when the amendment is disabled.
*/
enforce = view.rules().enabled(featureLendingProtocol);
bad = fieldChanged(before, after, sfLoanBrokerID) ||
bad = fieldChanged(before, after, sfLedgerEntryType) ||
fieldChanged(before, after, sfLedgerIndex) ||
fieldChanged(before, after, sfSequence) ||
fieldChanged(before, after, sfOwnerNode) ||
fieldChanged(before, after, sfLoanBrokerNode) ||
fieldChanged(before, after, sfLoanBrokerID) ||
fieldChanged(before, after, sfBorrower) ||
fieldChanged(before, after, sfLoanOriginationFee) ||
fieldChanged(before, after, sfLoanServiceFee) ||
@@ -1653,12 +1659,23 @@ NoModifiedUnmodifiableFields::finalize(
fieldChanged(before, after, sfLateInterestRate) ||
fieldChanged(before, after, sfCloseInterestRate) ||
fieldChanged(before, after, sfOverpaymentInterestRate) ||
fieldChanged(before, after, sfPaymentInterval);
fieldChanged(before, after, sfStartDate) ||
fieldChanged(before, after, sfPaymentInterval)
fieldChanged(before, after, sfGracePeriod);
break;
default:
UNREACHABLE(
"ripple::NoModifiedUnmodifiableFields::finalize : unknown "
"SLE type");
/*
* We check this invariant regardless of lending protocol
* amendment status, allowing for detection and logging of
* potential issues even when the amendment is disabled.
*
* We use the lending protocol as a gate, even though
* all transactions are affected because that's when it
* was added.
*/
enforce = view.rules().enabled(featureLendingProtocol);
bad = fieldChanged(before, after, sfLedgerEntryType) ||
fieldChanged(before, after, sfLedgerIndex);
}
XRPL_ASSERT(
!bad || enforce,

2
src/xrpld/app/tx/detail/InvariantCheck.h
View File

@@ -627,8 +627,6 @@ public:
*/
class NoModifiedUnmodifiableFields
{
std::set<LedgerEntryType> const knownTypes_{ltLOAN_BROKER, ltLOAN};
std::set<std::pair<SLE::const_pointer, SLE::const_pointer>> changedEntries_;
public: