ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-23 15:10:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix MPT DEX Freeze Bypass - Remove redundant MPT DEX lock check in BookStep

Browse Source
This commit is contained in:
Gregory Tsipenyuk
2026-06-07 11:37:17 -04:00
parent 6977cb8926
commit bafbb70b49
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/libxrpl/tx/paths/BookStep.cpp
View File

@@ -1405,6 +1405,13 @@ template <class TIn, class TOut, class TDerived>
bool
BookStep<TIn, TOut, TDerived>::checkMPTDEX(ReadView const& view, AccountID const& owner) const
{
// Offer-owner locks on book_.in and book_.out are handled by the
// liquidity sources before an offer reaches this point. OfferStream
// filters CLOB offers through the assetIn deep-freeze check and the
// assetOut owner-funds check using FreezeHandling::ZeroIfFrozen, while
// AMMLiquidity gets pool balances through ammAccountHolds(), which zeroes
// locked holdings. This method only enforces MPT trade and transfer
// permissions.
if (!isTesSuccess(canTrade(view, book_.in)) || !isTesSuccess(canTrade(view, book_.out)))
return false;
@@ -1418,14 +1425,8 @@ BookStep<TIn, TOut, TDerived>::checkMPTDEX(ReadView const& view, AccountID const
// Offer's owner is an issuer
if (asset.getIssuer() == owner)
return true;
// The previous step could be MPTEndpointStep with non issuer account or
// BookStep. Fail both if in asset is locked. In the former case it is holder
// to locked holder transfer. In the latter case it is not possible to tell if
// it is issuer to holder or holder to holder transfer.
if (isFrozen(view, owner, book_.in.get<MPTIssue>()))
return false;
// Previous step is BookStep. BookStep only sends if CanTransfer is
// set and not locked or the offer is owned by an issuer
// Previous BookStep already enforced transferability for the asset
// it sends to this offer.
if (prevStep_->bookStepBook())
return true;
// Previous step is MPTEndpointStep and offer's owner is not an