ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-27 17:10:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix test logic: use robust timing pattern for expired offer tests

Browse Source 
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-08-21 14:45:59 +00:00
committed by Mayukha Vadari
parent 0fd1dc12a5
commit b589551a5d
1 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/test/app/NFToken_test.cpp
View File

@@ -6050,8 +6050,8 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
}
// Test with buy offer as well
// Create a fresh expiration time for the buy offer
std::uint32_t const buyExpiration = lastClose(env) + 2;
// Create a buy offer with a reasonable expiration time
std::uint32_t const buyExpiration = lastClose(env) + 10;
uint256 const buyOfferIndex =
keylet::nftoffer(buyer, env.seq(buyer)).key;
env(token::createOffer(buyer, nftID, XRP(1)),
@@ -6059,14 +6059,13 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
token::expiration(buyExpiration));
env.close();
// Advance time to make the buy offer expired
env.close();
env.close();
env.close();
// After creating buy offer, it should exist regardless of amendment
BEAST_EXPECT(ownerCount(env, buyer) == 1);
// Advance time past the expiration
while (lastClose(env) < buyExpiration)
env.close();
// Try to accept the expired buy offer
env(token::acceptBuyOffer(issuer, buyOfferIndex), ter(tecEXPIRED));
env.close();
@@ -6100,7 +6099,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
{
// With amendment, create fresh expired offers for brokered test
// (previous ones were already cleaned up)
std::uint32_t const brokeredExpiration = lastClose(env) + 2;
std::uint32_t const brokeredExpiration = lastClose(env) + 10;
uint256 const sellOfferIndex2 =
keylet::nftoffer(issuer, env.seq(issuer)).key;
env(token::createOffer(issuer, nftID, XRP(1)),
@@ -6115,10 +6114,9 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
token::expiration(brokeredExpiration));
env.close();
// Advance time to make both offers expired
env.close();
env.close();
env.close();
// Advance time past the expiration
while (lastClose(env) < brokeredExpiration)
env.close();
// Try brokered accept with both offers expired
env(token::brokerOffers(buyer, buyOfferIndex2, sellOfferIndex2),