address reviews

This commit is contained in:
tequ
2025-11-06 17:53:07 +09:00
parent 774917db22
commit b4188a887a
4 changed files with 7 additions and 8 deletions

View File

@@ -65,7 +65,7 @@ constexpr std::uint32_t tfUniversalMask = ~tfUniversal;
// Sponsor flags (Global):
constexpr std::uint32_t tfSponsorFee = 0x00000001;
constexpr std::uint32_t tfSponsorReserve = 0x00000002;
constexpr std::uint32_t tfSponsorMask = tfSponsorFee | tfSponsorReserve;
constexpr std::uint32_t tfSponsorMask = tfSponsorFee | tfSponsorReserve;
// AccountSet flags:
constexpr std::uint32_t tfRequireDestTag = 0x00010000;

View File

@@ -30,7 +30,7 @@
// Add new amendments to the top of this list.
// Keep it sorted in reverse chronological order.
XRPL_FEATURE(Sponsor, Supported::yes, VoteBehavior::DefaultNo)
XRPL_FEATURE(Sponsor, Supported::no, VoteBehavior::DefaultNo)
XRPL_FIX (DirectoryLimit, Supported::yes, VoteBehavior::DefaultNo)
XRPL_FIX (IncludeKeyletFields, Supported::yes, VoteBehavior::DefaultNo)
XRPL_FEATURE(DynamicMPT, Supported::no, VoteBehavior::DefaultNo)

View File

@@ -96,7 +96,7 @@ enum class LedgerNameSpace : std::uint16_t {
PERMISSIONED_DOMAIN = 'm',
DELEGATE = 'E',
VAULT = 'V',
SPONSORSHIP = 'N',
SPONSORSHIP = '>',
// No longer used or supported. Left here to reserve the space
// to avoid accidental reuse.

View File

@@ -317,15 +317,14 @@ Transactor::checkSponsor(ReadView const& view, STTx const& tx)
if (!tx.isFieldPresent(sfSponsor))
return tesSUCCESS;
auto const txSponsor = tx.getFieldObject(sfSponsor);
auto const sponsorAcc = txSponsor.getAccountID(sfAccount);
auto const sponseeAcc = tx.getAccountID(sfAccount);
auto const hasSponsorSignature = tx.isFieldPresent(sfSponsorSignature);
if (!hasSponsorSignature)
{
auto const txSponsor = tx.getFieldObject(sfSponsor);
auto const sponsorAcc = txSponsor.getAccountID(sfAccount);
auto const sponseeAcc = tx.getAccountID(sfAccount);
auto const sponsorSle =
view.read(keylet::sponsor(sponsorAcc, sponseeAcc));