Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing

OpenTelemetryPlan/Phase3_taskList.md

@@ -90,7 +90,7 @@
     - Extract parent trace context from incoming `TMTransaction::trace_context` field (if present)
     - Create `tx.receive` span as child of extracted context (or new root if none)
     - Set attributes: `tx_hash`, `peer_id`, `tx_status`
-    - On HashRouter suppression (duplicate): set `suppressed=true`, add `tx.duplicate` event
+    - Create the span only after `HashRouter::shouldProcess()` accepts, so a dropped duplicate produces no span
     - Wrap validation call with child span `tx.validate`
     - Wrap relay with `tx.relay` span
   - When relaying to peers:
@@ -159,7 +159,7 @@
 
 - Edit `src/xrpld/overlay/detail/PeerImp.cpp` (in handleTransaction):
   - After calling `HashRouter::shouldProcess()` or `addSuppressionPeer()`:
-    - Record `suppressed` attribute (true/false)
+    - Start the span here, not before, so only transactions this node will process are traced
     - Record `tx_flags` showing current HashRouter state (SAVED, TRUSTED, etc.)
     - Add `tx.first_seen` or `tx.duplicate` event
 
@@ -373,7 +373,7 @@ This gives the best of both worlds: guaranteed cross-node correlation via determ
        **combine** with deterministic trace_id — use the protobuf span_id as parent
        to preserve relay ordering, but override trace_id with the deterministic one.
     4. If no protobuf context: create span under `detCtx` directly.
-    5. Set all existing attributes (`hash`, `peerId`, `peerVersion`, `suppressed`, etc.).
+    5. Set all existing attributes (`hash`, `peerId`, `peerVersion`, etc.).
 
   - **Combining deterministic trace_id with protobuf parent span_id**:
     When both are available, construct a synthetic `SpanContext` with: