ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clarify the code a comment applies to:

Browse Source 
The `seq & 0xff` does not depend of `diff`, so does not belong in the block that
defines `diff`.
This commit is contained in:
seelabs
2020-03-02 14:08:05 -08:00
committed by Carl Hua
parent 6529d3e6f7
commit b126641f13
1 changed files with 26 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
src/ripple/ledger/impl/View.cpp
View File

@@ -566,41 +566,39 @@ hashOfSeq (ReadView const& ledger, LedgerIndex seq,
if (seq == (ledger.seq() - 1))
return ledger.info().parentHash;
// Within 256...
if (int diff = ledger.seq() - seq; diff <= 256)
{
int diff = ledger.seq() - seq;
if (diff <= 256)
// Within 256...
auto const hashIndex =
ledger.read(keylet::skip());
if (hashIndex)
{
auto const hashIndex =
ledger.read(keylet::skip());
if (hashIndex)
{
assert (hashIndex->getFieldU32 (sfLastLedgerSequence) ==
(ledger.seq() - 1));
STVector256 vec = hashIndex->getFieldV256 (sfHashes);
if (vec.size () >= diff)
return vec[vec.size () - diff];
JLOG (journal.warn()) <<
"Ledger " << ledger.seq() <<
" missing hash for " << seq <<
" (" << vec.size () << "," << diff << ")";
}
else
{
JLOG (journal.warn()) <<
"Ledger " << ledger.seq() <<
":" << ledger.info().hash << " missing normal list";
}
assert (hashIndex->getFieldU32 (sfLastLedgerSequence) ==
(ledger.seq() - 1));
STVector256 vec = hashIndex->getFieldV256 (sfHashes);
if (vec.size () >= diff)
return vec[vec.size () - diff];
JLOG (journal.warn()) <<
"Ledger " << ledger.seq() <<
" missing hash for " << seq <<
" (" << vec.size () << "," << diff << ")";
}
if ((seq & 0xff) != 0)
else
{
JLOG (journal.debug()) <<
"Can't get seq " << seq <<
" from " << ledger.seq() << " past";
return boost::none;
JLOG (journal.warn()) <<
"Ledger " << ledger.seq() <<
":" << ledger.info().hash << " missing normal list";
}
}
if ((seq & 0xff) != 0)
{
JLOG (journal.debug()) <<
"Can't get seq " << seq <<
" from " << ledger.seq() << " past";
return boost::none;
}
// in skiplist
auto const hashIndex =
ledger.read(keylet::skip(seq));