ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-24 23:50:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(telemetry): RCLConsensus roundSpan_ is thread-free, not detached

Browse Source 
The roundSpan_ / roundSpanContext_ comments still described the old
'detached, Scope stripped' model. roundSpan_ is now a thread-free SpanGuard
(no Scope); children link via the captured roundSpanContext_.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Pratik Mankawde
2026-07-22 13:43:07 +01:00
parent b769542283
commit b0b174b94d
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/xrpld/app/consensus/RCLConsensus.h
View File

@@ -96,9 +96,9 @@ class RCLConsensus
* the trace_id is derived from previousLedger.id() so that all
* validators in the same round share the same trace_id.
*
* Stored detached: its Scope is stripped right after roundSpanContext_
* is captured, because it is emplaced and reset on different job
* workers. Child spans link via roundSpanContext_, not the ambient span.
* Thread-free: a SpanGuard owns no thread-local Scope, so it can be
* emplaced and reset on different job workers safely. Child spans link
* via roundSpanContext_ (captured once), not an ambient parent span.
*/
std::optional<telemetry::SpanGuard> roundSpan_;
@@ -290,10 +290,10 @@ class RCLConsensus
*
* The generic engine uses this to parent the phase spans it owns
* (consensus.phase.open, consensus.establish) under the round span
* without touching roundSpan_ across threads. roundSpan_ is detached
* after this context is captured, so it is no longer the thread's
* ambient parent; child spans must link via this context. Returns an
* invalid context before the round span is created.
* without touching roundSpan_ across threads. roundSpan_ is a
* thread-free SpanGuard (never an ambient parent), so child spans must
* link via this captured context. Returns an invalid context before the
* round span is created.
*
* @return The round span's captured context, or an invalid context.
*/