Fix some clang-tidy issues

include/xrpl/beast/unit_test/runner.h

@@ -67,7 +67,7 @@ public:
     }
 
     /** Returns the reference fee, if any. */
-    std::optional<std::int64_t> const&
+    [[nodiscard]] std::optional<std::int64_t> const&
     referenceFee() const
     {
         return referenceFee_;

include/xrpl/beast/unit_test/suite.h

@@ -285,7 +285,7 @@ public:
     referenceFee() const
     {
         assert(runner_);
-        if (!runner_)
+        if (runner_ == nullptr)
             return {};
         return runner_->referenceFee();
     }

src/libxrpl/ledger/CanonicalTXSet.cpp

@@ -42,7 +42,8 @@ CanonicalTXSet::accountKey(AccountID const& account)
 void
 CanonicalTXSet::insert(std::shared_ptr<STTx const> txn)
 {
-    Key key(accountKey(txn->getAccountID(sfAccount)), txn->getSeqProxy(), txn->getTransactionID());
+    Key const key(
+        accountKey(txn->getAccountID(sfAccount)), txn->getSeqProxy(), txn->getTransactionID());
     map_.emplace(key, std::move(txn));
 }
 

src/test/app/LedgerMaster_test.cpp

@@ -13,6 +13,7 @@
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/STObject.h>
 #include <xrpl/protocol/STTx.h>
+#include <xrpl/protocol/XRPAmount.h>
 
 #include <cstdint>
 #include <memory>

src/test/basics/PerfLog_test.cpp

@@ -28,6 +28,7 @@
 #include <iterator>
 #include <limits>
 #include <memory>
+#include <optional>
 #include <ostream>
 #include <random>
 #include <string>

src/test/core/ClosureCounter_test.cpp

@@ -7,6 +7,7 @@
 
 #include <atomic>
 #include <optional>
+#include <string>
 #include <thread>
 #include <utility>
 

src/test/jtx/impl/Env.cpp

@@ -47,6 +47,7 @@
 #include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/TxFlags.h>
 #include <xrpl/protocol/UintTypes.h>
+#include <xrpl/protocol/XRPAmount.h>
 #include <xrpl/protocol/jss.h>
 #include <xrpl/server/NetworkOPs.h>
 

src/test/rpc/AccountTx_test.cpp

@@ -34,6 +34,7 @@
 #include <xrpl/protocol/STAmount.h>
 #include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/TxFlags.h>
+#include <xrpl/protocol/XRPAmount.h>
 #include <xrpl/protocol/jss.h>
 
 #include <boost/container/flat_set.hpp>

src/test/rpc/DeliveredAmount_test.cpp

@@ -3,7 +3,6 @@
 #include <test/jtx/WSClient.h>
 #include <test/jtx/amount.h>
 #include <test/jtx/balance.h>
-#include <test/jtx/envconfig.h>
 #include <test/jtx/mpt.h>
 #include <test/jtx/pay.h>
 #include <test/jtx/sendmax.h>
@@ -19,10 +18,10 @@
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/TxFlags.h>
+#include <xrpl/protocol/XRPAmount.h>
 #include <xrpl/protocol/jss.h>
 
 #include <chrono>
-#include <utility>
 
 namespace xrpl::test {
 

src/test/rpc/LedgerClosed_test.cpp

@@ -2,15 +2,12 @@
 #include <test/jtx/Account.h>
 #include <test/jtx/Env.h>
 #include <test/jtx/amount.h>
-#include <test/jtx/envconfig.h>
 
 #include <xrpl/beast/unit_test/suite.h>
 #include <xrpl/protocol/Feature.h>
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/jss.h>
 
-#include <utility>
-
 namespace xrpl {
 
 class LedgerClosed_test : public beast::unit_test::Suite

src/test/rpc/LedgerEntry_test.cpp

@@ -46,6 +46,7 @@
 #include <xrpl/protocol/STVector256.h>
 #include <xrpl/protocol/STXChainBridge.h>
 #include <xrpl/protocol/TxFlags.h>
+#include <xrpl/protocol/XRPAmount.h>
 #include <xrpl/protocol/jss.h>
 
 #include <algorithm>

src/test/rpc/LedgerRPC_test.cpp

@@ -20,6 +20,7 @@
 #include <xrpl/json/to_string.h>
 #include <xrpl/protocol/ErrorCodes.h>
 #include <xrpl/protocol/TER.h>
+#include <xrpl/protocol/XRPAmount.h>
 #include <xrpl/protocol/jss.h>
 
 #include <memory>

src/test/rpc/LedgerRequest_test.cpp

@@ -5,16 +5,18 @@
 #include <test/jtx/amount.h>
 #include <test/jtx/envconfig.h>
 
+#include <xrpld/core/Config.h>
+
 #include <xrpl/beast/unit_test/suite.h>
 #include <xrpl/json/json_value.h>
 #include <xrpl/protocol/ApiVersion.h>
 #include <xrpl/protocol/ErrorCodes.h>
+#include <xrpl/protocol/XRPAmount.h>
 #include <xrpl/protocol/jss.h>
 
 #include <functional>
 #include <memory>
 #include <string>
-#include <utility>
 
 namespace xrpl::RPC {
 

src/test/rpc/TransactionEntry_test.cpp

@@ -1,12 +1,9 @@
 #include <test/jtx/Account.h>
 #include <test/jtx/Env.h>
 #include <test/jtx/amount.h>
-#include <test/jtx/envconfig.h>
 #include <test/jtx/offer.h>
 #include <test/jtx/pay.h>
 
-#include <xrpld/core/Config.h>
-
 #include <xrpl/basics/base_uint.h>
 #include <xrpl/basics/contract.h>
 #include <xrpl/beast/unit_test/suite.h>
@@ -15,6 +12,7 @@
 #include <xrpl/json/to_string.h>
 #include <xrpl/protocol/ApiVersion.h>
 #include <xrpl/protocol/ErrorCodes.h>
+#include <xrpl/protocol/XRPAmount.h>
 #include <xrpl/protocol/jss.h>
 
 #include <functional>

src/test/rpc/Transaction_test.cpp

@@ -24,6 +24,7 @@
 #include <xrpl/protocol/STObject.h>
 #include <xrpl/protocol/STTx.h>
 #include <xrpl/protocol/TER.h>
+#include <xrpl/protocol/XRPAmount.h>
 #include <xrpl/protocol/jss.h>
 #include <xrpl/protocol/serialize.h>
 

src/xrpld/app/main/Main.cpp

@@ -36,6 +36,7 @@
 #include <exception>
 #include <iostream>
 #include <memory>
+#include <optional>
 #include <ostream>
 #include <string>
 #include <vector>
@@ -548,7 +549,7 @@ run(int argc, char** argv)
 
         if (vm.contains("unittest-arg"))
             argument = vm["unittest-arg"].as<std::string>();
-        if (vm.count("unittest-fee"))
+        if (vm.contains("unittest-fee") != 0u)
             referenceFee = vm["unittest-fee"].as<std::int64_t>();
 
         std::size_t numJobs = 1;
@@ -571,8 +572,9 @@ run(int argc, char** argv)
     }
     // LCOV_EXCL_START
 
-    if (vm.count("unittest-jobs") || vm.count("unittest-arg") || vm.count("unittest-fee") ||
-        vm.count("unittest-log") || vm.count("unittest-ipv6"))
+    if ((vm.contains("unittest-jobs") != 0u) || (vm.contains("unittest-arg") != 0u) ||
+        (vm.contains("unittest-fee") != 0u) || (vm.contains("unittest-log") != 0u) ||
+        (vm.contains("unittest-ipv6") != 0u))
     {
         // unittest jobs only makes sense with `unittest`
         std::cerr << "xrpld: unittest-related parameter specified without '--unittest'.\n";