ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check LoanBrokerCoverWithdraw Destination and DestinationTag fields

Browse Source 
- See also #5572 / e7a7bb8
This commit is contained in:
Ed Hennis
2025-07-28 19:02:52 -04:00
parent 41c24094eb
commit a2be55fbc9
2 changed files with 33 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/test/app/LoanBroker_test.cpp
View File

@@ -27,6 +27,7 @@
#include <test/jtx/pay.h>
#include <test/jtx/seq.h>
#include <test/jtx/sig.h>
#include <test/jtx/tag.h>
#include <test/jtx/trust.h>
#include <test/jtx/vault.h>
@@ -399,6 +400,17 @@ class LoanBroker_test : public beast::unit_test::suite
destination(bystander),
ter(expected));
}
// Can not withdraw to the zero address
env(coverWithdraw(alice, keylet.key, vault.asset(1)),
destination(AccountID{}),
ter(temMALFORMED));
// If a destination tag is specified, a destination must be
// specified, too
env(coverWithdraw(alice, keylet.key, vault.asset(1)),
dtag(123),
ter(temMALFORMED));
verifyCoverAmount(10);
// Withdraw some of the cover amount
@@ -413,9 +425,17 @@ class LoanBroker_test : public beast::unit_test::suite
// Withdraw some more. Send it to Evan. Very generous, considering
// how much trouble he's been.
env(coverWithdraw(alice, keylet.key, vault.asset(2)),
env(coverWithdraw(alice, keylet.key, vault.asset(1)),
destination(evan));
env.close();
verifyCoverAmount(7);
// Withdraw some more. Send it to Evan. Very generous, considering
// how much trouble he's been.
env(coverWithdraw(alice, keylet.key, vault.asset(1)),
destination(evan),
dtag(3));
env.close();
verifyCoverAmount(6);
if (!vault.asset.raw().native())

14
src/xrpld/app/tx/detail/LoanBrokerCoverWithdraw.cpp
View File

@@ -63,10 +63,20 @@ LoanBrokerCoverWithdraw::preflight(PreflightContext const& ctx)
return temBAD_AMOUNT;
if (auto const destination = ctx.tx[~sfDestination];
destination && *destination == beast::zero)
destination.has_value())
{
if (*destination == beast::zero)
{
JLOG(ctx.j.debug())
<< "LoanBrokerCoverWithdraw: zero/empty destination account.";
return temMALFORMED;
}
}
else if (ctx.tx.isFieldPresent(sfDestinationTag))
{
JLOG(ctx.j.debug())
<< "LoanBrokerCoverWithdraw: zero/empty destination account.";
<< "LoanBrokerCoverWithdraw: sfDestinationTag is set but "
"sfDestination is not";
return temMALFORMED;
}