ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check for Grace Period overflow in LoanSet

Browse Source
This commit is contained in:
Ed Hennis
2025-11-07 15:40:50 -05:00
parent 77d5826297
commit 972841ae29
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/xrpld/app/tx/detail/LoanSet.cpp
View File

@@ -192,8 +192,8 @@ LoanSet::preclaim(PreclaimContext const& ctx)
{
// Check for numeric overflow of the schedule before we load any
// objects. NextPaymentDue date for the last payment is:
// startDate + (paymentInterval * paymentTotal).
// objects. The Grace Period for the last payment ends at:
// startDate + (paymentInterval * paymentTotal) + gracePeriod.
// If that value is larger than "maxTime", the value
// overflows, and we kill the transaction.
using timeType = decltype(sfNextPaymentDueDate)::type::value_type;
@@ -207,6 +207,13 @@ LoanSet::preclaim(PreclaimContext const& ctx)
ctx.tx.at(~sfPaymentInterval).value_or(defaultPaymentInterval);
auto const total =
ctx.tx.at(~sfPaymentTotal).value_or(defaultPaymentTotal);
auto const grace =
ctx.tx.at(~sfGracePeriod).value_or(defaultGracePeriod);
// The grace period can't be larger than the interval. Check it first,
// mostly so that unit tests can test that specific case.
if (grace > timeAvailable)
return tecKILLED;
if (interval > timeAvailable)
return tecKILLED;
@@ -214,7 +221,9 @@ LoanSet::preclaim(PreclaimContext const& ctx)
if (total > timeAvailable)
return tecKILLED;
if (timeAvailable / interval < total)
auto const timeLastPayment = timeAvailable - grace;
if (timeLastPayment / interval < total)
return tecKILLED;
}