ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-19 18:45:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize calls to unit_test::suite::expect:

Browse Source 
This changes expect and unexpected to receive the reason text as a
template argument, allowing the std::string conversion of char const*
parameters to take place only if the condition evaluates to false. This
cuts all calls to malloc and free on tests that pass.
This commit is contained in:
Vinnie Falco
2015-01-14 07:27:24 -08:00
parent 8432b9e29a
commit 92c9ebb0d6
1 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
beast/unit_test/suite.h
View File

@@ -164,9 +164,17 @@ public:
logged if the condition is false.
@return `true` if the test condition indicates success.
*/
template <class Condition, class String>
bool
expect (Condition shouldBeTrue,
String const& reason);
template <class Condition>
bool
expect (Condition shouldBeTrue, std::string const& reason = "");
expect (Condition shouldBeTrue)
{
return expect (shouldBeTrue, "");
}
/** Return the argument associated with the runner. */
std::string const&
@@ -177,9 +185,17 @@ public:
// DEPRECATED
// @return `true` if the test condition indicates success (a false value)
template <class Condition, class String>
bool
unexpected (Condition shouldBeFalse,
String const& reason);
template <class Condition>
bool
unexpected (Condition shouldBeFalse, std::string const& reason = "");
unexpected (Condition shouldBeFalse)
{
return unexpected (shouldBeFalse, "");
}
/** Record a successful test condition. */
template <class = void>
@@ -324,10 +340,11 @@ suite::operator() (runner& r)
run (r);
}
template <class Condition>
template <class Condition, class String>
inline
bool
suite::expect (Condition shouldBeTrue, std::string const& reason)
suite::expect (Condition shouldBeTrue,
String const& reason)
{
if (shouldBeTrue)
pass();
@@ -336,10 +353,11 @@ suite::expect (Condition shouldBeTrue, std::string const& reason)
return shouldBeTrue;
}
template <class Condition>
template <class Condition, class String>
inline
bool
suite::unexpected (Condition shouldBeFalse, std::string const& reason)
suite::unexpected (Condition shouldBeFalse,
String const& reason)
{
if (! shouldBeFalse)
pass();