ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-04 19:25:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't use set in AccountObjects test:

Browse Source 
Collecting the returned and expected values in sets only works if there are no
duplicates. The implementation is changed to use sorted vectors to fix this case.
This commit is contained in:
seelabs
2019-10-23 11:17:44 -07:00
committed by Manoj doshi
parent 15c5f9c111
commit 906b9ae00b
1 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/test/rpc/AccountObjects_test.cpp
View File

@@ -25,7 +25,7 @@
#include <boost/utility/string_ref.hpp>
#include <set>
#include <algorithm>
namespace ripple {
namespace test {
@@ -502,11 +502,14 @@ public:
params[jss::deletion_blockers_only] = true;
auto resp = env.rpc("json", "account_objects", to_string(params));
std::set<std::string> const expectedLedgerTypes{
{jss::Escrow.c_str(),
jss::Check.c_str(),
jss::RippleState.c_str(),
jss::PayChannel.c_str()}};
std::vector<std::string> const expectedLedgerTypes = [] {
std::vector<std::string> v{jss::Escrow.c_str(),
jss::Check.c_str(),
jss::RippleState.c_str(),
jss::PayChannel.c_str()};
std::sort(v.begin(), v.end());
return v;
}();
std::uint32_t const expectedAccountObjects{
static_cast<std::uint32_t>(std::size(expectedLedgerTypes))
@@ -515,11 +518,14 @@ public:
if (BEAST_EXPECT(acct_objs_is_size(resp, expectedAccountObjects)))
{
auto const& aobjs = resp[jss::result][jss::account_objects];
std::set<std::string> gotLedgerTypes;
std::vector<std::string> gotLedgerTypes;
gotLedgerTypes.reserve(expectedAccountObjects);
for (std::uint32_t i = 0; i < expectedAccountObjects; ++i)
{
gotLedgerTypes.insert(aobjs[i]["LedgerEntryType"].asString());
gotLedgerTypes.push_back(
aobjs[i]["LedgerEntryType"].asString());
}
std::sort(gotLedgerTypes.begin(), gotLedgerTypes.end());
BEAST_EXPECT(gotLedgerTypes == expectedLedgerTypes);
}
}