ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-09-28 07:48:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(app): run waitForReady on a fresh Env in the freshen test

Browse Source 
The freshen-resolvable test funded and closed a ledger before calling
waitForReady(env), but that helper asserts a freshly built Env (store
not yet rotated, validated ledger == 3). Its own assertions failed and
threw off ledgerSeq, so goodLedger then failed across the whole run (18
failures). Call waitForReady first, then drive the rotations, mirroring
testAutomatic's ledger accounting.
This commit is contained in:
Pratik Mankawde
2026-09-16 11:54:48 +01:00
parent 0969db8524
commit 8bf82c0e8b
1 changed files with 9 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/test/app/SHAMapStore_test.cpp
View File

@@ -1057,29 +1057,20 @@ public:
auto& store = env.app().getSHAMapStore();
auto& lm = env.app().getLedgerMaster();
// Real account state, so the state map carries inner nodes that the
// rotation must copy forward rather than an almost-empty tree.
auto const alice = Account("alice");
auto const bob = Account("bob");
env.fund(XRP(10000), alice, bob);
env.close();
// waitForReady() must run on a freshly built Env: it asserts the store
// has not rotated yet and that the validated ledger is the third one.
auto ledgerSeq = waitForReady(env);
auto lastRotated = store.getLastRotated();
auto lastRotated = ledgerSeq - 1;
BEAST_EXPECT(store.getLastRotated() == lastRotated);
// Two rotations. A payment each ledger mutates the state map so
// successive rotations copy forward genuinely different nodes, while
// alice's and bob's account roots persist unchanged across the archive
// boundary -- exactly the nodes the copy-forward must preserve.
// Two rotations, so the first rotation's archive is really deleted by
// the second. Funding a fresh account every ledger keeps adding
// state-map nodes, while accounts funded before the boundary must stay
// reachable afterwards -- exactly what the copy-forward preserves.
for (int rotation = 0; rotation < 2; ++rotation)
{
for (auto const target = store.getLastRotated() + kDeleteInterval + 1;
ledgerSeq < target;
++ledgerSeq)
for (; ledgerSeq < lastRotated + kDeleteInterval + 1; ++ledgerSeq)
{
// A fresh funded account each ledger adds new state-map
// nodes, so each rotation copies forward genuinely new data
// while alice's and bob's roots persist across the boundary.
env.fund(XRP(1000), Account("acct" + std::to_string(ledgerSeq)));
env.close();